-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper function all_gather_tensors_with_shapes()
#3281
Helper function all_gather_tensors_with_shapes()
#3281
Conversation
allgather_tensors_with_defferent_shapes()
all_gather_tensors_with_shapes()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
Co-authored-by: vfdev <[email protected]>
…-tensors-with-different-shapes' into feature-allgather-tensors-with-different-shapes
if isinstance(_model, _SerialModel) or group == dist.GroupMember.NON_GROUP_MEMBER: | ||
return [tensor] | ||
|
||
max_shape = torch.tensor(shapes).amax(dim=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we could actually get tensor shapes using all_gather
such that shapes
arg can be optional ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can. Do you want it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you, if you would like it in another PR, OK to me as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make it in another PR, I'll merge this one as CI is green
@sadra-barikbin there is a related to this PR failure on HVD GPU CI:
https://github.com/pytorch/ignite/actions/runs/10769410690/job/29860560970?pr=3283 Can you please check what happens? |
No description provided.