Skip to content

Commit

Permalink
remove gamma from cost constructor
Browse files Browse the repository at this point in the history
  • Loading branch information
BY571 committed Jul 9, 2024
1 parent 36e92cc commit 5476e36
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions torchrl/objectives/td3_bc.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

from torchrl.objectives.utils import (
_cache_values,
_GAMMA_LMBDA_DEPREC_ERROR,
_reduce,
_vmap_func,
default_value_kwargs,
Expand Down Expand Up @@ -238,7 +237,6 @@ def __init__(
loss_function: str = "smooth_l1",
delay_actor: bool = True,
delay_qvalue: bool = True,
gamma: float = None,
priority_key: str = None,
separate_losses: bool = False,
reduction: str = None,
Expand Down Expand Up @@ -319,8 +317,6 @@ def __init__(
high = high.to(device)
self.register_buffer("max_action", high)
self.register_buffer("min_action", low)
if gamma is not None:
raise TypeError(_GAMMA_LMBDA_DEPREC_ERROR)
self._vmap_qvalue_network00 = _vmap_func(
self.qvalue_network, randomness=self.vmap_randomness
)
Expand Down

0 comments on commit 5476e36

Please sign in to comment.