Skip to content

Commit

Permalink
[CI] Remove 3.8 jobs
Browse files Browse the repository at this point in the history
ghstack-source-id: f3abf910bbbb3e8c128e851fec96ca2e358cf818
Pull Request resolved: #2412
  • Loading branch information
vmoens committed Sep 2, 2024
1 parent e3384e2 commit 5a81930
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9
- name: Setup Environment
run: |
python3 -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu -U
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
- name: Python Setup
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9
- name: Setup git
run: git config --global --add safe.directory /__w/rl/rl
- name: setup Path
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/benchmarks_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Python Setup
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9
- name: Setup Environment
run: |
python3 -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu -U
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
- name: Python Setup
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9
- name: Setup git
run: git config --global --add safe.directory /__w/rl/rl
- name: setup Path
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
conda activate "${env_dir}"
# 2. upgrade pip, ninja and packaging
apt-get install python3.8 python3-pip -y
apt-get install python3.9 python3-pip -y
python3 -m pip install --upgrade pip
python3 -m pip install setuptools ninja packaging -U
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/nightly_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
python_version: [["3.8", "cp38-cp38"], ["3.9", "cp39-cp39"], ["3.10", "cp310-cp310"], ["3.11", "cp311-cp311"], ["3.12", "cp312-cp312"]]
python_version: [["3.9", "cp39-cp39"], ["3.10", "cp310-cp310"], ["3.11", "cp311-cp311"], ["3.12", "cp312-cp312"]]
cuda_support: [["", "cpu", "cpu"]]
container: pytorch/manylinux-${{ matrix.cuda_support[2] }}
steps:
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
python_version: [["3.8", "cp38-cp38"], ["3.9", "cp39-cp39"], ["3.10", "cp310-cp310"], ["3.11", "cp311-cp311"], ["3.12", "cp312-cp312"]]
python_version: [["3.9", "cp39-cp39"], ["3.10", "cp310-cp310"], ["3.11", "cp311-cp311"], ["3.12", "cp312-cp312"]]
cuda_support: [["", "cpu", "cpu"]]
container: pytorch/manylinux-${{ matrix.cuda_support[2] }}
steps:
Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
python_version: [["3.8", "cp38-cp38"], ["3.9", "cp39-cp39"], ["3.10", "cp310-cp310"], ["3.11", "cp311-cp311"], ["3.12", "cp312-cp312"]]
python_version: [["3.9", "cp39-cp39"], ["3.10", "cp310-cp310"], ["3.11", "cp311-cp311"], ["3.12", "cp312-cp312"]]
cuda_support: [["", "cpu", "cpu"]]
steps:
- name: Setup Python
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python_version: [["3.8", "3.8"], ["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
python_version: [["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
steps:
- name: Setup Python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -205,7 +205,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python_version: [["3.8", "3.8"], ["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
python_version: [["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
steps:
- name: Setup Python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -262,7 +262,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python_version: [["3.8", "3.8"], ["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
python_version: [["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
steps:
- name: Checkout torchrl
uses: actions/checkout@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
tests-cpu:
strategy:
matrix:
python_version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python_version: ["3.9", "3.10", "3.11", "3.12"]
fail-fast: false
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
with:
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
tests-optdeps:
strategy:
matrix:
python_version: ["3.10"] # "3.8", "3.9", "3.10", "3.11"
python_version: ["3.10"] # "3.9", "3.10", "3.11"
cuda_arch_version: ["12.1"] # "11.6", "11.7"
fail-fast: false
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
Expand Down Expand Up @@ -193,7 +193,7 @@ jobs:
tests-stable-gpu:
strategy:
matrix:
python_version: ["3.10"] # "3.8", "3.9", "3.10", "3.11"
python_version: ["3.10"] # "3.9", "3.10", "3.11"
cuda_arch_version: ["11.8"] # "11.6", "11.7"
fail-fast: false
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/wheels-legacy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python_version: [["3.8", "3.8"], ["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
python_version: [["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
steps:
- name: Setup Python
uses: actions/setup-python@v2
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
needs: build-wheel-windows
strategy:
matrix:
python_version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]
python_version: ["3.9", "3.10", "3.11", "3.12" ]
runs-on: windows-latest
steps:
- name: Setup Python
Expand Down

0 comments on commit 5a81930

Please sign in to comment.