flake8 errors

pytorch · Feb 29, 2024 · 64837f9 · 64837f9
1 parent 79d8a29
commit 64837f9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/test/test_cost.py b/test/test_cost.py
@@ -491,13 +491,10 @@ def test_dqn(self, delay_value, double_dqn, device, action_spec_type, td_est):
         )
         loss_fn = DQNLoss(
             actor,
-
             loss_function="l2",
-
             delay_value=delay_value,
-
             double_dqn=double_dqn,
-            return_tensorclass=False,,
+            return_tensorclass=False,
         )
         if td_est in (ValueEstimators.GAE, ValueEstimators.VTrace):
             with pytest.raises(NotImplementedError):
@@ -7035,7 +7032,6 @@ def test_a2c(self, device, gradient_mode, advantage, td_est, functional):
             value,
             loss_critic_type="l2",
             functional=functional,
-            reduction=reduction,
         )
 
         # Check error is raised when actions require grads

diff --git a/torchrl/objectives/dqn.py b/torchrl/objectives/dqn.py
@@ -27,7 +27,6 @@
 from torchrl.objectives.common import LossModule
 from torchrl.objectives.utils import (
     _GAMMA_LMBDA_DEPREC_ERROR,
-    _reduce,
     default_value_kwargs,
     distance_loss,
     ValueEstimators,