[BugFix] Fix lib tests (#2218)

pytorch · Jun 8, 2024 · c67ad59 · c67ad59
1 parent 1bd3814
commit c67ad59
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/test/test_libs.py b/test/test_libs.py
@@ -2812,14 +2812,14 @@ def _minari_selected_datasets():
     torch.manual_seed(0)
 
     keys = list(minari.list_remote_datasets())
-    indices = torch.randperm(len(keys))[:10]
+    indices = torch.randperm(len(keys))[:20]
     keys = [keys[idx] for idx in indices]
     keys = [
         key
         for key in keys
         if "=0.4" in minari.list_remote_datasets()[key]["minari_version"]
     ]
-    assert len(keys) > 5
+    assert len(keys) > 5, keys
     _MINARI_DATASETS += keys
 
 

diff --git a/torchrl/data/replay_buffers/samplers.py b/torchrl/data/replay_buffers/samplers.py
@@ -1696,7 +1696,7 @@ def _padded_indices(self, shapes, arange) -> torch.Tensor:
         return pad
 
     @implement_for("torch", None, "2.4")
-    def _padded_indices(self, shapes, arange) -> torch.Tensor:
+    def _padded_indices(self, shapes, arange) -> torch.Tensor:  # noqa: F811
         arange = arange.flip(0).split(shapes.flip(0).squeeze().unbind())
         return (
             torch.nn.utils.rnn.pad_sequence(arange, batch_first=True, padding_value=-1)

diff --git a/torchrl/data/replay_buffers/storages.py b/torchrl/data/replay_buffers/storages.py
@@ -49,7 +49,7 @@ class Storage:
 
     ndim = 1
     max_size: int
-    _default_checkpointer: StorageCheckpointerBase
+    _default_checkpointer: StorageCheckpointerBase = StorageCheckpointerBase
 
     def __init__(
         self, max_size: int, checkpointer: StorageCheckpointerBase | None = None