Skip to content

[BUG] check_env_specs shouldn't set torch.manual_seed by default. #1855

@maximilianigl

Description

@maximilianigl

Describe the bug

Current default behaviour of check_env_specs() is to set the manual key to 0.
I think this is dangerous as people might run this function after setting their own seed (at the beginning of main(), not realizing it's overwriting what they set before.

Reason and Possible fixes

Set default argument of seed in check_env_specs to None.

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have read the documentation (required)
  • I have provided a minimal working example to reproduce the bug (required)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions