Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] check_env_specs seeding logic #1872

Merged
merged 8 commits into from
Feb 5, 2024
Merged

[BugFix] check_env_specs seeding logic #1872

merged 8 commits into from
Feb 5, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 5, 2024 •
edited
Loading

Sets the default seed of check_env_specs to None (no seed) and set it only temporarily for Torch. For the env, we can't reset the RNG state unfortunately.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1872

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (25 Unrelated Failures)

As of commit b29cf5b with merge base 80fc87f (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2024
@vmoens vmoens added the enhancement New feature or request label Feb 5, 2024
@vmoens vmoens linked an issue Feb 5, 2024 that may be closed by this pull request
[BUG] check_env_specs shouldn't set torch.manual_seed by default. #1855
Closed
3 tasks
@vmoens vmoens added the bug Something isn't working label Feb 5, 2024
@vmoens vmoens changed the title [Feature] check_env_specs seeding logic [BugFix] check_env_specs seeding logic Feb 5, 2024
@vmoens vmoens mentioned this pull request Feb 5, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}11$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1345s 68.1011ms 14.6841 Ops/s 15.5444 Ops/s $\textbf{\color{#d91a1a}-5.53\%}$
test_sync 46.5927ms 36.2061ms 27.6197 Ops/s 27.0139 Ops/s $\color{#35bf28}+2.24\%$
test_async 73.7244ms 32.5983ms 30.6764 Ops/s 29.6856 Ops/s $\color{#35bf28}+3.34\%$
test_simple 0.5140s 0.4453s 2.2458 Ops/s 2.2524 Ops/s $\color{#d91a1a}-0.29\%$
test_transformed 0.6614s 0.6097s 1.6401 Ops/s 1.6157 Ops/s $\color{#35bf28}+1.51\%$
test_serial 1.4487s 1.3748s 0.7274 Ops/s 0.7232 Ops/s $\color{#35bf28}+0.58\%$
test_parallel 1.3309s 1.2680s 0.7886 Ops/s 0.8093 Ops/s $\color{#d91a1a}-2.56\%$
test_step_mdp_speed[True-True-True-True-True] 0.1708ms 21.4205μs 46.6842 KOps/s 47.2234 KOps/s $\color{#d91a1a}-1.14\%$
test_step_mdp_speed[True-True-True-True-False] 34.8950μs 12.8669μs 77.7190 KOps/s 77.5038 KOps/s $\color{#35bf28}+0.28\%$
test_step_mdp_speed[True-True-True-False-True] 39.3430μs 12.6363μs 79.1373 KOps/s 80.2623 KOps/s $\color{#d91a1a}-1.40\%$
test_step_mdp_speed[True-True-True-False-False] 32.3610μs 7.5929μs 131.7016 KOps/s 130.4448 KOps/s $\color{#35bf28}+0.96\%$
test_step_mdp_speed[True-True-False-True-True] 53.8600μs 22.8041μs 43.8518 KOps/s 44.0768 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[True-True-False-True-False] 0.1043ms 14.3383μs 69.7431 KOps/s 70.0333 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[True-True-False-False-True] 50.6140μs 13.6963μs 73.0126 KOps/s 73.5294 KOps/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[True-True-False-False-False] 31.5690μs 8.8270μs 113.2883 KOps/s 113.4938 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[True-False-True-True-True] 80.8900μs 23.9394μs 41.7721 KOps/s 41.7187 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[True-False-True-True-False] 0.1089ms 15.8427μs 63.1205 KOps/s 63.5695 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[True-False-True-False-True] 97.8820μs 13.9219μs 71.8294 KOps/s 73.4355 KOps/s $\color{#d91a1a}-2.19\%$
test_step_mdp_speed[True-False-True-False-False] 80.2290μs 8.8206μs 113.3704 KOps/s 113.9155 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-False-False-True-True] 64.0900μs 25.1260μs 39.7993 KOps/s 40.1100 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[True-False-False-True-False] 42.3790μs 16.7577μs 59.6742 KOps/s 60.3255 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[True-False-False-False-True] 40.7560μs 14.8701μs 67.2491 KOps/s 67.0313 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[True-False-False-False-False] 54.5820μs 9.9396μs 100.6077 KOps/s 100.9475 KOps/s $\color{#d91a1a}-0.34\%$
test_step_mdp_speed[False-True-True-True-True] 52.7680μs 24.0933μs 41.5053 KOps/s 42.2095 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[False-True-True-True-False] 43.0400μs 15.6518μs 63.8904 KOps/s 64.7013 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[False-True-True-False-True] 45.8850μs 15.9342μs 62.7579 KOps/s 62.9269 KOps/s $\color{#d91a1a}-0.27\%$
test_step_mdp_speed[False-True-True-False-False] 29.9950μs 9.8906μs 101.1058 KOps/s 100.1844 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[False-True-False-True-True] 59.6210μs 25.2544μs 39.5970 KOps/s 39.9202 KOps/s $\color{#d91a1a}-0.81\%$
test_step_mdp_speed[False-True-False-True-False] 0.1910ms 16.9060μs 59.1504 KOps/s 60.0918 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[False-True-False-False-True] 65.9220μs 16.8468μs 59.3583 KOps/s 59.0338 KOps/s $\color{#35bf28}+0.55\%$
test_step_mdp_speed[False-True-False-False-False] 46.5470μs 11.1734μs 89.4980 KOps/s 90.6974 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[False-False-True-True-True] 0.1019ms 26.0683μs 38.3608 KOps/s 38.1291 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[False-False-True-True-False] 46.6470μs 17.9431μs 55.7317 KOps/s 55.4633 KOps/s $\color{#35bf28}+0.48\%$
test_step_mdp_speed[False-False-True-False-True] 45.9060μs 16.9889μs 58.8621 KOps/s 59.1423 KOps/s $\color{#d91a1a}-0.47\%$
test_step_mdp_speed[False-False-True-False-False] 69.9200μs 11.1039μs 90.0586 KOps/s 89.3965 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-False-False-True-True] 63.1680μs 27.3779μs 36.5259 KOps/s 36.6616 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[False-False-False-True-False] 87.2920μs 18.9500μs 52.7704 KOps/s 53.0262 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[False-False-False-False-True] 66.0930μs 17.8274μs 56.0935 KOps/s 55.7551 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[False-False-False-False-False] 56.7150μs 12.2045μs 81.9373 KOps/s 81.8110 KOps/s $\color{#35bf28}+0.15\%$
test_values[generalized_advantage_estimate-True-True] 10.0712ms 9.7557ms 102.5041 Ops/s 106.0621 Ops/s $\color{#d91a1a}-3.35\%$
test_values[vec_generalized_advantage_estimate-True-True] 44.0658ms 36.8783ms 27.1162 Ops/s 29.3516 Ops/s $\textbf{\color{#d91a1a}-7.62\%}$
test_values[td0_return_estimate-False-False] 0.2263ms 0.1790ms 5.5875 KOps/s 5.6515 KOps/s $\color{#d91a1a}-1.13\%$
test_values[td1_return_estimate-False-False] 25.1833ms 23.9831ms 41.6961 Ops/s 43.1320 Ops/s $\color{#d91a1a}-3.33\%$
test_values[vec_td1_return_estimate-False-False] 38.4265ms 36.4687ms 27.4208 Ops/s 29.2477 Ops/s $\textbf{\color{#d91a1a}-6.25\%}$
test_values[td_lambda_return_estimate-True-False] 37.5628ms 34.6749ms 28.8393 Ops/s 29.8296 Ops/s $\color{#d91a1a}-3.32\%$
test_values[vec_td_lambda_return_estimate-True-False] 44.6759ms 37.0020ms 27.0256 Ops/s 29.3878 Ops/s $\textbf{\color{#d91a1a}-8.04\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.0852ms 8.4535ms 118.2939 Ops/s 124.6395 Ops/s $\textbf{\color{#d91a1a}-5.09\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.5243ms 1.8899ms 529.1346 Ops/s 504.6653 Ops/s $\color{#35bf28}+4.85\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5296ms 0.3480ms 2.8733 KOps/s 2.7885 KOps/s $\color{#35bf28}+3.04\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 49.1150ms 47.7643ms 20.9362 Ops/s 21.3031 Ops/s $\color{#d91a1a}-1.72\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7215ms 3.0228ms 330.8152 Ops/s 329.1699 Ops/s $\color{#35bf28}+0.50\%$
test_dqn_speed 80.1004ms 6.6244ms 150.9580 Ops/s 165.4916 Ops/s $\textbf{\color{#d91a1a}-8.78\%}$
test_ddpg_speed 14.1817ms 12.0557ms 82.9481 Ops/s 84.4783 Ops/s $\color{#d91a1a}-1.81\%$
test_sac_speed 25.0628ms 24.4239ms 40.9435 Ops/s 40.9525 Ops/s $\color{#d91a1a}-0.02\%$
test_redq_speed 0.1079s 15.6224ms 64.0108 Ops/s 69.5760 Ops/s $\textbf{\color{#d91a1a}-8.00\%}$
test_redq_deprec_speed 24.2614ms 22.0931ms 45.2630 Ops/s 42.4498 Ops/s $\textbf{\color{#35bf28}+6.63\%}$
test_td3_speed 27.7934ms 17.0827ms 58.5389 Ops/s 56.0966 Ops/s $\color{#35bf28}+4.35\%$
test_cql_speed 77.8341ms 75.7164ms 13.2072 Ops/s 12.9858 Ops/s $\color{#35bf28}+1.71\%$
test_a2c_speed 27.6281ms 22.7798ms 43.8985 Ops/s 42.3058 Ops/s $\color{#35bf28}+3.76\%$
test_ppo_speed 26.9712ms 22.7692ms 43.9189 Ops/s 42.5369 Ops/s $\color{#35bf28}+3.25\%$
test_reinforce_speed 31.6155ms 22.6849ms 44.0821 Ops/s 45.0019 Ops/s $\color{#d91a1a}-2.04\%$
test_iql_speed 59.8137ms 56.6501ms 17.6522 Ops/s 14.3632 Ops/s $\textbf{\color{#35bf28}+22.90\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.7760ms 2.5759ms 388.2150 Ops/s 340.7235 Ops/s $\textbf{\color{#35bf28}+13.94\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7818ms 0.5023ms 1.9909 KOps/s 1.9498 KOps/s $\color{#35bf28}+2.11\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7958ms 0.4763ms 2.0996 KOps/s 2.0165 KOps/s $\color{#35bf28}+4.12\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.4085ms 2.5963ms 385.1604 Ops/s 342.8705 Ops/s $\textbf{\color{#35bf28}+12.33\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8316ms 0.4997ms 2.0010 KOps/s 1.9834 KOps/s $\color{#35bf28}+0.89\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5895ms 0.4709ms 2.1236 KOps/s 2.0726 KOps/s $\color{#35bf28}+2.46\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3789ms 2.3680ms 422.2949 Ops/s 378.5830 Ops/s $\textbf{\color{#35bf28}+11.55\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8561ms 0.6182ms 1.6176 KOps/s 1.6125 KOps/s $\color{#35bf28}+0.32\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8874ms 0.5896ms 1.6960 KOps/s 1.6750 KOps/s $\color{#35bf28}+1.26\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.0043ms 2.5412ms 393.5206 Ops/s 357.8500 Ops/s $\textbf{\color{#35bf28}+9.97\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7780ms 0.5056ms 1.9779 KOps/s 1.9514 KOps/s $\color{#35bf28}+1.36\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5853ms 0.4761ms 2.1006 KOps/s 2.0363 KOps/s $\color{#35bf28}+3.15\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0466ms 2.5619ms 390.3310 Ops/s 339.6733 Ops/s $\textbf{\color{#35bf28}+14.91\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9485ms 0.5059ms 1.9769 KOps/s 1.9718 KOps/s $\color{#35bf28}+0.26\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9059ms 0.4736ms 2.1116 KOps/s 2.0814 KOps/s $\color{#35bf28}+1.45\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.7136ms 2.3393ms 427.4814 Ops/s 396.0185 Ops/s $\textbf{\color{#35bf28}+7.94\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8751ms 0.6227ms 1.6059 KOps/s 1.6112 KOps/s $\color{#d91a1a}-0.33\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7607ms 0.5950ms 1.6807 KOps/s 1.6886 KOps/s $\color{#d91a1a}-0.47\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2113s 8.3295ms 120.0545 Ops/s 81.9423 Ops/s $\textbf{\color{#35bf28}+46.51\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.1066ms 13.1636ms 75.9671 Ops/s 72.6457 Ops/s $\color{#35bf28}+4.57\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.9764ms 2.5636ms 390.0816 Ops/s 371.3953 Ops/s $\textbf{\color{#35bf28}+5.03\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1870s 7.7299ms 129.3670 Ops/s 118.8625 Ops/s $\textbf{\color{#35bf28}+8.84\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.4401ms 13.4840ms 74.1622 Ops/s 76.5128 Ops/s $\color{#d91a1a}-3.07\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 3.4306ms 2.4983ms 400.2735 Ops/s 395.3934 Ops/s $\color{#35bf28}+1.23\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1948s 8.1013ms 123.4373 Ops/s 118.7794 Ops/s $\color{#35bf28}+3.92\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.5363ms 13.3650ms 74.8223 Ops/s 75.2027 Ops/s $\color{#d91a1a}-0.51\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.5674ms 2.7415ms 364.7636 Ops/s 366.3883 Ops/s $\color{#d91a1a}-0.44\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1227s 0.1215s 8.2328 Ops/s 8.3262 Ops/s $\color{#d91a1a}-1.12\%$
test_sync 0.1376s 0.1367s 7.3139 Ops/s 7.3345 Ops/s $\color{#d91a1a}-0.28\%$
test_async 0.3398s 0.1302s 7.6783 Ops/s 7.6974 Ops/s $\color{#d91a1a}-0.25\%$
test_single_pixels 0.1437s 0.1431s 6.9864 Ops/s 7.0397 Ops/s $\color{#d91a1a}-0.76\%$
test_sync_pixels 0.1095s 0.1043s 9.5918 Ops/s 10.0318 Ops/s $\color{#d91a1a}-4.39\%$
test_async_pixels 0.2651s 94.8019ms 10.5483 Ops/s 10.5320 Ops/s $\color{#35bf28}+0.16\%$
test_simple 0.9469s 0.8761s 1.1414 Ops/s 1.1466 Ops/s $\color{#d91a1a}-0.45\%$
test_transformed 1.1997s 1.1318s 0.8835 Ops/s 0.8916 Ops/s $\color{#d91a1a}-0.90\%$
test_serial 2.5231s 2.4523s 0.4078 Ops/s 0.4207 Ops/s $\color{#d91a1a}-3.08\%$
test_parallel 3.3897s 3.1993s 0.3126 Ops/s 0.3148 Ops/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[True-True-True-True-True] 0.1108ms 32.9984μs 30.3045 KOps/s 30.1978 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[True-True-True-True-False] 50.8410μs 19.6955μs 50.7731 KOps/s 49.4371 KOps/s $\color{#35bf28}+2.70\%$
test_step_mdp_speed[True-True-True-False-True] 93.6510μs 18.6047μs 53.7498 KOps/s 55.3579 KOps/s $\color{#d91a1a}-2.90\%$
test_step_mdp_speed[True-True-True-False-False] 28.8010μs 11.1703μs 89.5232 KOps/s 89.6541 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[True-True-False-True-True] 75.0610μs 34.7393μs 28.7858 KOps/s 28.7921 KOps/s $\color{#d91a1a}-0.02\%$
test_step_mdp_speed[True-True-False-True-False] 40.7900μs 21.6517μs 46.1858 KOps/s 46.0864 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-True-False-False-True] 51.4210μs 20.5539μs 48.6527 KOps/s 49.7871 KOps/s $\color{#d91a1a}-2.28\%$
test_step_mdp_speed[True-True-False-False-False] 39.8810μs 13.0867μs 76.4134 KOps/s 78.0213 KOps/s $\color{#d91a1a}-2.06\%$
test_step_mdp_speed[True-False-True-True-True] 0.1100ms 36.1545μs 27.6590 KOps/s 27.9700 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[True-False-True-True-False] 53.5010μs 23.4466μs 42.6502 KOps/s 42.8027 KOps/s $\color{#d91a1a}-0.36\%$
test_step_mdp_speed[True-False-True-False-True] 50.0410μs 20.3068μs 49.2446 KOps/s 50.0001 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[True-False-True-False-False] 36.3900μs 12.9984μs 76.9323 KOps/s 77.7773 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[True-False-False-True-True] 68.3100μs 37.7196μs 26.5114 KOps/s 26.9937 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[True-False-False-True-False] 84.0710μs 25.2077μs 39.6704 KOps/s 40.3116 KOps/s $\color{#d91a1a}-1.59\%$
test_step_mdp_speed[True-False-False-False-True] 43.9710μs 22.1969μs 45.0514 KOps/s 45.8230 KOps/s $\color{#d91a1a}-1.68\%$
test_step_mdp_speed[True-False-False-False-False] 43.9810μs 14.9452μs 66.9110 KOps/s 67.2927 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[False-True-True-True-True] 73.2010μs 36.4868μs 27.4072 KOps/s 27.9721 KOps/s $\color{#d91a1a}-2.02\%$
test_step_mdp_speed[False-True-True-True-False] 40.5610μs 23.5758μs 42.4164 KOps/s 43.0847 KOps/s $\color{#d91a1a}-1.55\%$
test_step_mdp_speed[False-True-True-False-True] 91.8210μs 24.6014μs 40.6481 KOps/s 42.4037 KOps/s $\color{#d91a1a}-4.14\%$
test_step_mdp_speed[False-True-True-False-False] 37.4310μs 14.8800μs 67.2044 KOps/s 68.3524 KOps/s $\color{#d91a1a}-1.68\%$
test_step_mdp_speed[False-True-False-True-True] 63.8400μs 38.4637μs 25.9986 KOps/s 26.0840 KOps/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[False-True-False-True-False] 56.7110μs 25.4356μs 39.3150 KOps/s 39.1877 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[False-True-False-False-True] 58.0620μs 26.0444μs 38.3960 KOps/s 39.5498 KOps/s $\color{#d91a1a}-2.92\%$
test_step_mdp_speed[False-True-False-False-False] 45.5600μs 16.7523μs 59.6935 KOps/s 60.7750 KOps/s $\color{#d91a1a}-1.78\%$
test_step_mdp_speed[False-False-True-True-True] 0.1116ms 40.1808μs 24.8875 KOps/s 25.0629 KOps/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[False-False-True-True-False] 51.6210μs 27.2308μs 36.7231 KOps/s 37.2428 KOps/s $\color{#d91a1a}-1.40\%$
test_step_mdp_speed[False-False-True-False-True] 61.8210μs 26.1503μs 38.2405 KOps/s 39.3696 KOps/s $\color{#d91a1a}-2.87\%$
test_step_mdp_speed[False-False-True-False-False] 42.1100μs 16.7433μs 59.7254 KOps/s 60.4525 KOps/s $\color{#d91a1a}-1.20\%$
test_step_mdp_speed[False-False-False-True-True] 58.2500μs 42.0674μs 23.7714 KOps/s 24.6248 KOps/s $\color{#d91a1a}-3.47\%$
test_step_mdp_speed[False-False-False-True-False] 97.3810μs 28.9836μs 34.5022 KOps/s 34.3497 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[False-False-False-False-True] 50.2710μs 27.5210μs 36.3359 KOps/s 36.7242 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[False-False-False-False-False] 43.6110μs 18.3468μs 54.5054 KOps/s 54.4354 KOps/s $\color{#35bf28}+0.13\%$
test_values[generalized_advantage_estimate-True-True] 25.6630ms 25.0478ms 39.9237 Ops/s 40.0782 Ops/s $\color{#d91a1a}-0.39\%$
test_values[vec_generalized_advantage_estimate-True-True] 84.4503ms 3.2567ms 307.0638 Ops/s 306.1114 Ops/s $\color{#35bf28}+0.31\%$
test_values[td0_return_estimate-False-False] 89.1910μs 60.8235μs 16.4410 KOps/s 16.4886 KOps/s $\color{#d91a1a}-0.29\%$
test_values[td1_return_estimate-False-False] 54.0158ms 52.9849ms 18.8733 Ops/s 18.8370 Ops/s $\color{#35bf28}+0.19\%$
test_values[vec_td1_return_estimate-False-False] 2.1721ms 1.7585ms 568.6528 Ops/s 568.0528 Ops/s $\color{#35bf28}+0.11\%$
test_values[td_lambda_return_estimate-True-False] 84.1350ms 83.4566ms 11.9823 Ops/s 11.8840 Ops/s $\color{#35bf28}+0.83\%$
test_values[vec_td_lambda_return_estimate-True-False] 3.9849ms 1.8056ms 553.8329 Ops/s 555.3038 Ops/s $\color{#d91a1a}-0.26\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.0383ms 23.6878ms 42.2159 Ops/s 42.6527 Ops/s $\color{#d91a1a}-1.02\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8716ms 0.6943ms 1.4402 KOps/s 1.4031 KOps/s $\color{#35bf28}+2.65\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7121ms 0.6530ms 1.5314 KOps/s 1.5316 KOps/s $\color{#d91a1a}-0.02\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4957ms 1.4539ms 687.7842 Ops/s 688.2394 Ops/s $\color{#d91a1a}-0.07\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9840ms 0.6732ms 1.4854 KOps/s 1.4882 KOps/s $\color{#d91a1a}-0.19\%$
test_dqn_speed 8.7549ms 7.5980ms 131.6133 Ops/s 136.4155 Ops/s $\color{#d91a1a}-3.52\%$
test_ddpg_speed 15.9348ms 14.6345ms 68.3318 Ops/s 70.9680 Ops/s $\color{#d91a1a}-3.71\%$
test_sac_speed 31.1918ms 29.1904ms 34.2578 Ops/s 35.4456 Ops/s $\color{#d91a1a}-3.35\%$
test_redq_speed 13.2890ms 11.8595ms 84.3205 Ops/s 84.3599 Ops/s $\color{#d91a1a}-0.05\%$
test_redq_deprec_speed 0.1325s 25.5679ms 39.1115 Ops/s 43.7250 Ops/s $\textbf{\color{#d91a1a}-10.55\%}$
test_td3_speed 31.3425ms 19.7201ms 50.7097 Ops/s 51.9984 Ops/s $\color{#d91a1a}-2.48\%$
test_cql_speed 79.6615ms 77.8972ms 12.8374 Ops/s 13.2221 Ops/s $\color{#d91a1a}-2.91\%$
test_a2c_speed 27.1768ms 25.8706ms 38.6540 Ops/s 39.8588 Ops/s $\color{#d91a1a}-3.02\%$
test_ppo_speed 27.1898ms 26.1984ms 38.1703 Ops/s 39.6085 Ops/s $\color{#d91a1a}-3.63\%$
test_reinforce_speed 26.3122ms 24.9169ms 40.1333 Ops/s 35.5477 Ops/s $\textbf{\color{#35bf28}+12.90\%}$
test_iql_speed 52.6907ms 51.7294ms 19.3314 Ops/s 19.5599 Ops/s $\color{#d91a1a}-1.17\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.8368ms 3.6401ms 274.7195 Ops/s 274.9220 Ops/s $\color{#d91a1a}-0.07\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7204ms 0.5755ms 1.7376 KOps/s 1.7635 KOps/s $\color{#d91a1a}-1.47\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6750ms 0.5506ms 1.8162 KOps/s 1.8156 KOps/s $\color{#35bf28}+0.04\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9898ms 3.6992ms 270.3269 Ops/s 271.2955 Ops/s $\color{#d91a1a}-0.36\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7182ms 0.5741ms 1.7419 KOps/s 1.7670 KOps/s $\color{#d91a1a}-1.42\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6844ms 0.5503ms 1.8172 KOps/s 1.8341 KOps/s $\color{#d91a1a}-0.92\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.4412ms 3.3266ms 300.6039 Ops/s 302.3176 Ops/s $\color{#d91a1a}-0.57\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9160ms 0.7144ms 1.3997 KOps/s 1.4505 KOps/s $\color{#d91a1a}-3.50\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8556ms 0.6814ms 1.4675 KOps/s 1.4970 KOps/s $\color{#d91a1a}-1.97\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.8749ms 3.6742ms 272.1676 Ops/s 279.0841 Ops/s $\color{#d91a1a}-2.48\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7437ms 0.5813ms 1.7201 KOps/s 1.7487 KOps/s $\color{#d91a1a}-1.63\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6948ms 0.5548ms 1.8024 KOps/s 1.8242 KOps/s $\color{#d91a1a}-1.20\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9294ms 3.6881ms 271.1458 Ops/s 271.1332 Ops/s $+0.00\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7518ms 0.5884ms 1.6996 KOps/s 1.7714 KOps/s $\color{#d91a1a}-4.06\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7355ms 0.5529ms 1.8086 KOps/s 1.8491 KOps/s $\color{#d91a1a}-2.19\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.5192ms 3.3659ms 297.0952 Ops/s 305.6900 Ops/s $\color{#d91a1a}-2.81\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8499ms 0.7032ms 1.4222 KOps/s 1.4320 KOps/s $\color{#d91a1a}-0.69\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8124ms 0.6806ms 1.4692 KOps/s 1.4681 KOps/s $\color{#35bf28}+0.08\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2219s 9.8685ms 101.3324 Ops/s 100.6146 Ops/s $\color{#35bf28}+0.71\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.8529ms 16.5477ms 60.4315 Ops/s 60.8440 Ops/s $\color{#d91a1a}-0.68\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 8.3213ms 3.1660ms 315.8544 Ops/s 324.5103 Ops/s $\color{#d91a1a}-2.67\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.2207s 9.8834ms 101.1796 Ops/s 100.9319 Ops/s $\color{#35bf28}+0.25\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 19.6687ms 16.5868ms 60.2889 Ops/s 61.0335 Ops/s $\color{#d91a1a}-1.22\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.0048ms 3.1130ms 321.2290 Ops/s 322.7269 Ops/s $\color{#d91a1a}-0.46\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.2180s 14.1301ms 70.7708 Ops/s 99.4891 Ops/s $\textbf{\color{#d91a1a}-28.87\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.3925ms 16.9242ms 59.0870 Ops/s 60.4412 Ops/s $\color{#d91a1a}-2.24\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.7924ms 3.3274ms 300.5330 Ops/s 299.6576 Ops/s $\color{#35bf28}+0.29\%$

@vmoens vmoens merged commit 528faa1 into main Feb 5, 2024
24 of 35 checks passed
@vmoens vmoens deleted the seed-check_env_specs branch February 5, 2024 20:53
vmoens added a commit that referenced this pull request Feb 6, 2024
@vmoens
[BugFix] check_env_specs seeding logic (#1872)
518b92c
@vmoens vmoens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] check_env_specs shouldn't set torch.manual_seed by default.
2 participants
@vmoens @facebook-github-bot