Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Logger #1858

Merged
merged 49 commits into from
Jan 31, 2024
Merged

[Feature] Logger #1858

merged 49 commits into from
Jan 31, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 31, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 31, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1858

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (26 Unrelated Failures)

As of commit 4b746f6 with merge base b5e90c4 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2024
@vmoens vmoens added the enhancement New feature or request label Jan 31, 2024
vmoens and others added 3 commits January 31, 2024 17:45
@vmoens
amend
f984105
@vmoens
amend
deb8b2e
@vmoens
Merge remote-tracking branch 'origin/remove-deprecs' into logger
d0efa38 
# Conflicts:
#	examples/ddpg/config.yaml
#	examples/discrete_sac/config.yaml
#	examples/rlhf/train_rlhf.py
#	examples/sac/config.yaml
#	examples/td3/config.yaml
#	test/test_distributed.py
#	torchrl/objectives/a2c.py
#	torchrl/objectives/ppo.py
#	torchrl/objectives/reinforce.py
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1327s 66.8989ms 14.9479 Ops/s 15.8639 Ops/s $\textbf{\color{#d91a1a}-5.77\%}$
test_sync 39.4665ms 33.4043ms 29.9363 Ops/s 28.8701 Ops/s $\color{#35bf28}+3.69\%$
test_async 88.7302ms 34.3309ms 29.1283 Ops/s 30.1613 Ops/s $\color{#d91a1a}-3.43\%$
test_simple 0.4200s 0.4181s 2.3919 Ops/s 2.2968 Ops/s $\color{#35bf28}+4.14\%$
test_transformed 0.6673s 0.6016s 1.6623 Ops/s 1.6482 Ops/s $\color{#35bf28}+0.86\%$
test_serial 1.4265s 1.3723s 0.7287 Ops/s 0.7247 Ops/s $\color{#35bf28}+0.56\%$
test_parallel 1.2627s 1.1999s 0.8334 Ops/s 0.8256 Ops/s $\color{#35bf28}+0.95\%$
test_step_mdp_speed[True-True-True-True-True] 0.1149ms 21.7121μs 46.0573 KOps/s 46.5053 KOps/s $\color{#d91a1a}-0.96\%$
test_step_mdp_speed[True-True-True-True-False] 43.9930μs 13.2361μs 75.5512 KOps/s 77.0024 KOps/s $\color{#d91a1a}-1.88\%$
test_step_mdp_speed[True-True-True-False-True] 35.5470μs 12.7846μs 78.2191 KOps/s 79.6452 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[True-True-True-False-False] 29.4350μs 7.7462μs 129.0949 KOps/s 131.7168 KOps/s $\color{#d91a1a}-1.99\%$
test_step_mdp_speed[True-True-False-True-True] 61.1540μs 22.9908μs 43.4956 KOps/s 43.7812 KOps/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[True-True-False-True-False] 38.4220μs 14.6685μs 68.1731 KOps/s 69.9216 KOps/s $\color{#d91a1a}-2.50\%$
test_step_mdp_speed[True-True-False-False-True] 39.3540μs 14.0967μs 70.9387 KOps/s 72.0789 KOps/s $\color{#d91a1a}-1.58\%$
test_step_mdp_speed[True-True-False-False-False] 33.6430μs 9.1642μs 109.1200 KOps/s 112.7077 KOps/s $\color{#d91a1a}-3.18\%$
test_step_mdp_speed[True-False-True-True-True] 47.6090μs 24.3570μs 41.0559 KOps/s 41.3211 KOps/s $\color{#d91a1a}-0.64\%$
test_step_mdp_speed[True-False-True-True-False] 49.5030μs 15.9888μs 62.5436 KOps/s 64.6450 KOps/s $\color{#d91a1a}-3.25\%$
test_step_mdp_speed[True-False-True-False-True] 46.6270μs 14.0720μs 71.0629 KOps/s 72.8250 KOps/s $\color{#d91a1a}-2.42\%$
test_step_mdp_speed[True-False-True-False-False] 32.2810μs 9.1158μs 109.6998 KOps/s 112.7862 KOps/s $\color{#d91a1a}-2.74\%$
test_step_mdp_speed[True-False-False-True-True] 68.8890μs 25.4642μs 39.2709 KOps/s 39.7804 KOps/s $\color{#d91a1a}-1.28\%$
test_step_mdp_speed[True-False-False-True-False] 43.0400μs 17.2397μs 58.0057 KOps/s 59.0933 KOps/s $\color{#d91a1a}-1.84\%$
test_step_mdp_speed[True-False-False-False-True] 43.1010μs 15.2756μs 65.4641 KOps/s 66.9368 KOps/s $\color{#d91a1a}-2.20\%$
test_step_mdp_speed[True-False-False-False-False] 33.7230μs 10.3365μs 96.7449 KOps/s 98.7017 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[False-True-True-True-True] 66.4650μs 24.5811μs 40.6817 KOps/s 40.9776 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[False-True-True-True-False] 46.3670μs 16.1712μs 61.8382 KOps/s 63.4144 KOps/s $\color{#d91a1a}-2.49\%$
test_step_mdp_speed[False-True-True-False-True] 41.6480μs 16.3775μs 61.0594 KOps/s 62.4435 KOps/s $\color{#d91a1a}-2.22\%$
test_step_mdp_speed[False-True-True-False-False] 28.8250μs 10.4246μs 95.9265 KOps/s 98.6354 KOps/s $\color{#d91a1a}-2.75\%$
test_step_mdp_speed[False-True-False-True-True] 53.0900μs 25.6071μs 39.0516 KOps/s 39.7002 KOps/s $\color{#d91a1a}-1.63\%$
test_step_mdp_speed[False-True-False-True-False] 63.6490μs 17.1387μs 58.3474 KOps/s 59.8558 KOps/s $\color{#d91a1a}-2.52\%$
test_step_mdp_speed[False-True-False-False-True] 47.1380μs 17.4928μs 57.1665 KOps/s 58.2706 KOps/s $\color{#d91a1a}-1.89\%$
test_step_mdp_speed[False-True-False-False-False] 32.5910μs 11.4294μs 87.4937 KOps/s 89.2840 KOps/s $\color{#d91a1a}-2.01\%$
test_step_mdp_speed[False-False-True-True-True] 54.5020μs 26.8397μs 37.2582 KOps/s 37.6693 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[False-False-True-True-False] 47.8490μs 18.3886μs 54.3814 KOps/s 55.2475 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[False-False-True-False-True] 39.3740μs 17.4542μs 57.2926 KOps/s 58.6182 KOps/s $\color{#d91a1a}-2.26\%$
test_step_mdp_speed[False-False-True-False-False] 32.3810μs 11.6286μs 85.9946 KOps/s 89.9536 KOps/s $\color{#d91a1a}-4.40\%$
test_step_mdp_speed[False-False-False-True-True] 67.0450μs 28.1388μs 35.5381 KOps/s 36.3732 KOps/s $\color{#d91a1a}-2.30\%$
test_step_mdp_speed[False-False-False-True-False] 50.0240μs 19.5070μs 51.2636 KOps/s 52.5868 KOps/s $\color{#d91a1a}-2.52\%$
test_step_mdp_speed[False-False-False-False-True] 58.5430μs 18.2304μs 54.8535 KOps/s 55.5133 KOps/s $\color{#d91a1a}-1.19\%$
test_step_mdp_speed[False-False-False-False-False] 36.8290μs 12.6057μs 79.3291 KOps/s 82.3207 KOps/s $\color{#d91a1a}-3.63\%$
test_values[generalized_advantage_estimate-True-True] 9.8823ms 9.3499ms 106.9534 Ops/s 104.9133 Ops/s $\color{#35bf28}+1.94\%$
test_values[vec_generalized_advantage_estimate-True-True] 39.6125ms 34.2006ms 29.2393 Ops/s 28.2755 Ops/s $\color{#35bf28}+3.41\%$
test_values[td0_return_estimate-False-False] 0.2629ms 0.1653ms 6.0508 KOps/s 6.0350 KOps/s $\color{#35bf28}+0.26\%$
test_values[td1_return_estimate-False-False] 26.4594ms 23.2408ms 43.0277 Ops/s 41.6812 Ops/s $\color{#35bf28}+3.23\%$
test_values[vec_td1_return_estimate-False-False] 36.6873ms 34.4684ms 29.0121 Ops/s 28.1058 Ops/s $\color{#35bf28}+3.22\%$
test_values[td_lambda_return_estimate-True-False] 36.4502ms 33.3233ms 30.0091 Ops/s 29.2460 Ops/s $\color{#35bf28}+2.61\%$
test_values[vec_td_lambda_return_estimate-True-False] 40.9819ms 34.6874ms 28.8289 Ops/s 27.9768 Ops/s $\color{#35bf28}+3.05\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.1722ms 8.0921ms 123.5772 Ops/s 120.0633 Ops/s $\color{#35bf28}+2.93\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.9507ms 1.8753ms 533.2528 Ops/s 505.9003 Ops/s $\textbf{\color{#35bf28}+5.41\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4308ms 0.3509ms 2.8499 KOps/s 2.7856 KOps/s $\color{#35bf28}+2.31\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 46.8951ms 42.4179ms 23.5750 Ops/s 20.9876 Ops/s $\textbf{\color{#35bf28}+12.33\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7388ms 3.0155ms 331.6246 Ops/s 330.9914 Ops/s $\color{#35bf28}+0.19\%$
test_dqn_speed 12.2813ms 5.8771ms 170.1521 Ops/s 170.7384 Ops/s $\color{#d91a1a}-0.34\%$
test_ddpg_speed 87.0565ms 12.3580ms 80.9190 Ops/s 87.7475 Ops/s $\textbf{\color{#d91a1a}-7.78\%}$
test_sac_speed 24.5770ms 23.2913ms 42.9345 Ops/s 42.8993 Ops/s $\color{#35bf28}+0.08\%$
test_redq_speed 15.1364ms 13.8399ms 72.2549 Ops/s 70.8498 Ops/s $\color{#35bf28}+1.98\%$
test_redq_deprec_speed 22.4279ms 21.3866ms 46.7584 Ops/s 45.8305 Ops/s $\color{#35bf28}+2.02\%$
test_td3_speed 25.1252ms 16.2446ms 61.5588 Ops/s 60.9818 Ops/s $\color{#35bf28}+0.95\%$
test_cql_speed 74.7898ms 72.5669ms 13.7804 Ops/s 13.6038 Ops/s $\color{#35bf28}+1.30\%$
test_a2c_speed 22.5053ms 21.6533ms 46.1823 Ops/s 46.1294 Ops/s $\color{#35bf28}+0.11\%$
test_ppo_speed 24.4287ms 21.9207ms 45.6189 Ops/s 45.4634 Ops/s $\color{#35bf28}+0.34\%$
test_reinforce_speed 21.8074ms 20.8401ms 47.9844 Ops/s 47.7542 Ops/s $\color{#35bf28}+0.48\%$
test_iql_speed 57.0379ms 55.0132ms 18.1775 Ops/s 18.1175 Ops/s $\color{#35bf28}+0.33\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.8334ms 2.5884ms 386.3383 Ops/s 376.5442 Ops/s $\color{#35bf28}+2.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8086ms 0.5044ms 1.9824 KOps/s 1.9702 KOps/s $\color{#35bf28}+0.62\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7323ms 0.4773ms 2.0950 KOps/s 2.0742 KOps/s $\color{#35bf28}+1.00\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9912ms 2.6551ms 376.6336 Ops/s 378.8960 Ops/s $\color{#d91a1a}-0.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9015ms 0.5002ms 1.9991 KOps/s 1.9676 KOps/s $\color{#35bf28}+1.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5911ms 0.4680ms 2.1365 KOps/s 2.0904 KOps/s $\color{#35bf28}+2.21\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6553ms 2.3982ms 416.9858 Ops/s 412.9991 Ops/s $\color{#35bf28}+0.97\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9552ms 0.6141ms 1.6284 KOps/s 1.6012 KOps/s $\color{#35bf28}+1.70\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8638ms 0.5889ms 1.6980 KOps/s 1.6763 KOps/s $\color{#35bf28}+1.29\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.0216ms 2.6665ms 375.0300 Ops/s 381.3073 Ops/s $\color{#d91a1a}-1.65\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8941ms 0.5096ms 1.9624 KOps/s 1.9474 KOps/s $\color{#35bf28}+0.77\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6969ms 0.4786ms 2.0894 KOps/s 2.0800 KOps/s $\color{#35bf28}+0.45\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.0342ms 2.6074ms 383.5201 Ops/s 380.5671 Ops/s $\color{#35bf28}+0.78\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7344ms 0.5027ms 1.9892 KOps/s 1.9786 KOps/s $\color{#35bf28}+0.53\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5962ms 0.4703ms 2.1262 KOps/s 2.1078 KOps/s $\color{#35bf28}+0.87\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6634ms 2.4103ms 414.8828 Ops/s 416.2956 Ops/s $\color{#d91a1a}-0.34\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8921ms 0.6183ms 1.6172 KOps/s 1.5907 KOps/s $\color{#35bf28}+1.67\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7015ms 0.5860ms 1.7065 KOps/s 1.6813 KOps/s $\color{#35bf28}+1.50\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1028s 8.0478ms 124.2580 Ops/s 126.5480 Ops/s $\color{#d91a1a}-1.81\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.7762ms 13.1515ms 76.0372 Ops/s 73.8149 Ops/s $\color{#35bf28}+3.01\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.6851ms 2.5220ms 396.5049 Ops/s 391.0966 Ops/s $\color{#35bf28}+1.38\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 97.2040ms 9.5794ms 104.3912 Ops/s 101.4177 Ops/s $\color{#35bf28}+2.93\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.5053ms 13.1545ms 76.0197 Ops/s 64.2411 Ops/s $\textbf{\color{#35bf28}+18.33\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.1370ms 2.5260ms 395.8789 Ops/s 393.9960 Ops/s $\color{#35bf28}+0.48\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 93.5598ms 7.9050ms 126.5027 Ops/s 123.6643 Ops/s $\color{#35bf28}+2.30\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.4731ms 13.3520ms 74.8950 Ops/s 72.5518 Ops/s $\color{#35bf28}+3.23\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 3.6740ms 2.6611ms 375.7899 Ops/s 365.9286 Ops/s $\color{#35bf28}+2.69\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1198s 0.1193s 8.3806 Ops/s 8.4017 Ops/s $\color{#d91a1a}-0.25\%$
test_sync 0.1392s 0.1362s 7.3438 Ops/s 7.2020 Ops/s $\color{#35bf28}+1.97\%$
test_async 0.2676s 0.1337s 7.4788 Ops/s 7.4718 Ops/s $\color{#35bf28}+0.09\%$
test_single_pixels 0.1358s 0.1353s 7.3929 Ops/s 6.9090 Ops/s $\textbf{\color{#35bf28}+7.00\%}$
test_sync_pixels 0.1069s 0.1043s 9.5879 Ops/s 9.9442 Ops/s $\color{#d91a1a}-3.58\%$
test_async_pixels 0.2602s 94.8732ms 10.5404 Ops/s 10.3699 Ops/s $\color{#35bf28}+1.64\%$
test_simple 0.9491s 0.8721s 1.1466 Ops/s 1.1612 Ops/s $\color{#d91a1a}-1.25\%$
test_transformed 1.1854s 1.1204s 0.8926 Ops/s 0.9122 Ops/s $\color{#d91a1a}-2.15\%$
test_serial 2.4642s 2.3984s 0.4170 Ops/s 0.4163 Ops/s $\color{#35bf28}+0.15\%$
test_parallel 3.2261s 3.1644s 0.3160 Ops/s 0.3122 Ops/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[True-True-True-True-True] 0.1202ms 32.3357μs 30.9256 KOps/s 31.1315 KOps/s $\color{#d91a1a}-0.66\%$
test_step_mdp_speed[True-True-True-True-False] 36.0820μs 19.5644μs 51.1134 KOps/s 51.6763 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[True-True-True-False-True] 34.6810μs 18.2009μs 54.9423 KOps/s 55.4152 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[True-True-True-False-False] 24.9610μs 11.2795μs 88.6563 KOps/s 90.7572 KOps/s $\color{#d91a1a}-2.31\%$
test_step_mdp_speed[True-True-False-True-True] 59.1020μs 34.7392μs 28.7859 KOps/s 29.8549 KOps/s $\color{#d91a1a}-3.58\%$
test_step_mdp_speed[True-True-False-True-False] 36.7920μs 21.4292μs 46.6652 KOps/s 47.2865 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[True-True-False-False-True] 0.1987ms 20.1858μs 49.5398 KOps/s 49.8231 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[True-True-False-False-False] 33.1920μs 13.0697μs 76.5129 KOps/s 77.4821 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[True-False-True-True-True] 54.4320μs 36.4420μs 27.4408 KOps/s 28.4673 KOps/s $\color{#d91a1a}-3.61\%$
test_step_mdp_speed[True-False-True-True-False] 47.9020μs 23.7144μs 42.1686 KOps/s 44.0855 KOps/s $\color{#d91a1a}-4.35\%$
test_step_mdp_speed[True-False-True-False-True] 52.5620μs 20.3210μs 49.2103 KOps/s 50.0071 KOps/s $\color{#d91a1a}-1.59\%$
test_step_mdp_speed[True-False-True-False-False] 38.1910μs 13.0613μs 76.5620 KOps/s 77.8606 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[True-False-False-True-True] 56.1720μs 38.6235μs 25.8910 KOps/s 27.3173 KOps/s $\textbf{\color{#d91a1a}-5.22\%}$
test_step_mdp_speed[True-False-False-True-False] 47.3920μs 25.4248μs 39.3316 KOps/s 40.3015 KOps/s $\color{#d91a1a}-2.41\%$
test_step_mdp_speed[True-False-False-False-True] 42.7720μs 22.1221μs 45.2037 KOps/s 46.1619 KOps/s $\color{#d91a1a}-2.08\%$
test_step_mdp_speed[True-False-False-False-False] 39.1320μs 14.9140μs 67.0511 KOps/s 69.0025 KOps/s $\color{#d91a1a}-2.83\%$
test_step_mdp_speed[False-True-True-True-True] 60.7730μs 36.7751μs 27.1923 KOps/s 28.4938 KOps/s $\color{#d91a1a}-4.57\%$
test_step_mdp_speed[False-True-True-True-False] 44.0120μs 23.5723μs 42.4226 KOps/s 43.8102 KOps/s $\color{#d91a1a}-3.17\%$
test_step_mdp_speed[False-True-True-False-True] 41.1820μs 24.5640μs 40.7100 KOps/s 41.1386 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[False-True-True-False-False] 34.9320μs 14.9940μs 66.6932 KOps/s 67.8800 KOps/s $\color{#d91a1a}-1.75\%$
test_step_mdp_speed[False-True-False-True-True] 79.3740μs 38.5803μs 25.9200 KOps/s 26.8226 KOps/s $\color{#d91a1a}-3.37\%$
test_step_mdp_speed[False-True-False-True-False] 52.2520μs 25.3887μs 39.3876 KOps/s 39.8585 KOps/s $\color{#d91a1a}-1.18\%$
test_step_mdp_speed[False-True-False-False-True] 48.0220μs 26.1140μs 38.2936 KOps/s 39.4808 KOps/s $\color{#d91a1a}-3.01\%$
test_step_mdp_speed[False-True-False-False-False] 36.2920μs 16.7778μs 59.6027 KOps/s 61.5904 KOps/s $\color{#d91a1a}-3.23\%$
test_step_mdp_speed[False-False-True-True-True] 61.0230μs 40.2195μs 24.8635 KOps/s 25.7102 KOps/s $\color{#d91a1a}-3.29\%$
test_step_mdp_speed[False-False-True-True-False] 43.8820μs 27.5330μs 36.3200 KOps/s 37.4439 KOps/s $\color{#d91a1a}-3.00\%$
test_step_mdp_speed[False-False-True-False-True] 51.5920μs 26.2760μs 38.0575 KOps/s 39.4612 KOps/s $\color{#d91a1a}-3.56\%$
test_step_mdp_speed[False-False-True-False-False] 32.1310μs 16.7738μs 59.6168 KOps/s 59.9064 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[False-False-False-True-True] 64.3730μs 41.7814μs 23.9341 KOps/s 24.4210 KOps/s $\color{#d91a1a}-1.99\%$
test_step_mdp_speed[False-False-False-True-False] 44.1420μs 29.3557μs 34.0649 KOps/s 35.1957 KOps/s $\color{#d91a1a}-3.21\%$
test_step_mdp_speed[False-False-False-False-True] 47.6420μs 27.6286μs 36.1944 KOps/s 37.1912 KOps/s $\color{#d91a1a}-2.68\%$
test_step_mdp_speed[False-False-False-False-False] 0.1308ms 18.6339μs 53.6655 KOps/s 56.0241 KOps/s $\color{#d91a1a}-4.21\%$
test_values[generalized_advantage_estimate-True-True] 26.0714ms 25.1726ms 39.7257 Ops/s 38.5569 Ops/s $\color{#35bf28}+3.03\%$
test_values[vec_generalized_advantage_estimate-True-True] 84.8944ms 3.2638ms 306.3959 Ops/s 291.7391 Ops/s $\textbf{\color{#35bf28}+5.02\%}$
test_values[td0_return_estimate-False-False] 98.7540μs 61.9025μs 16.1544 KOps/s 15.8241 KOps/s $\color{#35bf28}+2.09\%$
test_values[td1_return_estimate-False-False] 54.9157ms 54.1036ms 18.4831 Ops/s 18.0833 Ops/s $\color{#35bf28}+2.21\%$
test_values[vec_td1_return_estimate-False-False] 1.9798ms 1.7650ms 566.5732 Ops/s 560.7737 Ops/s $\color{#35bf28}+1.03\%$
test_values[td_lambda_return_estimate-True-False] 86.2558ms 85.6283ms 11.6784 Ops/s 11.3821 Ops/s $\color{#35bf28}+2.60\%$
test_values[vec_td_lambda_return_estimate-True-False] 4.0198ms 1.8053ms 553.9372 Ops/s 551.4512 Ops/s $\color{#35bf28}+0.45\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.4211ms 24.1220ms 41.4559 Ops/s 41.3079 Ops/s $\color{#35bf28}+0.36\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9209ms 0.7108ms 1.4069 KOps/s 1.4108 KOps/s $\color{#d91a1a}-0.28\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7250ms 0.6543ms 1.5285 KOps/s 1.5094 KOps/s $\color{#35bf28}+1.27\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.6325ms 1.4593ms 685.2681 Ops/s 687.1990 Ops/s $\color{#d91a1a}-0.28\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9708ms 0.6732ms 1.4854 KOps/s 1.5159 KOps/s $\color{#d91a1a}-2.01\%$
test_dqn_speed 7.5304ms 6.9799ms 143.2686 Ops/s 136.2791 Ops/s $\textbf{\color{#35bf28}+5.13\%}$
test_ddpg_speed 0.1038s 14.9098ms 67.0699 Ops/s 71.4522 Ops/s $\textbf{\color{#d91a1a}-6.13\%}$
test_sac_speed 28.1617ms 26.9222ms 37.1441 Ops/s 32.4625 Ops/s $\textbf{\color{#35bf28}+14.42\%}$
test_redq_speed 12.9561ms 11.7372ms 85.1989 Ops/s 86.4663 Ops/s $\color{#d91a1a}-1.47\%$
test_redq_deprec_speed 24.8679ms 22.1676ms 45.1109 Ops/s 44.8604 Ops/s $\color{#35bf28}+0.56\%$
test_td3_speed 28.7668ms 18.1657ms 55.0488 Ops/s 53.0193 Ops/s $\color{#35bf28}+3.83\%$
test_cql_speed 74.0490ms 72.9834ms 13.7018 Ops/s 13.4487 Ops/s $\color{#35bf28}+1.88\%$
test_a2c_speed 24.9141ms 23.9834ms 41.6956 Ops/s 40.8078 Ops/s $\color{#35bf28}+2.18\%$
test_ppo_speed 25.6178ms 24.4747ms 40.8586 Ops/s 40.0368 Ops/s $\color{#35bf28}+2.05\%$
test_reinforce_speed 24.3587ms 23.1719ms 43.1557 Ops/s 41.5478 Ops/s $\color{#35bf28}+3.87\%$
test_iql_speed 50.3674ms 49.1521ms 20.3450 Ops/s 20.0071 Ops/s $\color{#35bf28}+1.69\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.8262ms 3.6437ms 274.4453 Ops/s 275.7038 Ops/s $\color{#d91a1a}-0.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7541ms 0.5621ms 1.7790 KOps/s 1.7619 KOps/s $\color{#35bf28}+0.97\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7825ms 0.5336ms 1.8739 KOps/s 1.8500 KOps/s $\color{#35bf28}+1.29\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9989ms 3.6764ms 272.0062 Ops/s 275.5886 Ops/s $\color{#d91a1a}-1.30\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7080ms 0.5513ms 1.8139 KOps/s 1.7742 KOps/s $\color{#35bf28}+2.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6824ms 0.5287ms 1.8913 KOps/s 1.8644 KOps/s $\color{#35bf28}+1.44\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.5428ms 3.3358ms 299.7797 Ops/s 304.6625 Ops/s $\color{#d91a1a}-1.60\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9155ms 0.6876ms 1.4544 KOps/s 1.4529 KOps/s $\color{#35bf28}+0.10\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8306ms 0.6606ms 1.5138 KOps/s 1.5105 KOps/s $\color{#35bf28}+0.22\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.9624ms 3.7130ms 269.3221 Ops/s 278.9124 Ops/s $\color{#d91a1a}-3.44\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7135ms 0.5647ms 1.7708 KOps/s 1.7618 KOps/s $\color{#35bf28}+0.51\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7960ms 0.5364ms 1.8642 KOps/s 1.8448 KOps/s $\color{#35bf28}+1.05\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.0065ms 3.7062ms 269.8217 Ops/s 276.4132 Ops/s $\color{#d91a1a}-2.38\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8566ms 0.5609ms 1.7830 KOps/s 1.8033 KOps/s $\color{#d91a1a}-1.12\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8586ms 0.5337ms 1.8737 KOps/s 1.8748 KOps/s $\color{#d91a1a}-0.06\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.6007ms 3.3872ms 295.2333 Ops/s 300.8167 Ops/s $\color{#d91a1a}-1.86\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8963ms 0.6879ms 1.4538 KOps/s 1.4542 KOps/s $\color{#d91a1a}-0.03\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8476ms 0.6620ms 1.5105 KOps/s 1.5028 KOps/s $\color{#35bf28}+0.51\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1265s 10.4530ms 95.6663 Ops/s 97.3399 Ops/s $\color{#d91a1a}-1.72\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1353s 18.7052ms 53.4611 Ops/s 62.4798 Ops/s $\textbf{\color{#d91a1a}-14.43\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 5.8842ms 3.1736ms 315.0990 Ops/s 324.3048 Ops/s $\color{#d91a1a}-2.84\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1234s 10.2624ms 97.4431 Ops/s 80.2433 Ops/s $\textbf{\color{#35bf28}+21.43\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 19.0882ms 16.3894ms 61.0150 Ops/s 62.6003 Ops/s $\color{#d91a1a}-2.53\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.4567ms 3.1573ms 316.7226 Ops/s 322.7108 Ops/s $\color{#d91a1a}-1.86\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1281s 10.6327ms 94.0496 Ops/s 96.4499 Ops/s $\color{#d91a1a}-2.49\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.0135ms 16.5989ms 60.2450 Ops/s 61.8873 Ops/s $\color{#d91a1a}-2.65\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.3017ms 3.3413ms 299.2832 Ops/s 299.6426 Ops/s $\color{#d91a1a}-0.12\%$

@vmoens vmoens added Environments Adds or modifies an environment wrapper Data Data-related PR, will launch data-related jobs labels Jan 31, 2024
@vmoens vmoens merged commit d930f5c into main Jan 31, 2024
36 of 62 checks passed
@vmoens vmoens deleted the logger branch January 31, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Data Data-related PR, will launch data-related jobs enhancement New feature or request Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot