Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix update in serial / parallel env #1866

Merged
merged 35 commits into from
Feb 5, 2024

lint

b97781b
Select commit
Loading
Failed to load commit list.
Merged

[BugFix] Fix update in serial / parallel env #1866

lint
b97781b
Select commit
Loading
Failed to load commit list.
PyTorch Bot / Dr.CI completed Feb 6, 2024 in 0s

Dr.CI classification results

{"FAILED":[],"FLAKY":[{"workflowId":7790379973,"id":21244110770,"runnerName":"i-03b797dbab1f3af24","authorEmail":"[email protected]","name":"Examples Tests on Linux / tests (3.9, 12.1) / linux-job","jobName":"tests (3.9, 12.1) / linux-job","conclusion":"failure","completed_at":"2024-02-05T20:37:08Z","html_url":"https://github.com/pytorch/rl/actions/runs/7790379973/job/21244110770","head_branch":"fix-stepcount","pr_number":1866,"head_sha":"b97781b1e3d61c0d9beab0669d3a8b9fee9a6a0a","failure_captures":["RuntimeError: Command docker exec -t 7b4a3ee03d2eef0a1318d50df9a1ec05520fe31b95b4bb916c0803f46d838c94 /exec failed with exit code 252"],"failure_lines":["RuntimeError: Command docker exec -t 7b4a3ee03d2eef0a1318d50df9a1ec05520fe31b95b4bb916c0803f46d838c94 /exec failed with exit code 252"],"failure_context":["+ bash /pytorch/rl/.github/unittest/linux_examples/scripts/run_test.sh","+ python setup.py develop","+ printf '* Installing torchrl\n'","+ pip install git+https://github.com/pytorch/tensordict.git","+ pip install git+https://github.com/pytorch/torchsnapshot","+ python -c 'import functorch'","+ pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu121","+ printf 'Installing PyTorch with %s\n' cu121","+ git submodule update --init --recursive","+ git submodule sync","+ version=12.1","++ python -c 'print('\''.'\''.join("12.1".split('\''.'\'')[:2]))'"],"time":"2024-02-05T20:37:17.597580Z"},{"workflowId":7790379972,"id":21244110231,"runnerName":"i-01b5b0e74a5750a80","authorEmail":"[email protected]","name":"Habitat Tests on Linux / tests (3.9, 11.6) / linux-job","jobName":"tests (3.9, 11.6) / linux-job","conclusion":"failure","completed_at":"2024-02-05T20:33:23Z","html_url":"https://github.com/pytorch/rl/actions/runs/7790379972/job/21244110231","head_branch":"fix-stepcount","pr_number":1866,"head_sha":"b97781b1e3d61c0d9beab0669d3a8b9fee9a6a0a","failure_captures":["RuntimeError: Command docker exec -t 76464cfdc338b98f3175956d804d04f523b19b5601599cd6c1d0f3877a59be95 /exec failed with exit code 139"],"failure_lines":["RuntimeError: Command docker exec -t 76464cfdc338b98f3175956d804d04f523b19b5601599cd6c1d0f3877a59be95 /exec failed with exit code 139"],"failure_context":["+ bash /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/run_test.sh","+ bash /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/install.sh","+ bash /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/setup_env.sh","+ cp /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/10_nvidia.json /usr/share/glvnd/egl_vendor.d/10_nvidia.json","+ this_dir=/pytorch/rl/.github/unittest/linux_libs/scripts_habitat","++ pwd","++ cd .github/unittest/linux_libs/scripts_habitat","+++ dirname .github/unittest/linux_libs/scripts_habitat/run_all.sh","+ apt-get dist-upgrade -y","+ apt-get install -y g++ gcc","+ apt-get install -y libglvnd0 libgl1 libglx0 libegl1 libgles2","+ apt-get install -y libglfw3 libgl1-mesa-glx libosmesa6 libglew-dev"],"time":"2024-02-05T20:33:26.520270Z"},{"workflowId":7790379981,"id":21244118066,"runnerName":"i-0226122db3b69a4dd","authorEmail":"[email protected]","name":"Libs Tests on Linux / unittests-brax (3.9, 12.1) / linux-job","jobName":"unittests-brax (3.9, 12.1) / linux-job","conclusion":"failure","completed_at":"2024-02-05T20:22:28Z","html_url":"https://github.com/pytorch/rl/actions/runs/7790379981/job/21244118066","head_branch":"fix-stepcount","pr_number":1866,"head_sha":"b97781b1e3d61c0d9beab0669d3a8b9fee9a6a0a","failure_captures":["The process '/usr/bin/git' failed with exit code 128"],"failure_lines":["##[error]The process '/usr/bin/git' failed with exit code 128"],"failure_context":["+ sudo systemctl restart docker","+ sudo yum install -y nvidia-docker2","+ sudo yum-config-manager --add-repo https://nvidia.github.io/nvidia-docker/amzn2/nvidia-docker.repo","+ sudo yum install -y yum-utils","+ set -e","+ echo 'INFO: Ignoring allowed status 0'","+ '[' 0 -eq 0 ']'","+ NVIDIA_SMI_STATUS=0","+ nvidia-smi --query-gpu=gpu_name --format=csv,noheader --id=0","+---------------------------------------------------------------------------------------+","+---------------------------------------------------------------------------------------+","+-----------------------------------------+----------------------+----------------------+"],"time":"2024-02-05T20:22:32.090508Z"},{"workflowId":7790380009,"id":21244109884,"runnerName":"i-0b49e25586912e3dc","authorEmail":"[email protected]","name":"Lint / c-source / linux-job","jobName":"c-source / linux-job","conclusion":"failure","completed_at":"2024-02-05T20:25:47Z","html_url":"https://github.com/pytorch/rl/actions/runs/7790380009/job/21244109884","head_branch":"fix-stepcount","pr_number":1866,"head_sha":"b97781b1e3d61c0d9beab0669d3a8b9fee9a6a0a","failure_captures":["RuntimeError: Command docker exec -t 9ac8135f619cda50592da8703c16b729449584d094ba09315154f3ae8ecb6eb5 /exec failed with exit code 1"],"failure_lines":["RuntimeError: Command docker exec -t 9ac8135f619cda50592da8703c16b729449584d094ba09315154f3ae8ecb6eb5 /exec failed with exit code 1"],"failure_context":["+ ./.github/unittest/linux/scripts/run-clang-format.py -r torchrl/csrc --clang-format-executable ./clang-format","+ set +e","+ echo '::group::Lint C source'","+ echo ::endgroup::","+ chmod +x ./clang-format","+ curl https://oss-clang-format.s3.us-east-2.amazonaws.com/linux64/clang-format-linux64 -o ./clang-format","+ echo '::group::Install lint tools'","+ echo ::endgroup::","+ LD_LIBRARY_PATH=/opt/conda/envs/ci/lib:/opt/rh/devtoolset-9/root/usr/lib64:/opt/rh/devtoolset-9/root/usr/lib:","+ export LD_LIBRARY_PATH=/opt/conda/envs/ci/lib:/opt/rh/devtoolset-9/root/usr/lib64:/opt/rh/devtoolset-9/root/usr/lib:","+ hash -r","+ '[' -n '' ']'"],"time":"2024-02-05T20:25:52.151971Z"},{"workflowId":7790379977,"id":21244110067,"runnerName":"GitHub Actions 160","authorEmail":"[email protected]","name":"Unit-tests on MacOS CPU / tests (3.11) / macos-job","jobName":"tests (3.11) / macos-job","conclusion":"failure","completed_at":"2024-02-05T20:23:32Z","html_url":"https://github.com/pytorch/rl/actions/runs/7790379977/job/21244110067","head_branch":"fix-stepcount","pr_number":1866,"head_sha":"b97781b1e3d61c0d9beab0669d3a8b9fee9a6a0a","failure_captures":["The process '/usr/local/bin/git' failed with exit code 128"],"failure_lines":["##[error]The process '/usr/local/bin/git' failed with exit code 128"],"failure_context":["+ /Users/runner/work/_temp/miniconda/bin/conda config --set channel_priority false","+ echo 'CONDA_INSTALL=/Users/runner/work/_temp/miniconda/bin/conda install --yes --quiet -p /Users/runner/work/_temp/conda_environment_7790379977'","+ [[ 3.9 == \3\.\1\1 ]]","+ echo 'CONDA_RUN=/Users/runner/work/_temp/miniconda/bin/conda run -p /Users/runner/work/_temp/conda_environment_7790379977 --no-capture-output'","+ echo CONDA_PREFIX=/Users/runner/work/_temp/conda_environment_7790379977","+ echo CONDA_ENV=/Users/runner/work/_temp/conda_environment_7790379977","+ [[ -n '' ]]","+ [[ -f '' ]]","+ [[ 0 == \0 ]]","+ [[ -z 0 ]]","+ set -e","+ UNTRACKED_FILES_COUNT=0"],"time":"2024-02-05T20:23:45.773546Z"},{"workflowId":7790379977,"id":21244111149,"runnerName":"GitHub Actions 217","authorEmail":"[email protected]","name":"Unit-tests on MacOS CPU / tests (3.8) / macos-job","jobName":"tests (3.8) / macos-job","conclusion":"failure","completed_at":"2024-02-05T20:22:56Z","html_url":"https://github.com/pytorch/rl/actions/runs/7790379977/job/21244111149","head_branch":"fix-stepcount","pr_number":1866,"head_sha":"b97781b1e3d61c0d9beab0669d3a8b9fee9a6a0a","failure_captures":["The process '/usr/local/bin/git' failed with exit code 128"],"failure_lines":["##[error]The process '/usr/local/bin/git' failed with exit code 128"],"failure_context":["+ /Users/runner/work/_temp/miniconda/bin/conda config --set channel_priority false","+ echo 'CONDA_INSTALL=/Users/runner/work/_temp/miniconda/bin/conda install --yes --quiet -p /Users/runner/work/_temp/conda_environment_7790379977'","+ [[ 3.9 == \3\.\1\1 ]]","+ echo 'CONDA_RUN=/Users/runner/work/_temp/miniconda/bin/conda run -p /Users/runner/work/_temp/conda_environment_7790379977 --no-capture-output'","+ echo CONDA_PREFIX=/Users/runner/work/_temp/conda_environment_7790379977","+ echo CONDA_ENV=/Users/runner/work/_temp/conda_environment_7790379977","+ [[ -n '' ]]","+ [[ -f '' ]]","+ [[ 0 == \0 ]]","+ [[ -z 0 ]]","+ set -e","+ UNTRACKED_FILES_COUNT=0"],"time":"2024-02-05T20:23:04.517601Z"},{"workflowId":7790379974,"id":21244109847,"runnerName":"i-0294ec1823da9c93b","authorEmail":"[email protected]","name":"Unit-tests on Windows / unittests-cpu / windows-job","jobName":"unittests-cpu / windows-job","conclusion":"failure","completed_at":"2024-02-06T03:16:00Z","html_url":"https://github.com/pytorch/rl/actions/runs/7790379974/job/21244109847","head_branch":"fix-stepcount","pr_number":1866,"head_sha":"b97781b1e3d61c0d9beab0669d3a8b9fee9a6a0a","failure_captures":["The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128"],"failure_lines":["##[error]The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128"],"failure_context":[],"time":"2024-02-06T03:16:04.294557Z"},{"workflowId":7790379974,"id":21244110752,"runnerName":"i-0974e40c922a87d06","authorEmail":"[email protected]","name":"Unit-tests on Windows / unittests-gpu / windows-job","jobName":"unittests-gpu / windows-job","conclusion":"failure","completed_at":"2024-02-05T21:01:44Z","html_url":"https://github.com/pytorch/rl/actions/runs/7790379974/job/21244110752","head_branch":"fix-stepcount","pr_number":1866,"head_sha":"b97781b1e3d61c0d9beab0669d3a8b9fee9a6a0a","failure_captures":["##[error]The operation was canceled."],"failure_lines":["##[error]The operation was canceled."],"failure_context":["+ python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu118","+ True","+ printf 'Installing PyTorch with %s\n' pytorch-cuda=11.6","+ git submodule update --init --recursive","+ git submodule sync","+ cudatoolkit=pytorch-cuda=11.6","+ version=11.6","++ python -c 'print('\''.'\''.join("11.6".split('\''.'\'')[:2]))'","+ echo 'Using CUDA 11.6 as determined by CU_VERSION'","+ cuda_toolkit_pckg=pytorch-cuda","+ [[ 11.6 == 11.6 ]]","+ cuda_toolkit_pckg=cudatoolkit"],"time":"2024-02-05T21:01:51.706392Z"}],"BROKEN_TRUNK":[],"UNSTABLE":[]}