Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add reduction parameter to On-Policy losses. #1890

Merged
merged 31 commits into from
Feb 15, 2024

Conversation

albertbou92
Copy link
Contributor

Description

This PR introduces a reduction option to the on-policy losses, similar to how Torch does it (e.g. https://pytorch.org/docs/stable/generated/torch.nn.MSELoss.html).

The ideas is to validate the approach for on-policy losses, the then move on to replicate it in the other losses.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Copy link

pytorch-bot bot commented Feb 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1890

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 8052e33 with merge base 899af07 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 9, 2024
test/test_cost.py Outdated Show resolved Hide resolved
@vmoens vmoens added the enhancement New feature or request label Feb 10, 2024
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!
I wonder if long term we should not structure the loss better, to avoid the batch-size issue pointed here.

TensorDict({"loss": {"actor": tensor, ...}, "metadata": {...}}, [])

which could let us set a different batch-size at diferent levels.
It isn't going to be easy to move to that format though! So for now I think the best would be to keep the output without batch-size until we figure out how to account for it long-term.

test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
torchrl/objectives/ppo.py Outdated Show resolved Hide resolved
torchrl/objectives/ppo.py Outdated Show resolved Hide resolved
torchrl/objectives/reinforce.py Show resolved Hide resolved
torchrl/objectives/reinforce.py Outdated Show resolved Hide resolved
torchrl/objectives/reinforce.py Outdated Show resolved Hide resolved
@albertbou92
Copy link
Contributor Author

albertbou92 commented Feb 12, 2024

I incorporated a part of the suggestions and left comments in the points that might need further discussion

@albertbou92 albertbou92 requested a review from vmoens February 12, 2024 09:50
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just smth minor in the tests

test/test_cost.py Outdated Show resolved Hide resolved
@vmoens vmoens merged commit 67f659c into pytorch:main Feb 15, 2024
63 of 68 checks passed
@vmoens vmoens deleted the loss_reduction branch February 15, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants