Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOMERG] Add @overload to forward in losses #1893

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

lint

738d971
Select commit
Loading
Failed to load commit list.
Open

[NOMERG] Add @overload to forward in losses #1893

lint
738d971
Select commit
Loading
Failed to load commit list.
PyTorch Bot / Dr.CI completed Feb 9, 2024 in 0s

Dr.CI classification results

{"FAILED":[],"FLAKY":[{"workflowId":7849592476,"id":21423313949,"runnerName":"i-02b95714c937e3456","authorEmail":"[email protected]","name":"Habitat Tests on Linux / tests (3.9, 11.6) / linux-job","jobName":"tests (3.9, 11.6) / linux-job","conclusion":"failure","completed_at":"2024-02-09T21:28:18Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592476/job/21423313949","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["RuntimeError: Command docker exec -t 51ef1822a8e85db1d4f8962e3c7b465803eca551d40a166b564f6a026f219a32 /exec failed with exit code 139"],"failure_lines":["RuntimeError: Command docker exec -t 51ef1822a8e85db1d4f8962e3c7b465803eca551d40a166b564f6a026f219a32 /exec failed with exit code 139"],"failure_context":["+ bash /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/run_test.sh","+ bash /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/install.sh","+ bash /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/setup_env.sh","+ cp /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/10_nvidia.json /usr/share/glvnd/egl_vendor.d/10_nvidia.json","+ this_dir=/pytorch/rl/.github/unittest/linux_libs/scripts_habitat","++ pwd","++ cd .github/unittest/linux_libs/scripts_habitat","+++ dirname .github/unittest/linux_libs/scripts_habitat/run_all.sh","+ apt-get dist-upgrade -y","+ apt-get install -y g++ gcc","+ apt-get install -y libglvnd0 libgl1 libglx0 libegl1 libgles2","+ apt-get install -y libglfw3 libgl1-mesa-glx libosmesa6 libglew-dev"],"time":"2024-02-09T21:28:21.742348Z"},{"workflowId":7849592484,"id":21423316874,"runnerName":"i-0a6e5616db83065ce","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-cpu (3.10) / linux-job","jobName":"tests-cpu (3.10) / linux-job","conclusion":"failure","completed_at":"2024-02-09T21:34:38Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592484/job/21423316874","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_rb.py::TestStorages::test_storage_dumps_loads[True-pytree-LazyTensorStorage-device_data0]"],"failure_lines":["FAILED test/test_rb.py::TestStorages::test_storage_dumps_loads[True-pytree-LazyTensorStorage-device_data0] - AssertionError: Tensor-likes are not close!"],"failure_context":["+ python .github/unittest/helpers/coverage_run_parallel.py -m pytest test --instafail --durations 200 -vv --capture no --ignore test/test_rlhf.py --ignore test/test_distributed.py --timeout=120","+ '[' cpu '!=' cpu ']'","+ pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym or test_dm_control_pixels or test_dm_control or test_tb'","+ pytest test/smoke_test.py -v --durations 200","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=100","+ export MAX_IDLE_COUNT=100","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","+ MKL_THREADING_LAYER=GNU","+ export MKL_THREADING_LAYER=GNU"],"time":"2024-02-09T21:34:42.316933Z"},{"workflowId":7849592484,"id":21423316639,"runnerName":"i-0b0761792818c4e30","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-cpu (3.11) / linux-job","jobName":"tests-cpu (3.11) / linux-job","conclusion":"failure","completed_at":"2024-02-09T21:34:01Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592484/job/21423316639","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2]"],"failure_lines":["FAILED test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2] - TypeError: A2CLoss.forward() got an unexpected keyword argument 'observation2'"],"failure_context":["+ python .github/unittest/helpers/coverage_run_parallel.py -m pytest test --instafail --durations 200 -vv --capture no --ignore test/test_rlhf.py --ignore test/test_distributed.py --timeout=120","+ '[' cpu '!=' cpu ']'","+ pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym or test_dm_control_pixels or test_dm_control or test_tb'","+ pytest test/smoke_test.py -v --durations 200","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=100","+ export MAX_IDLE_COUNT=100","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","+ MKL_THREADING_LAYER=GNU","+ export MKL_THREADING_LAYER=GNU"],"time":"2024-02-09T21:34:05.870697Z"},{"workflowId":7849592484,"id":21423316372,"runnerName":"i-093c0fb9cfcf07c27","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-cpu (3.8) / linux-job","jobName":"tests-cpu (3.8) / linux-job","conclusion":"failure","completed_at":"2024-02-09T21:34:33Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592484/job/21423316372","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2]"],"failure_lines":["FAILED test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2] - TypeError: forward() got an unexpected keyword argument 'observation2'"],"failure_context":["+ python .github/unittest/helpers/coverage_run_parallel.py -m pytest test --instafail --durations 200 -vv --capture no --ignore test/test_rlhf.py --ignore test/test_distributed.py --timeout=120","+ '[' cpu '!=' cpu ']'","+ pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym or test_dm_control_pixels or test_dm_control or test_tb'","+ pytest test/smoke_test.py -v --durations 200","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=100","+ export MAX_IDLE_COUNT=100","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","+ MKL_THREADING_LAYER=GNU","+ export MKL_THREADING_LAYER=GNU"],"time":"2024-02-09T21:34:38.791780Z"},{"workflowId":7849592484,"id":21423317110,"runnerName":"i-05e4d1ea6f9ec64c0","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-cpu (3.9) / linux-job","jobName":"tests-cpu (3.9) / linux-job","conclusion":"failure","completed_at":"2024-02-09T21:35:13Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592484/job/21423317110","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2]"],"failure_lines":["FAILED test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2] - TypeError: forward() got an unexpected keyword argument 'observation2'"],"failure_context":["+ python .github/unittest/helpers/coverage_run_parallel.py -m pytest test --instafail --durations 200 -vv --capture no --ignore test/test_rlhf.py --ignore test/test_distributed.py --timeout=120","+ '[' cpu '!=' cpu ']'","+ pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym or test_dm_control_pixels or test_dm_control or test_tb'","+ pytest test/smoke_test.py -v --durations 200","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=100","+ export MAX_IDLE_COUNT=100","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","+ MKL_THREADING_LAYER=GNU","+ export MKL_THREADING_LAYER=GNU"],"time":"2024-02-09T21:35:17.742510Z"},{"workflowId":7849592484,"id":21423317334,"runnerName":"i-076faa1f6bb674fe6","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-gpu (3.8, 12.1) / linux-job","jobName":"tests-gpu (3.8, 12.1) / linux-job","conclusion":"failure","completed_at":"2024-02-09T22:03:31Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592484/job/21423317334","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_rb.py::TestStorages::test_storage_dumps_loads[True-pytree-LazyTensorStorage-device_data0]"],"failure_lines":["FAILED test/test_rb.py::TestStorages::test_storage_dumps_loads[True-pytree-LazyTensorStorage-device_data0] - AssertionError: Tensor-likes are not close!"],"failure_context":["+ python .github/unittest/helpers/coverage_run_parallel.py -m pytest test --instafail --durations 200 -vv --capture no --ignore test/test_rlhf.py --timeout=120","+ '[' cu121 '!=' cpu ']'","+ pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym or test_dm_control_pixels or test_dm_control or test_tb'","+ pytest test/smoke_test.py -v --durations 200","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=100","+ export MAX_IDLE_COUNT=100","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","+ MKL_THREADING_LAYER=GNU","+ export MKL_THREADING_LAYER=GNU"],"time":"2024-02-09T22:03:36.793540Z"},{"workflowId":7849592484,"id":21423317540,"runnerName":"i-012e2d3b7f6ae1751","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job","jobName":"tests-olddeps (3.8, 11.6) / linux-job","conclusion":"failure","completed_at":"2024-02-09T21:50:22Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592484/job/21423317540","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2]"],"failure_lines":["FAILED test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2] - TypeError: forward() got an unexpected keyword argument 'observation2'"],"failure_context":["+ bash .github/unittest/linux_olddeps/scripts_gym_0_13/batch_scripts.sh","+ bash .github/unittest/linux_olddeps/scripts_gym_0_13/setup_env.sh","+ TF_CPP_MIN_LOG_LEVEL=0","+ export TF_CPP_MIN_LOG_LEVEL=0","+ UPLOAD_CHANNEL=nightly","+ export UPLOAD_CHANNEL=nightly","+ TAR_OPTIONS=--no-same-owner","+ export TAR_OPTIONS=--no-same-owner","+ CU_VERSION=cu116","+ export CU_VERSION=cu116","+ PYTHON_VERSION=3.9","+ export PYTHON_VERSION=3.9"],"time":"2024-02-09T21:50:26.325251Z"},{"workflowId":7849592484,"id":21423316069,"runnerName":"i-036883e15dc9be42c","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-optdeps (3.9, 12.1) / linux-job","jobName":"tests-optdeps (3.9, 12.1) / linux-job","conclusion":"failure","completed_at":"2024-02-09T21:41:02Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592484/job/21423316069","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2]"],"failure_lines":["FAILED test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2] - TypeError: forward() got an unexpected keyword argument 'observation2'"],"failure_context":["+ bash /pytorch/rl/.github/unittest/linux_optdeps/scripts/run_test.sh","+ bash /pytorch/rl/.github/unittest/linux_optdeps/scripts/install.sh","+ bash /pytorch/rl/.github/unittest/linux_optdeps/scripts/setup_env.sh","+ cp /pytorch/rl/.github/unittest/linux_optdeps/scripts/10_nvidia.json /usr/share/glvnd/egl_vendor.d/10_nvidia.json","+ [[ linux-gnu != \d\a\r\w\i\n* ]]","+ this_dir=/pytorch/rl/.github/unittest/linux_optdeps/scripts","++ pwd","++ cd .github/unittest/linux_optdeps/scripts","+++ dirname .github/unittest/linux_optdeps/scripts/run_all.sh","+ apt-get install -y g++ gcc","+ '[' cu121 == cpu ']'","+ apt-get install -y libglvnd0 libgl1 libglx0 libegl1 libgles2"],"time":"2024-02-09T21:41:06.571853Z"},{"workflowId":7849592484,"id":21423317716,"runnerName":"i-035a4e7e63ee00f56","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-stable-gpu (3.8, 11.8) / linux-job","jobName":"tests-stable-gpu (3.8, 11.8) / linux-job","conclusion":"failure","completed_at":"2024-02-09T22:00:55Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592484/job/21423317716","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2]"],"failure_lines":["FAILED test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2] - TypeError: forward() got an unexpected keyword argument 'observation2'"],"failure_context":["+ python .github/unittest/helpers/coverage_run_parallel.py -m pytest test --instafail --durations 200 -vv --capture no --ignore test/test_rlhf.py --timeout=120","+ '[' cu118 '!=' cpu ']'","+ pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym or test_dm_control_pixels or test_dm_control or test_tb'","+ pytest test/smoke_test.py -v --durations 200","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=100","+ export MAX_IDLE_COUNT=100","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","+ MKL_THREADING_LAYER=GNU","+ export MKL_THREADING_LAYER=GNU"],"time":"2024-02-09T22:00:59.793167Z"},{"workflowId":7849592452,"id":21423300906,"runnerName":"GitHub Actions 156","authorEmail":"[email protected]","name":"Unit-tests on MacOS CPU / tests (3.11) / macos-job","jobName":"tests (3.11) / macos-job","conclusion":"failure","completed_at":"2024-02-09T21:44:58Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592452/job/21423300906","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2]"],"failure_lines":["FAILED test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2] - TypeError: A2CLoss.forward() got an unexpected keyword argument 'observation2'"],"failure_context":["+ python .github/unittest/helpers/coverage_run_parallel.py -m pytest test --instafail --durations 200 -vv --capture no --ignore test/test_rlhf.py --ignore test/test_distributed.py --timeout=120","+ '[' cpu '!=' cpu ']'","+ pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym or test_dm_control_pixels or test_dm_control or test_tb'","+ pytest test/smoke_test.py -v --durations 200","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=100","+ export MAX_IDLE_COUNT=100","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","+ MKL_THREADING_LAYER=GNU","+ export MKL_THREADING_LAYER=GNU"],"time":"2024-02-09T21:45:14.041048Z"},{"workflowId":7849592452,"id":21423301120,"runnerName":"GitHub Actions 318","authorEmail":"[email protected]","name":"Unit-tests on MacOS CPU / tests (3.8) / macos-job","jobName":"tests (3.8) / macos-job","conclusion":"failure","completed_at":"2024-02-09T21:44:26Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592452/job/21423301120","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2]"],"failure_lines":["FAILED test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2] - TypeError: forward() got an unexpected keyword argument 'observation2'"],"failure_context":["+ python .github/unittest/helpers/coverage_run_parallel.py -m pytest test --instafail --durations 200 -vv --capture no --ignore test/test_rlhf.py --ignore test/test_distributed.py --timeout=120","+ '[' cpu '!=' cpu ']'","+ pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym or test_dm_control_pixels or test_dm_control or test_tb'","+ pytest test/smoke_test.py -v --durations 200","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=100","+ export MAX_IDLE_COUNT=100","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","+ MKL_THREADING_LAYER=GNU","+ export MKL_THREADING_LAYER=GNU"],"time":"2024-02-09T21:44:38.682009Z"},{"workflowId":7849592463,"id":21423297118,"runnerName":"i-0b89924e37233f5e7","authorEmail":"[email protected]","name":"Unit-tests on Windows / unittests-cpu / windows-job","jobName":"unittests-cpu / windows-job","conclusion":"failure","completed_at":"2024-02-09T21:48:15Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592463/job/21423297118","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2]"],"failure_lines":["FAILED test/test_cost.py::TestA2C::test_a2c_notensordict[terminated2-done2-reward2-observation2-action2] - TypeError: forward() got an unexpected keyword argument 'observation2'"],"failure_context":["+ pytest --junitxml=test-results/junit.xml -v --durations 200 --ignore test/test_distributed.py --ignore test/test_rlhf.py","+ python -m torch.utils.collect_env","+ LAZY_LEGACY_OP=False","+ export LAZY_LEGACY_OP=False","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=60","+ export MAX_IDLE_COUNT=60","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","++ [[ cpu != \c\p\u ]]","++ [[ 3 -eq 5 ]]"],"time":"2024-02-09T21:48:19.729719Z"},{"workflowId":7849592463,"id":21423297326,"runnerName":"i-04b86e91dbc024e9d","authorEmail":"[email protected]","name":"Unit-tests on Windows / unittests-gpu / windows-job","jobName":"unittests-gpu / windows-job","conclusion":"failure","completed_at":"2024-02-09T21:46:12Z","html_url":"https://github.com/pytorch/rl/actions/runs/7849592463/job/21423297326","head_branch":"prototype-loss-overload","pr_number":1893,"head_sha":"738d97109190cf04c8b5c450d13b622f718a7af7","failure_captures":["##[error]The operation was canceled."],"failure_lines":["##[error]The operation was canceled."],"failure_context":["+ pytest --junitxml=test-results/junit.xml -v --durations 200 --ignore test/test_distributed.py --ignore test/test_rlhf.py","+ python -m torch.utils.collect_env","+ LAZY_LEGACY_OP=False","+ export LAZY_LEGACY_OP=False","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ MAX_IDLE_COUNT=60","+ export MAX_IDLE_COUNT=60","+ CKPT_BACKEND=torch","+ export CKPT_BACKEND=torch","++ grep CUDA","++ env"],"time":"2024-02-09T21:46:17.041334Z"}],"BROKEN_TRUNK":[],"UNSTABLE":[]}