Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Algorithm] CrossQ #2033
[Algorithm] CrossQ #2033
Changes from 19 commits
0a23ae8
9bdee71
570a20e
5086249
c3a927f
d1c9c34
e879b7c
75255e7
a7b79c3
be84f3f
2170ad8
75d4cee
7711a4e
f0ac167
37abb14
bc7675a
9543f2e
53e35f7
172e1c0
fdb7e8b
5501d43
c47ac84
e718c3f
f94165e
02c94ff
93b6a7b
4b914e6
af8c64a
845c8a9
7b4a69d
77de044
35c7a98
68a1a9f
c04eb3b
12672ee
7fbb27d
ff80481
caf702e
70e2882
ccd1b7f
d3c8b0e
d3e0bb1
349cb28
75a43e7
abada6c
c878b81
f222b11
067b560
c010e39
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this in the modules no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and add it to the doc.
Happy to write a couple of tests.
Is it a copy paste? If so, can we check the license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this a buffer such that loading it from a checkpoint restores its value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about
torch.nn.functional.batch_norm
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use
torch.nn.functional.batch_norm
, and move this out of the block (since it's the same line as 64)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
torch.nn.functional.batch_norm
has atraining
param