Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix jumanji #2064

Merged
merged 2 commits into from
Apr 7, 2024
Merged

[BugFix] Fix jumanji #2064

merged 2 commits into from
Apr 7, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 7, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2064

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 21 Unrelated Failures

As of commit d0b2c57 with merge base 8dc35be (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2024
@vmoens vmoens added the bug Something isn't working label Apr 7, 2024
@vmoens vmoens merged commit cf685b7 into main Apr 7, 2024
11 of 23 checks passed
@vmoens vmoens deleted the fix-jumanji branch April 7, 2024 18:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}8$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 52.9040ms 52.6097ms 19.0079 Ops/s 17.7618 Ops/s $\textbf{\color{#35bf28}+7.02\%}$
test_sync 34.4456ms 28.6742ms 34.8745 Ops/s 31.0020 Ops/s $\textbf{\color{#35bf28}+12.49\%}$
test_async 60.2706ms 27.3775ms 36.5263 Ops/s 35.8229 Ops/s $\color{#35bf28}+1.96\%$
test_simple 0.3968s 0.3430s 2.9156 Ops/s 2.9703 Ops/s $\color{#d91a1a}-1.84\%$
test_transformed 0.5306s 0.4859s 2.0582 Ops/s 2.0610 Ops/s $\color{#d91a1a}-0.14\%$
test_serial 1.2279s 1.1854s 0.8436 Ops/s 0.8272 Ops/s $\color{#35bf28}+1.98\%$
test_parallel 1.0438s 0.9978s 1.0022 Ops/s 0.9906 Ops/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[True-True-True-True-True] 84.1970μs 21.4844μs 46.5454 KOps/s 46.4077 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[True-True-True-True-False] 40.0150μs 13.0605μs 76.5665 KOps/s 76.7507 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[True-True-True-False-True] 35.0050μs 12.5175μs 79.8881 KOps/s 78.5447 KOps/s $\color{#35bf28}+1.71\%$
test_step_mdp_speed[True-True-True-False-False] 32.1710μs 7.6483μs 130.7479 KOps/s 129.6320 KOps/s $\color{#35bf28}+0.86\%$
test_step_mdp_speed[True-True-False-True-True] 45.9760μs 22.9164μs 43.6369 KOps/s 43.2606 KOps/s $\color{#35bf28}+0.87\%$
test_step_mdp_speed[True-True-False-True-False] 32.5510μs 14.3410μs 69.7300 KOps/s 69.3476 KOps/s $\color{#35bf28}+0.55\%$
test_step_mdp_speed[True-True-False-False-True] 37.2300μs 13.7933μs 72.4988 KOps/s 71.7780 KOps/s $\color{#35bf28}+1.00\%$
test_step_mdp_speed[True-True-False-False-False] 33.9240μs 8.8925μs 112.4547 KOps/s 110.5399 KOps/s $\color{#35bf28}+1.73\%$
test_step_mdp_speed[True-False-True-True-True] 59.8020μs 24.4022μs 40.9799 KOps/s 40.5743 KOps/s $\color{#35bf28}+1.00\%$
test_step_mdp_speed[True-False-True-True-False] 40.0040μs 15.7415μs 63.5265 KOps/s 62.9602 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[True-False-True-False-True] 46.7270μs 13.8105μs 72.4084 KOps/s 71.2256 KOps/s $\color{#35bf28}+1.66\%$
test_step_mdp_speed[True-False-True-False-False] 31.9700μs 8.8702μs 112.7374 KOps/s 111.2352 KOps/s $\color{#35bf28}+1.35\%$
test_step_mdp_speed[True-False-False-True-True] 48.9710μs 25.3934μs 39.3804 KOps/s 38.8170 KOps/s $\color{#35bf28}+1.45\%$
test_step_mdp_speed[True-False-False-True-False] 66.7580μs 16.9382μs 59.0381 KOps/s 58.7903 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-False-False-False-True] 37.0990μs 14.9780μs 66.7647 KOps/s 65.5028 KOps/s $\color{#35bf28}+1.93\%$
test_step_mdp_speed[True-False-False-False-False] 46.9950μs 9.9606μs 100.3955 KOps/s 96.8137 KOps/s $\color{#35bf28}+3.70\%$
test_step_mdp_speed[False-True-True-True-True] 47.2990μs 24.3893μs 41.0016 KOps/s 40.1587 KOps/s $\color{#35bf28}+2.10\%$
test_step_mdp_speed[False-True-True-True-False] 78.0060μs 15.7577μs 63.4612 KOps/s 63.1201 KOps/s $\color{#35bf28}+0.54\%$
test_step_mdp_speed[False-True-True-False-True] 50.0640μs 16.3825μs 61.0409 KOps/s 61.3912 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[False-True-True-False-False] 49.9540μs 10.1600μs 98.4255 KOps/s 97.8151 KOps/s $\color{#35bf28}+0.62\%$
test_step_mdp_speed[False-True-False-True-True] 46.9370μs 25.7812μs 38.7879 KOps/s 38.4810 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[False-True-False-True-False] 65.3720μs 16.8329μs 59.4074 KOps/s 58.9772 KOps/s $\color{#35bf28}+0.73\%$
test_step_mdp_speed[False-True-False-False-True] 38.9130μs 17.3871μs 57.5141 KOps/s 57.1137 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[False-True-False-False-False] 29.5660μs 11.3693μs 87.9564 KOps/s 87.0928 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[False-False-True-True-True] 76.3320μs 26.9387μs 37.1213 KOps/s 37.0068 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[False-False-True-True-False] 38.9030μs 18.2225μs 54.8771 KOps/s 54.1798 KOps/s $\color{#35bf28}+1.29\%$
test_step_mdp_speed[False-False-True-False-True] 39.3640μs 17.5222μs 57.0706 KOps/s 56.6175 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[False-False-True-False-False] 34.0040μs 11.3993μs 87.7250 KOps/s 85.8969 KOps/s $\color{#35bf28}+2.13\%$
test_step_mdp_speed[False-False-False-True-True] 68.5080μs 27.6568μs 36.1575 KOps/s 35.4633 KOps/s $\color{#35bf28}+1.96\%$
test_step_mdp_speed[False-False-False-True-False] 81.4620μs 19.1364μs 52.2564 KOps/s 51.1310 KOps/s $\color{#35bf28}+2.20\%$
test_step_mdp_speed[False-False-False-False-True] 40.6060μs 18.4656μs 54.1549 KOps/s 54.4867 KOps/s $\color{#d91a1a}-0.61\%$
test_step_mdp_speed[False-False-False-False-False] 51.1160μs 12.5362μs 79.7691 KOps/s 79.1973 KOps/s $\color{#35bf28}+0.72\%$
test_values[generalized_advantage_estimate-True-True] 10.2811ms 9.2563ms 108.0348 Ops/s 109.7969 Ops/s $\color{#d91a1a}-1.60\%$
test_values[vec_generalized_advantage_estimate-True-True] 58.9193ms 36.0330ms 27.7523 Ops/s 29.9004 Ops/s $\textbf{\color{#d91a1a}-7.18\%}$
test_values[td0_return_estimate-False-False] 0.2320ms 0.1654ms 6.0448 KOps/s 5.9597 KOps/s $\color{#35bf28}+1.43\%$
test_values[td1_return_estimate-False-False] 24.4642ms 22.6881ms 44.0759 Ops/s 44.1778 Ops/s $\color{#d91a1a}-0.23\%$
test_values[vec_td1_return_estimate-False-False] 38.2803ms 35.3598ms 28.2807 Ops/s 29.9451 Ops/s $\textbf{\color{#d91a1a}-5.56\%}$
test_values[td_lambda_return_estimate-True-False] 35.6883ms 33.1783ms 30.1402 Ops/s 30.5099 Ops/s $\color{#d91a1a}-1.21\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.3445ms 35.3083ms 28.3219 Ops/s 29.9354 Ops/s $\textbf{\color{#d91a1a}-5.39\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.2558ms 8.1242ms 123.0895 Ops/s 124.0653 Ops/s $\color{#d91a1a}-0.79\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3499ms 2.0620ms 484.9728 Ops/s 503.0518 Ops/s $\color{#d91a1a}-3.59\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4892ms 0.3494ms 2.8618 KOps/s 2.8494 KOps/s $\color{#35bf28}+0.43\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.6869ms 46.0254ms 21.7271 Ops/s 21.4567 Ops/s $\color{#35bf28}+1.26\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.1307ms 3.0202ms 331.1012 Ops/s 329.8029 Ops/s $\color{#35bf28}+0.39\%$
test_dqn_speed 3.3001ms 1.3351ms 749.0114 Ops/s 741.9319 Ops/s $\color{#35bf28}+0.95\%$
test_ddpg_speed 3.3648ms 2.6703ms 374.4846 Ops/s 371.5716 Ops/s $\color{#35bf28}+0.78\%$
test_sac_speed 8.4301ms 8.1027ms 123.4162 Ops/s 122.1792 Ops/s $\color{#35bf28}+1.01\%$
test_redq_speed 14.0345ms 13.0720ms 76.4996 Ops/s 77.0975 Ops/s $\color{#d91a1a}-0.78\%$
test_redq_deprec_speed 18.9947ms 13.3192ms 75.0796 Ops/s 76.9785 Ops/s $\color{#d91a1a}-2.47\%$
test_td3_speed 8.2414ms 8.0526ms 124.1830 Ops/s 122.0785 Ops/s $\color{#35bf28}+1.72\%$
test_cql_speed 37.9574ms 36.2126ms 27.6147 Ops/s 27.7817 Ops/s $\color{#d91a1a}-0.60\%$
test_a2c_speed 7.8848ms 7.2806ms 137.3511 Ops/s 137.0229 Ops/s $\color{#35bf28}+0.24\%$
test_ppo_speed 8.5715ms 7.5288ms 132.8235 Ops/s 132.4193 Ops/s $\color{#35bf28}+0.31\%$
test_reinforce_speed 75.3268ms 6.9837ms 143.1916 Ops/s 153.4872 Ops/s $\textbf{\color{#d91a1a}-6.71\%}$
test_iql_speed 33.5442ms 32.5902ms 30.6841 Ops/s 30.8360 Ops/s $\color{#d91a1a}-0.49\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.5374ms 2.2221ms 450.0274 Ops/s 448.7310 Ops/s $\color{#35bf28}+0.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9502ms 0.4984ms 2.0065 KOps/s 1.8137 KOps/s $\textbf{\color{#35bf28}+10.63\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8326ms 0.5037ms 1.9852 KOps/s 2.1211 KOps/s $\textbf{\color{#d91a1a}-6.40\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.5960ms 2.1537ms 464.3203 Ops/s 454.0748 Ops/s $\color{#35bf28}+2.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0372ms 0.4880ms 2.0490 KOps/s 2.0405 KOps/s $\color{#35bf28}+0.41\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7122ms 0.4657ms 2.1475 KOps/s 2.1404 KOps/s $\color{#35bf28}+0.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5686ms 1.2204ms 819.3889 Ops/s 813.7183 Ops/s $\color{#35bf28}+0.70\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.8323ms 1.1507ms 869.0076 Ops/s 857.3796 Ops/s $\color{#35bf28}+1.36\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3701ms 2.2892ms 436.8299 Ops/s 432.9416 Ops/s $\color{#35bf28}+0.90\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1158ms 0.6106ms 1.6377 KOps/s 1.6283 KOps/s $\color{#35bf28}+0.58\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8324ms 0.5857ms 1.7073 KOps/s 1.7008 KOps/s $\color{#35bf28}+0.38\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.3930ms 2.2357ms 447.2932 Ops/s 462.3560 Ops/s $\color{#d91a1a}-3.26\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0076ms 0.5006ms 1.9976 KOps/s 2.0001 KOps/s $\color{#d91a1a}-0.13\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5651ms 0.4708ms 2.1240 KOps/s 2.1113 KOps/s $\color{#35bf28}+0.60\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.5065ms 2.1733ms 460.1309 Ops/s 459.7907 Ops/s $\color{#35bf28}+0.07\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.5903ms 0.4879ms 2.0498 KOps/s 2.0217 KOps/s $\color{#35bf28}+1.39\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 89.7038ms 0.5823ms 1.7173 KOps/s 2.1524 KOps/s $\textbf{\color{#d91a1a}-20.22\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6034ms 2.2931ms 436.0861 Ops/s 431.1502 Ops/s $\color{#35bf28}+1.14\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7288ms 0.6111ms 1.6365 KOps/s 1.6180 KOps/s $\color{#35bf28}+1.14\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8400ms 0.5896ms 1.6959 KOps/s 1.6570 KOps/s $\color{#35bf28}+2.35\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 87.7333ms 6.9892ms 143.0775 Ops/s 140.0688 Ops/s $\color{#35bf28}+2.15\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.3629ms 12.1707ms 82.1642 Ops/s 83.5720 Ops/s $\color{#d91a1a}-1.68\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.0717ms 1.0256ms 975.0638 Ops/s 959.4750 Ops/s $\color{#35bf28}+1.62\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 78.4184ms 5.1811ms 193.0081 Ops/s 143.4108 Ops/s $\textbf{\color{#35bf28}+34.58\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 96.4000ms 14.0498ms 71.1756 Ops/s 83.8254 Ops/s $\textbf{\color{#d91a1a}-15.09\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.8120ms 1.0679ms 936.4001 Ops/s 964.7305 Ops/s $\color{#d91a1a}-2.94\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 85.8826ms 5.6572ms 176.7663 Ops/s 178.1971 Ops/s $\color{#d91a1a}-0.80\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 20.1992ms 12.5893ms 79.4328 Ops/s 70.9876 Ops/s $\textbf{\color{#35bf28}+11.90\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.6583ms 1.4679ms 681.2403 Ops/s 740.6240 Ops/s $\textbf{\color{#d91a1a}-8.02\%}$

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1024s 0.1017s 9.8282 Ops/s 9.2218 Ops/s $\textbf{\color{#35bf28}+6.58\%}$
test_sync 87.8766ms 87.2389ms 11.4628 Ops/s 11.4131 Ops/s $\color{#35bf28}+0.44\%$
test_async 0.1653s 71.7705ms 13.9333 Ops/s 13.9549 Ops/s $\color{#d91a1a}-0.15\%$
test_single_pixels 0.1837s 0.1202s 8.3163 Ops/s 8.8840 Ops/s $\textbf{\color{#d91a1a}-6.39\%}$
test_sync_pixels 0.1241s 70.0017ms 14.2854 Ops/s 14.0988 Ops/s $\color{#35bf28}+1.32\%$
test_async_pixels 0.1227s 61.5244ms 16.2537 Ops/s 16.2472 Ops/s $\color{#35bf28}+0.04\%$
test_simple 0.7575s 0.6976s 1.4335 Ops/s 1.4231 Ops/s $\color{#35bf28}+0.74\%$
test_transformed 0.9779s 0.9217s 1.0850 Ops/s 1.0747 Ops/s $\color{#35bf28}+0.96\%$
test_serial 2.1913s 2.1405s 0.4672 Ops/s 0.4655 Ops/s $\color{#35bf28}+0.36\%$
test_parallel 1.8899s 1.8251s 0.5479 Ops/s 0.5530 Ops/s $\color{#d91a1a}-0.93\%$
test_step_mdp_speed[True-True-True-True-True] 0.1026ms 32.9183μs 30.3782 KOps/s 29.4644 KOps/s $\color{#35bf28}+3.10\%$
test_step_mdp_speed[True-True-True-True-False] 35.8710μs 19.8296μs 50.4297 KOps/s 49.8919 KOps/s $\color{#35bf28}+1.08\%$
test_step_mdp_speed[True-True-True-False-True] 41.7110μs 18.2975μs 54.6524 KOps/s 52.0478 KOps/s $\textbf{\color{#35bf28}+5.00\%}$
test_step_mdp_speed[True-True-True-False-False] 35.9610μs 11.1521μs 89.6692 KOps/s 89.0679 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[True-True-False-True-True] 59.8010μs 34.8231μs 28.7166 KOps/s 28.4012 KOps/s $\color{#35bf28}+1.11\%$
test_step_mdp_speed[True-True-False-True-False] 47.2910μs 21.3877μs 46.7559 KOps/s 46.4326 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[True-True-False-False-True] 43.8510μs 20.2838μs 49.3003 KOps/s 47.8349 KOps/s $\color{#35bf28}+3.06\%$
test_step_mdp_speed[True-True-False-False-False] 32.3900μs 13.1728μs 75.9138 KOps/s 75.1607 KOps/s $\color{#35bf28}+1.00\%$
test_step_mdp_speed[True-False-True-True-True] 60.7010μs 36.7997μs 27.1742 KOps/s 26.2881 KOps/s $\color{#35bf28}+3.37\%$
test_step_mdp_speed[True-False-True-True-False] 44.5700μs 23.6209μs 42.3353 KOps/s 42.1899 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[True-False-True-False-True] 42.3310μs 20.0754μs 49.8123 KOps/s 47.6737 KOps/s $\color{#35bf28}+4.49\%$
test_step_mdp_speed[True-False-True-False-False] 39.5410μs 13.0286μs 76.7542 KOps/s 76.0744 KOps/s $\color{#35bf28}+0.89\%$
test_step_mdp_speed[True-False-False-True-True] 67.8210μs 37.8196μs 26.4413 KOps/s 25.3263 KOps/s $\color{#35bf28}+4.40\%$
test_step_mdp_speed[True-False-False-True-False] 46.9210μs 25.2075μs 39.6708 KOps/s 38.7150 KOps/s $\color{#35bf28}+2.47\%$
test_step_mdp_speed[True-False-False-False-True] 45.5810μs 21.9264μs 45.6071 KOps/s 44.1446 KOps/s $\color{#35bf28}+3.31\%$
test_step_mdp_speed[True-False-False-False-False] 32.6000μs 14.9257μs 66.9986 KOps/s 66.0294 KOps/s $\color{#35bf28}+1.47\%$
test_step_mdp_speed[False-True-True-True-True] 70.1610μs 35.8502μs 27.8938 KOps/s 26.6702 KOps/s $\color{#35bf28}+4.59\%$
test_step_mdp_speed[False-True-True-True-False] 48.7300μs 23.4449μs 42.6532 KOps/s 41.6037 KOps/s $\color{#35bf28}+2.52\%$
test_step_mdp_speed[False-True-True-False-True] 44.5810μs 24.7542μs 40.3972 KOps/s 41.0590 KOps/s $\color{#d91a1a}-1.61\%$
test_step_mdp_speed[False-True-True-False-False] 31.4300μs 15.0141μs 66.6040 KOps/s 66.7893 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[False-True-False-True-True] 69.8710μs 38.2556μs 26.1399 KOps/s 25.3052 KOps/s $\color{#35bf28}+3.30\%$
test_step_mdp_speed[False-True-False-True-False] 50.0500μs 25.2966μs 39.5311 KOps/s 38.8699 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[False-True-False-False-True] 50.0910μs 26.0713μs 38.3563 KOps/s 37.8737 KOps/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[False-True-False-False-False] 42.0210μs 16.5956μs 60.2570 KOps/s 58.4942 KOps/s $\color{#35bf28}+3.01\%$
test_step_mdp_speed[False-False-True-True-True] 69.1020μs 39.8788μs 25.0760 KOps/s 24.2264 KOps/s $\color{#35bf28}+3.51\%$
test_step_mdp_speed[False-False-True-True-False] 51.0310μs 27.4548μs 36.4235 KOps/s 36.5653 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[False-False-True-False-True] 42.1700μs 26.5234μs 37.7025 KOps/s 37.7932 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[False-False-True-False-False] 33.4600μs 16.6092μs 60.2075 KOps/s 59.2948 KOps/s $\color{#35bf28}+1.54\%$
test_step_mdp_speed[False-False-False-True-True] 78.4110μs 42.0417μs 23.7859 KOps/s 23.7010 KOps/s $\color{#35bf28}+0.36\%$
test_step_mdp_speed[False-False-False-True-False] 95.6020μs 28.6595μs 34.8924 KOps/s 34.3078 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[False-False-False-False-True] 48.6500μs 27.6794μs 36.1279 KOps/s 35.4531 KOps/s $\color{#35bf28}+1.90\%$
test_step_mdp_speed[False-False-False-False-False] 45.6010μs 18.1419μs 55.1209 KOps/s 53.2055 KOps/s $\color{#35bf28}+3.60\%$
test_values[generalized_advantage_estimate-True-True] 27.2208ms 25.9834ms 38.4861 Ops/s 40.5378 Ops/s $\textbf{\color{#d91a1a}-5.06\%}$
test_values[vec_generalized_advantage_estimate-True-True] 84.4090ms 3.2608ms 306.6727 Ops/s 293.8334 Ops/s $\color{#35bf28}+4.37\%$
test_values[td0_return_estimate-False-False] 96.1510μs 65.8963μs 15.1754 KOps/s 15.4754 KOps/s $\color{#d91a1a}-1.94\%$
test_values[td1_return_estimate-False-False] 58.0524ms 53.2901ms 18.7652 Ops/s 18.8682 Ops/s $\color{#d91a1a}-0.55\%$
test_values[vec_td1_return_estimate-False-False] 2.0657ms 1.7706ms 564.7876 Ops/s 564.3743 Ops/s $\color{#35bf28}+0.07\%$
test_values[td_lambda_return_estimate-True-False] 92.5192ms 90.1533ms 11.0922 Ops/s 11.8441 Ops/s $\textbf{\color{#d91a1a}-6.35\%}$
test_values[vec_td_lambda_return_estimate-True-False] 2.1500ms 1.7694ms 565.1651 Ops/s 565.1614 Ops/s $+0.00\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.8567ms 25.4478ms 39.2961 Ops/s 42.8510 Ops/s $\textbf{\color{#d91a1a}-8.30\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8888ms 0.7091ms 1.4102 KOps/s 1.4077 KOps/s $\color{#35bf28}+0.18\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7119ms 0.6578ms 1.5202 KOps/s 1.5208 KOps/s $\color{#d91a1a}-0.04\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5292ms 1.4634ms 683.3450 Ops/s 685.0540 Ops/s $\color{#d91a1a}-0.25\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9445ms 0.6783ms 1.4742 KOps/s 1.4750 KOps/s $\color{#d91a1a}-0.05\%$
test_dqn_speed 1.6697ms 1.4227ms 702.8756 Ops/s 697.1884 Ops/s $\color{#35bf28}+0.82\%$
test_ddpg_speed 3.5812ms 2.7348ms 365.6606 Ops/s 361.9397 Ops/s $\color{#35bf28}+1.03\%$
test_sac_speed 10.7708ms 8.1073ms 123.3456 Ops/s 123.8031 Ops/s $\color{#d91a1a}-0.37\%$
test_redq_speed 11.1595ms 10.1896ms 98.1391 Ops/s 97.8053 Ops/s $\color{#35bf28}+0.34\%$
test_redq_deprec_speed 11.9438ms 11.1160ms 89.9602 Ops/s 88.2132 Ops/s $\color{#35bf28}+1.98\%$
test_td3_speed 15.7603ms 8.0384ms 124.4025 Ops/s 124.6078 Ops/s $\color{#d91a1a}-0.16\%$
test_cql_speed 26.3794ms 25.4583ms 39.2799 Ops/s 36.9733 Ops/s $\textbf{\color{#35bf28}+6.24\%}$
test_a2c_speed 5.8187ms 5.5912ms 178.8529 Ops/s 180.3236 Ops/s $\color{#d91a1a}-0.82\%$
test_ppo_speed 6.2601ms 5.9592ms 167.8086 Ops/s 171.4760 Ops/s $\color{#d91a1a}-2.14\%$
test_reinforce_speed 4.7092ms 4.5280ms 220.8500 Ops/s 222.4620 Ops/s $\color{#d91a1a}-0.72\%$
test_iql_speed 20.0262ms 19.5237ms 51.2198 Ops/s 51.8636 Ops/s $\color{#d91a1a}-1.24\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9745ms 2.8956ms 345.3561 Ops/s 342.4224 Ops/s $\color{#35bf28}+0.86\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1612ms 0.5405ms 1.8501 KOps/s 1.8411 KOps/s $\color{#35bf28}+0.48\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7187ms 0.5162ms 1.9372 KOps/s 1.9287 KOps/s $\color{#35bf28}+0.44\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0787ms 2.9151ms 343.0356 Ops/s 344.0256 Ops/s $\color{#d91a1a}-0.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1844ms 0.5292ms 1.8897 KOps/s 1.8749 KOps/s $\color{#35bf28}+0.79\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6639ms 0.5098ms 1.9614 KOps/s 1.9579 KOps/s $\color{#35bf28}+0.18\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 3.7852ms 1.4447ms 692.1904 Ops/s 694.3256 Ops/s $\color{#d91a1a}-0.31\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5540ms 1.3680ms 730.9937 Ops/s 725.4597 Ops/s $\color{#35bf28}+0.76\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1618ms 3.0057ms 332.6975 Ops/s 327.6336 Ops/s $\color{#35bf28}+1.55\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8626ms 0.6589ms 1.5177 KOps/s 1.4901 KOps/s $\color{#35bf28}+1.85\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1083s 0.7324ms 1.3653 KOps/s 1.5499 KOps/s $\textbf{\color{#d91a1a}-11.91\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9795ms 2.9106ms 343.5722 Ops/s 345.0908 Ops/s $\color{#d91a1a}-0.44\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6474ms 0.5379ms 1.8589 KOps/s 1.8412 KOps/s $\color{#35bf28}+0.96\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6806ms 0.5159ms 1.9382 KOps/s 1.9122 KOps/s $\color{#35bf28}+1.36\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1076ms 2.9181ms 342.6830 Ops/s 343.5003 Ops/s $\color{#d91a1a}-0.24\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1054s 0.6782ms 1.4744 KOps/s 1.8716 KOps/s $\textbf{\color{#d91a1a}-21.22\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7434ms 0.5105ms 1.9589 KOps/s 1.9456 KOps/s $\color{#35bf28}+0.68\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2320ms 3.0442ms 328.4969 Ops/s 329.5501 Ops/s $\color{#d91a1a}-0.32\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7749ms 0.6659ms 1.5018 KOps/s 1.4774 KOps/s $\color{#35bf28}+1.65\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.3784ms 0.6491ms 1.5407 KOps/s 1.5335 KOps/s $\color{#35bf28}+0.47\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1011s 8.6277ms 115.9059 Ops/s 115.1946 Ops/s $\color{#35bf28}+0.62\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.0956ms 14.6678ms 68.1766 Ops/s 68.6385 Ops/s $\color{#d91a1a}-0.67\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.1340ms 1.0674ms 936.8953 Ops/s 888.0116 Ops/s $\textbf{\color{#35bf28}+5.50\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1006s 6.7997ms 147.0663 Ops/s 150.4065 Ops/s $\color{#d91a1a}-2.22\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.2494ms 14.6343ms 68.3325 Ops/s 68.8630 Ops/s $\color{#d91a1a}-0.77\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.2217ms 1.0859ms 920.8932 Ops/s 880.3128 Ops/s $\color{#35bf28}+4.61\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1030s 9.1179ms 109.6745 Ops/s 110.8576 Ops/s $\color{#d91a1a}-1.07\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.6613ms 15.5558ms 64.2847 Ops/s 66.8823 Ops/s $\color{#d91a1a}-3.88\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.5434ms 1.4546ms 687.4706 Ops/s 690.4743 Ops/s $\color{#d91a1a}-0.44\%$

vmoens added a commit that referenced this pull request Apr 8, 2024
@vmoens
[BugFix] Fix jumanji (#2064)
e3e7fc1 
(cherry picked from commit cf685b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot