Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quality] Make sure deprec warnings are displayed #2088

Merged
merged 4 commits into from
Apr 18, 2024
Merged

[Quality] Make sure deprec warnings are displayed #2088

merged 4 commits into from
Apr 18, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 18, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2088

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 41e4f76 with merge base fc8ccd9 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
@vmoens
Copy link
Contributor Author

vmoens commented Apr 18, 2024

cc @matteobettini

vmoens
vmoens commented Apr 18, 2024
View reviewed changes
torchrl/__init__.py Outdated Show resolved Hide resolved
@vmoens vmoens added the quality code quality label Apr 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}16$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 52.8929ms 52.1448ms 19.1774 Ops/s 18.0320 Ops/s $\textbf{\color{#35bf28}+6.35\%}$
test_sync 44.9818ms 29.4047ms 34.0082 Ops/s 34.3766 Ops/s $\color{#d91a1a}-1.07\%$
test_async 48.9304ms 27.0120ms 37.0206 Ops/s 36.0119 Ops/s $\color{#35bf28}+2.80\%$
test_simple 0.3973s 0.3443s 2.9047 Ops/s 2.9156 Ops/s $\color{#d91a1a}-0.38\%$
test_transformed 0.5320s 0.4886s 2.0465 Ops/s 2.0044 Ops/s $\color{#35bf28}+2.10\%$
test_serial 1.2378s 1.1875s 0.8421 Ops/s 0.8277 Ops/s $\color{#35bf28}+1.74\%$
test_parallel 1.0408s 0.9924s 1.0077 Ops/s 0.9778 Ops/s $\color{#35bf28}+3.05\%$
test_step_mdp_speed[True-True-True-True-True] 0.1679ms 21.2518μs 47.0548 KOps/s 46.0416 KOps/s $\color{#35bf28}+2.20\%$
test_step_mdp_speed[True-True-True-True-False] 47.6600μs 13.0470μs 76.6461 KOps/s 73.8690 KOps/s $\color{#35bf28}+3.76\%$
test_step_mdp_speed[True-True-True-False-True] 48.1400μs 12.5060μs 79.9614 KOps/s 79.5550 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[True-True-True-False-False] 47.2880μs 7.5416μs 132.5973 KOps/s 126.3490 KOps/s $\color{#35bf28}+4.95\%$
test_step_mdp_speed[True-True-False-True-True] 54.6120μs 22.6008μs 44.2462 KOps/s 43.1860 KOps/s $\color{#35bf28}+2.45\%$
test_step_mdp_speed[True-True-False-True-False] 41.8880μs 14.3011μs 69.9248 KOps/s 67.0907 KOps/s $\color{#35bf28}+4.22\%$
test_step_mdp_speed[True-True-False-False-True] 38.3220μs 13.7263μs 72.8527 KOps/s 72.1748 KOps/s $\color{#35bf28}+0.94\%$
test_step_mdp_speed[True-True-False-False-False] 23.9850μs 8.8614μs 112.8496 KOps/s 109.9892 KOps/s $\color{#35bf28}+2.60\%$
test_step_mdp_speed[True-False-True-True-True] 56.8060μs 23.9541μs 41.7465 KOps/s 40.8156 KOps/s $\color{#35bf28}+2.28\%$
test_step_mdp_speed[True-False-True-True-False] 39.9550μs 15.7754μs 63.3897 KOps/s 60.9834 KOps/s $\color{#35bf28}+3.95\%$
test_step_mdp_speed[True-False-True-False-True] 45.4840μs 13.5948μs 73.5575 KOps/s 72.0270 KOps/s $\color{#35bf28}+2.12\%$
test_step_mdp_speed[True-False-True-False-False] 32.3210μs 8.8132μs 113.4656 KOps/s 109.2308 KOps/s $\color{#35bf28}+3.88\%$
test_step_mdp_speed[True-False-False-True-True] 54.4820μs 25.0025μs 39.9960 KOps/s 38.9496 KOps/s $\color{#35bf28}+2.69\%$
test_step_mdp_speed[True-False-False-True-False] 56.7260μs 16.6046μs 60.2244 KOps/s 57.0195 KOps/s $\textbf{\color{#35bf28}+5.62\%}$
test_step_mdp_speed[True-False-False-False-True] 33.7330μs 14.8176μs 67.4874 KOps/s 66.2157 KOps/s $\color{#35bf28}+1.92\%$
test_step_mdp_speed[True-False-False-False-False] 31.2490μs 10.0273μs 99.7273 KOps/s 96.1632 KOps/s $\color{#35bf28}+3.71\%$
test_step_mdp_speed[False-True-True-True-True] 75.4010μs 24.2834μs 41.1804 KOps/s 40.8857 KOps/s $\color{#35bf28}+0.72\%$
test_step_mdp_speed[False-True-True-True-False] 45.2340μs 15.5479μs 64.3174 KOps/s 61.6343 KOps/s $\color{#35bf28}+4.35\%$
test_step_mdp_speed[False-True-True-False-True] 40.6150μs 15.9765μs 62.5918 KOps/s 61.6490 KOps/s $\color{#35bf28}+1.53\%$
test_step_mdp_speed[False-True-True-False-False] 41.2270μs 10.0648μs 99.3560 KOps/s 96.4747 KOps/s $\color{#35bf28}+2.99\%$
test_step_mdp_speed[False-True-False-True-True] 47.8690μs 25.7391μs 38.8514 KOps/s 38.5121 KOps/s $\color{#35bf28}+0.88\%$
test_step_mdp_speed[False-True-False-True-False] 40.4250μs 16.8740μs 59.2629 KOps/s 56.9325 KOps/s $\color{#35bf28}+4.09\%$
test_step_mdp_speed[False-True-False-False-True] 0.1329ms 17.4060μs 57.4514 KOps/s 57.2283 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-True-False-False-False] 78.9880μs 11.2838μs 88.6228 KOps/s 86.4306 KOps/s $\color{#35bf28}+2.54\%$
test_step_mdp_speed[False-False-True-True-True] 53.8700μs 26.2632μs 38.0760 KOps/s 36.8530 KOps/s $\color{#35bf28}+3.32\%$
test_step_mdp_speed[False-False-True-True-False] 44.6740μs 18.0758μs 55.3227 KOps/s 53.2617 KOps/s $\color{#35bf28}+3.87\%$
test_step_mdp_speed[False-False-True-False-True] 42.5190μs 17.0589μs 58.6206 KOps/s 56.7799 KOps/s $\color{#35bf28}+3.24\%$
test_step_mdp_speed[False-False-True-False-False] 35.9180μs 11.3205μs 88.3353 KOps/s 85.9915 KOps/s $\color{#35bf28}+2.73\%$
test_step_mdp_speed[False-False-False-True-True] 0.2106ms 27.4844μs 36.3843 KOps/s 35.1746 KOps/s $\color{#35bf28}+3.44\%$
test_step_mdp_speed[False-False-False-True-False] 95.4480μs 19.1830μs 52.1294 KOps/s 50.1607 KOps/s $\color{#35bf28}+3.92\%$
test_step_mdp_speed[False-False-False-False-True] 48.5810μs 18.0229μs 55.4850 KOps/s 54.4683 KOps/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[False-False-False-False-False] 35.8370μs 12.3375μs 81.0535 KOps/s 78.7759 KOps/s $\color{#35bf28}+2.89\%$
test_values[generalized_advantage_estimate-True-True] 11.4476ms 9.2258ms 108.3915 Ops/s 106.3411 Ops/s $\color{#35bf28}+1.93\%$
test_values[vec_generalized_advantage_estimate-True-True] 35.1886ms 33.1617ms 30.1553 Ops/s 28.4997 Ops/s $\textbf{\color{#35bf28}+5.81\%}$
test_values[td0_return_estimate-False-False] 0.2362ms 0.1646ms 6.0749 KOps/s 5.5948 KOps/s $\textbf{\color{#35bf28}+8.58\%}$
test_values[td1_return_estimate-False-False] 23.1872ms 22.7293ms 43.9961 Ops/s 41.8657 Ops/s $\textbf{\color{#35bf28}+5.09\%}$
test_values[vec_td1_return_estimate-False-False] 34.9818ms 33.3312ms 30.0020 Ops/s 28.3216 Ops/s $\textbf{\color{#35bf28}+5.93\%}$
test_values[td_lambda_return_estimate-True-False] 34.5849ms 33.0269ms 30.2783 Ops/s 29.4541 Ops/s $\color{#35bf28}+2.80\%$
test_values[vec_td_lambda_return_estimate-True-False] 34.9421ms 33.0862ms 30.2241 Ops/s 28.1794 Ops/s $\textbf{\color{#35bf28}+7.26\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.2759ms 8.0758ms 123.8262 Ops/s 118.4654 Ops/s $\color{#35bf28}+4.53\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.1996ms 1.9647ms 508.9771 Ops/s 493.2812 Ops/s $\color{#35bf28}+3.18\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5352ms 0.3427ms 2.9177 KOps/s 2.8476 KOps/s $\color{#35bf28}+2.46\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 42.7662ms 41.1795ms 24.2839 Ops/s 21.9168 Ops/s $\textbf{\color{#35bf28}+10.80\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.9064ms 3.1342ms 319.0653 Ops/s 327.9159 Ops/s $\color{#d91a1a}-2.70\%$
test_dqn_speed 7.0679ms 1.3231ms 755.7965 Ops/s 729.2424 Ops/s $\color{#35bf28}+3.64\%$
test_ddpg_speed 4.5093ms 2.7154ms 368.2652 Ops/s 367.3230 Ops/s $\color{#35bf28}+0.26\%$
test_sac_speed 9.4133ms 8.0288ms 124.5512 Ops/s 118.5170 Ops/s $\textbf{\color{#35bf28}+5.09\%}$
test_redq_speed 14.8226ms 12.8052ms 78.0934 Ops/s 74.4299 Ops/s $\color{#35bf28}+4.92\%$
test_redq_deprec_speed 14.8657ms 12.8264ms 77.9644 Ops/s 72.5629 Ops/s $\textbf{\color{#35bf28}+7.44\%}$
test_td3_speed 15.6191ms 8.0102ms 124.8412 Ops/s 119.2559 Ops/s $\color{#35bf28}+4.68\%$
test_cql_speed 36.6874ms 35.4981ms 28.1705 Ops/s 26.7015 Ops/s $\textbf{\color{#35bf28}+5.50\%}$
test_a2c_speed 7.9324ms 7.2814ms 137.3370 Ops/s 125.4884 Ops/s $\textbf{\color{#35bf28}+9.44\%}$
test_ppo_speed 8.8381ms 7.5035ms 133.2716 Ops/s 124.1339 Ops/s $\textbf{\color{#35bf28}+7.36\%}$
test_reinforce_speed 7.3077ms 6.4648ms 154.6836 Ops/s 149.3429 Ops/s $\color{#35bf28}+3.58\%$
test_iql_speed 33.3106ms 31.9428ms 31.3060 Ops/s 30.2853 Ops/s $\color{#35bf28}+3.37\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6938ms 2.2400ms 446.4364 Ops/s 439.5315 Ops/s $\color{#35bf28}+1.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 85.2405ms 0.5428ms 1.8424 KOps/s 2.0051 KOps/s $\textbf{\color{#d91a1a}-8.11\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8445ms 0.4630ms 2.1596 KOps/s 2.0950 KOps/s $\color{#35bf28}+3.08\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4913ms 2.1301ms 469.4645 Ops/s 426.2562 Ops/s $\textbf{\color{#35bf28}+10.14\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0385ms 0.4777ms 2.0936 KOps/s 2.0391 KOps/s $\color{#35bf28}+2.67\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7118ms 0.4513ms 2.2157 KOps/s 2.1064 KOps/s $\textbf{\color{#35bf28}+5.19\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6356ms 1.2092ms 826.9659 Ops/s 804.0982 Ops/s $\color{#35bf28}+2.84\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6634ms 1.1429ms 874.9581 Ops/s 850.9640 Ops/s $\color{#35bf28}+2.82\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.7837ms 2.3933ms 417.8315 Ops/s 406.2495 Ops/s $\color{#35bf28}+2.85\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0780ms 0.6043ms 1.6549 KOps/s 1.6175 KOps/s $\color{#35bf28}+2.31\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8999ms 0.5793ms 1.7261 KOps/s 1.6976 KOps/s $\color{#35bf28}+1.68\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6675ms 2.3903ms 418.3531 Ops/s 434.7520 Ops/s $\color{#d91a1a}-3.77\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0643ms 0.5031ms 1.9879 KOps/s 1.9832 KOps/s $\color{#35bf28}+0.23\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7027ms 0.4759ms 2.1014 KOps/s 2.1307 KOps/s $\color{#d91a1a}-1.37\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3845ms 2.4273ms 411.9794 Ops/s 450.7557 Ops/s $\textbf{\color{#d91a1a}-8.60\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7992ms 0.4991ms 2.0037 KOps/s 2.0534 KOps/s $\color{#d91a1a}-2.42\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.6446ms 0.4730ms 2.1142 KOps/s 2.1308 KOps/s $\color{#d91a1a}-0.78\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.6665ms 2.4916ms 401.3530 Ops/s 428.0554 Ops/s $\textbf{\color{#d91a1a}-6.24\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.6953ms 0.6040ms 1.6556 KOps/s 1.6480 KOps/s $\color{#35bf28}+0.46\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8357ms 0.5816ms 1.7194 KOps/s 1.7136 KOps/s $\color{#35bf28}+0.34\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1088s 7.6363ms 130.9543 Ops/s 132.1087 Ops/s $\color{#d91a1a}-0.87\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.0563ms 12.0939ms 82.6861 Ops/s 82.7113 Ops/s $\color{#d91a1a}-0.03\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.6475ms 1.0816ms 924.5773 Ops/s 965.8419 Ops/s $\color{#d91a1a}-4.27\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1026s 5.5963ms 178.6885 Ops/s 173.6429 Ops/s $\color{#35bf28}+2.91\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 13.7781ms 11.8848ms 84.1408 Ops/s 82.2325 Ops/s $\color{#35bf28}+2.32\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.5711ms 1.0401ms 961.4022 Ops/s 972.9129 Ops/s $\color{#d91a1a}-1.18\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 97.0500ms 7.6047ms 131.4979 Ops/s 123.5927 Ops/s $\textbf{\color{#35bf28}+6.40\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.5158ms 12.2931ms 81.3462 Ops/s 80.4809 Ops/s $\color{#35bf28}+1.08\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.0862ms 1.4172ms 705.5948 Ops/s 708.9242 Ops/s $\color{#d91a1a}-0.47\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1002s 99.2020ms 10.0804 Ops/s 9.4115 Ops/s $\textbf{\color{#35bf28}+7.11\%}$
test_sync 90.3768ms 87.9407ms 11.3713 Ops/s 11.3969 Ops/s $\color{#d91a1a}-0.22\%$
test_async 0.1606s 69.9854ms 14.2887 Ops/s 14.0117 Ops/s $\color{#35bf28}+1.98\%$
test_single_pixels 0.1099s 0.1096s 9.1223 Ops/s 9.0831 Ops/s $\color{#35bf28}+0.43\%$
test_sync_pixels 68.3696ms 66.2397ms 15.0967 Ops/s 15.0106 Ops/s $\color{#35bf28}+0.57\%$
test_async_pixels 0.1184s 56.0686ms 17.8353 Ops/s 17.7675 Ops/s $\color{#35bf28}+0.38\%$
test_simple 0.6623s 0.6614s 1.5119 Ops/s 1.4754 Ops/s $\color{#35bf28}+2.47\%$
test_transformed 0.8801s 0.8797s 1.1368 Ops/s 1.1169 Ops/s $\color{#35bf28}+1.78\%$
test_serial 2.1250s 2.0660s 0.4840 Ops/s 0.4851 Ops/s $\color{#d91a1a}-0.22\%$
test_parallel 1.8553s 1.7969s 0.5565 Ops/s 0.5644 Ops/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[True-True-True-True-True] 84.1320μs 32.0862μs 31.1661 KOps/s 31.0265 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[True-True-True-True-False] 0.2510ms 19.2733μs 51.8852 KOps/s 50.9897 KOps/s $\color{#35bf28}+1.76\%$
test_step_mdp_speed[True-True-True-False-True] 0.2156ms 18.7892μs 53.2221 KOps/s 54.6848 KOps/s $\color{#d91a1a}-2.67\%$
test_step_mdp_speed[True-True-True-False-False] 29.9510μs 10.9636μs 91.2106 KOps/s 89.1571 KOps/s $\color{#35bf28}+2.30\%$
test_step_mdp_speed[True-True-False-True-True] 0.2371ms 34.3601μs 29.1035 KOps/s 28.9479 KOps/s $\color{#35bf28}+0.54\%$
test_step_mdp_speed[True-True-False-True-False] 0.2449ms 21.2071μs 47.1540 KOps/s 46.6114 KOps/s $\color{#35bf28}+1.16\%$
test_step_mdp_speed[True-True-False-False-True] 0.2323ms 20.5524μs 48.6561 KOps/s 49.0864 KOps/s $\color{#d91a1a}-0.88\%$
test_step_mdp_speed[True-True-False-False-False] 0.1300ms 12.8405μs 77.8785 KOps/s 76.5714 KOps/s $\color{#35bf28}+1.71\%$
test_step_mdp_speed[True-False-True-True-True] 0.3269ms 35.9431μs 27.8217 KOps/s 27.7203 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[True-False-True-True-False] 0.2288ms 23.3421μs 42.8411 KOps/s 42.8448 KOps/s $-0.01\%$
test_step_mdp_speed[True-False-True-False-True] 42.0010μs 20.4988μs 48.7834 KOps/s 49.3987 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[True-False-True-False-False] 0.2169ms 13.0379μs 76.6993 KOps/s 77.3356 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[True-False-False-True-True] 0.2546ms 38.6259μs 25.8894 KOps/s 26.4732 KOps/s $\color{#d91a1a}-2.21\%$
test_step_mdp_speed[True-False-False-True-False] 45.2310μs 24.7964μs 40.3284 KOps/s 39.8141 KOps/s $\color{#35bf28}+1.29\%$
test_step_mdp_speed[True-False-False-False-True] 0.2414ms 21.8179μs 45.8340 KOps/s 45.3674 KOps/s $\color{#35bf28}+1.03\%$
test_step_mdp_speed[True-False-False-False-False] 0.2123ms 14.7221μs 67.9251 KOps/s 67.2207 KOps/s $\color{#35bf28}+1.05\%$
test_step_mdp_speed[False-True-True-True-True] 0.2450ms 36.9182μs 27.0869 KOps/s 27.4538 KOps/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[False-True-True-True-False] 50.7720μs 23.0185μs 43.4433 KOps/s 42.1446 KOps/s $\color{#35bf28}+3.08\%$
test_step_mdp_speed[False-True-True-False-True] 0.2097ms 24.4167μs 40.9556 KOps/s 41.9799 KOps/s $\color{#d91a1a}-2.44\%$
test_step_mdp_speed[False-True-True-False-False] 0.2430ms 15.0034μs 66.6516 KOps/s 66.8687 KOps/s $\color{#d91a1a}-0.32\%$
test_step_mdp_speed[False-True-False-True-True] 0.2170ms 37.9684μs 26.3377 KOps/s 26.5829 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[False-True-False-True-False] 0.2589ms 25.2886μs 39.5435 KOps/s 39.5409 KOps/s $+0.01\%$
test_step_mdp_speed[False-True-False-False-True] 0.5617ms 26.3758μs 37.9135 KOps/s 38.7655 KOps/s $\color{#d91a1a}-2.20\%$
test_step_mdp_speed[False-True-False-False-False] 46.9310μs 16.9469μs 59.0080 KOps/s 59.8419 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[False-False-True-True-True] 0.2456ms 39.6698μs 25.2081 KOps/s 25.0855 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[False-False-True-True-False] 0.2174ms 27.1504μs 36.8318 KOps/s 36.6086 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[False-False-True-False-True] 0.2180ms 26.1607μs 38.2252 KOps/s 38.4922 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-False-True-False-False] 0.2034ms 16.6814μs 59.9469 KOps/s 59.9349 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[False-False-False-True-True] 0.1672ms 41.1871μs 24.2794 KOps/s 24.0814 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[False-False-False-True-False] 0.2205ms 28.8300μs 34.6861 KOps/s 34.5409 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[False-False-False-False-True] 0.2403ms 28.0207μs 35.6879 KOps/s 36.4472 KOps/s $\color{#d91a1a}-2.08\%$
test_step_mdp_speed[False-False-False-False-False] 0.2160ms 18.3748μs 54.4225 KOps/s 54.2191 KOps/s $\color{#35bf28}+0.38\%$
test_values[generalized_advantage_estimate-True-True] 25.2852ms 24.6984ms 40.4884 Ops/s 39.9639 Ops/s $\color{#35bf28}+1.31\%$
test_values[vec_generalized_advantage_estimate-True-True] 83.4519ms 3.2319ms 309.4116 Ops/s 309.3699 Ops/s $\color{#35bf28}+0.01\%$
test_values[td0_return_estimate-False-False] 92.6320μs 64.5586μs 15.4898 KOps/s 15.5622 KOps/s $\color{#d91a1a}-0.47\%$
test_values[td1_return_estimate-False-False] 53.2528ms 52.6489ms 18.9937 Ops/s 18.9562 Ops/s $\color{#35bf28}+0.20\%$
test_values[vec_td1_return_estimate-False-False] 2.0116ms 1.7566ms 569.2866 Ops/s 569.5201 Ops/s $\color{#d91a1a}-0.04\%$
test_values[td_lambda_return_estimate-True-False] 83.8335ms 83.3995ms 11.9905 Ops/s 11.8815 Ops/s $\color{#35bf28}+0.92\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.1890ms 1.7586ms 568.6318 Ops/s 569.3552 Ops/s $\color{#d91a1a}-0.13\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.7722ms 23.3159ms 42.8891 Ops/s 43.4027 Ops/s $\color{#d91a1a}-1.18\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8972ms 0.6918ms 1.4455 KOps/s 1.4348 KOps/s $\color{#35bf28}+0.75\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6958ms 0.6445ms 1.5515 KOps/s 1.5565 KOps/s $\color{#d91a1a}-0.32\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.6073ms 1.4489ms 690.1811 Ops/s 692.0616 Ops/s $\color{#d91a1a}-0.27\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9376ms 0.6702ms 1.4920 KOps/s 1.5068 KOps/s $\color{#d91a1a}-0.98\%$
test_dqn_speed 2.1161ms 1.4439ms 692.5579 Ops/s 692.2523 Ops/s $\color{#35bf28}+0.04\%$
test_ddpg_speed 3.0572ms 2.7585ms 362.5213 Ops/s 364.6754 Ops/s $\color{#d91a1a}-0.59\%$
test_sac_speed 8.8554ms 8.0961ms 123.5158 Ops/s 112.4458 Ops/s $\textbf{\color{#35bf28}+9.84\%}$
test_redq_speed 12.9903ms 10.5355ms 94.9170 Ops/s 94.5741 Ops/s $\color{#35bf28}+0.36\%$
test_redq_deprec_speed 12.6992ms 11.5951ms 86.2435 Ops/s 90.1263 Ops/s $\color{#d91a1a}-4.31\%$
test_td3_speed 17.2278ms 8.0743ms 123.8500 Ops/s 123.9873 Ops/s $\color{#d91a1a}-0.11\%$
test_cql_speed 27.1105ms 25.7192ms 38.8815 Ops/s 38.8528 Ops/s $\color{#35bf28}+0.07\%$
test_a2c_speed 6.1658ms 5.8084ms 172.1654 Ops/s 182.2078 Ops/s $\textbf{\color{#d91a1a}-5.51\%}$
test_ppo_speed 6.4385ms 6.0951ms 164.0658 Ops/s 170.5343 Ops/s $\color{#d91a1a}-3.79\%$
test_reinforce_speed 5.0871ms 4.7743ms 209.4566 Ops/s 218.5646 Ops/s $\color{#d91a1a}-4.17\%$
test_iql_speed 20.7796ms 20.0130ms 49.9674 Ops/s 50.7459 Ops/s $\color{#d91a1a}-1.53\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1960ms 2.9444ms 339.6279 Ops/s 340.4484 Ops/s $\color{#d91a1a}-0.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9007ms 0.5498ms 1.8188 KOps/s 1.8345 KOps/s $\color{#d91a1a}-0.85\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.3215ms 0.5284ms 1.8925 KOps/s 1.9001 KOps/s $\color{#d91a1a}-0.40\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.2623ms 3.0040ms 332.8882 Ops/s 338.3016 Ops/s $\color{#d91a1a}-1.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8528ms 0.5378ms 1.8594 KOps/s 1.8717 KOps/s $\color{#d91a1a}-0.65\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.4402ms 0.5234ms 1.9106 KOps/s 1.9166 KOps/s $\color{#d91a1a}-0.31\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6858ms 1.4449ms 692.0710 Ops/s 681.7491 Ops/s $\color{#35bf28}+1.51\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 5.1060ms 1.3891ms 719.9012 Ops/s 720.2036 Ops/s $\color{#d91a1a}-0.04\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.4008ms 3.0871ms 323.9305 Ops/s 328.4341 Ops/s $\color{#d91a1a}-1.37\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1199s 0.7609ms 1.3142 KOps/s 1.4960 KOps/s $\textbf{\color{#d91a1a}-12.15\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9705ms 0.6477ms 1.5440 KOps/s 1.5448 KOps/s $\color{#d91a1a}-0.05\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1655ms 2.9757ms 336.0584 Ops/s 340.7576 Ops/s $\color{#d91a1a}-1.38\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.2687ms 0.5420ms 1.8451 KOps/s 1.8295 KOps/s $\color{#35bf28}+0.86\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8061ms 0.5238ms 1.9093 KOps/s 1.8800 KOps/s $\color{#35bf28}+1.56\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.2436ms 2.9692ms 336.7861 Ops/s 338.5710 Ops/s $\color{#d91a1a}-0.53\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8618ms 0.5358ms 1.8664 KOps/s 1.8271 KOps/s $\color{#35bf28}+2.15\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.5308ms 0.5214ms 1.9178 KOps/s 1.9169 KOps/s $\color{#35bf28}+0.05\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3623ms 3.1326ms 319.2211 Ops/s 327.2104 Ops/s $\color{#d91a1a}-2.44\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8991ms 0.6658ms 1.5020 KOps/s 1.4833 KOps/s $\color{#35bf28}+1.26\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0133ms 0.6448ms 1.5508 KOps/s 1.5302 KOps/s $\color{#35bf28}+1.35\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1415s 7.5855ms 131.8300 Ops/s 100.8639 Ops/s $\textbf{\color{#35bf28}+30.70\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.0038ms 14.5219ms 68.8615 Ops/s 67.6737 Ops/s $\color{#35bf28}+1.76\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.1738ms 1.0841ms 922.4028 Ops/s 923.4409 Ops/s $\color{#d91a1a}-0.11\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1236s 9.5747ms 104.4415 Ops/s 138.5678 Ops/s $\textbf{\color{#d91a1a}-24.63\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.9341ms 14.5272ms 68.8365 Ops/s 67.9001 Ops/s $\color{#35bf28}+1.38\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.4819ms 1.2236ms 817.2699 Ops/s 889.7785 Ops/s $\textbf{\color{#d91a1a}-8.15\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1252s 7.6073ms 131.4522 Ops/s 133.0771 Ops/s $\color{#d91a1a}-1.22\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.8671ms 14.7646ms 67.7295 Ops/s 66.5238 Ops/s $\color{#35bf28}+1.81\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.7029ms 1.6654ms 600.4412 Ops/s 687.7971 Ops/s $\textbf{\color{#d91a1a}-12.70\%}$

@vmoens vmoens merged commit ee8cafb into main Apr 18, 2024
64 of 68 checks passed
@vmoens vmoens deleted the deprec-warnings-on branch April 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot