Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Make DMControlEnv aware of truncated signals #2196

Merged
merged 2 commits into from
Jun 3, 2024
Merged

[BugFix] Make DMControlEnv aware of truncated signals #2196

merged 2 commits into from
Jun 3, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 3, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2196

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 14 Unrelated Failures

As of commit 2b686b3 with merge base 8d99026 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2024
@vmoens vmoens added the bug Something isn't working label Jun 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}10$. Worsened: $\large\color{#d91a1a}17$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1054s 59.3457ms 16.8504 Ops/s 17.6620 Ops/s $\color{#d91a1a}-4.60\%$
test_sync 30.4441ms 30.0442ms 33.2842 Ops/s 27.6330 Ops/s $\textbf{\color{#35bf28}+20.45\%}$
test_async 57.0288ms 29.3666ms 34.0522 Ops/s 36.3065 Ops/s $\textbf{\color{#d91a1a}-6.21\%}$
test_simple 0.4460s 0.3944s 2.5356 Ops/s 2.6803 Ops/s $\textbf{\color{#d91a1a}-5.40\%}$
test_transformed 0.5418s 0.5395s 1.8537 Ops/s 1.9071 Ops/s $\color{#d91a1a}-2.80\%$
test_serial 1.3257s 1.2793s 0.7817 Ops/s 0.7891 Ops/s $\color{#d91a1a}-0.94\%$
test_parallel 1.1202s 1.0591s 0.9442 Ops/s 0.9413 Ops/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[True-True-True-True-True] 0.1360ms 23.0729μs 43.3409 KOps/s 45.3709 KOps/s $\color{#d91a1a}-4.47\%$
test_step_mdp_speed[True-True-True-True-False] 53.8300μs 14.2525μs 70.1632 KOps/s 72.7578 KOps/s $\color{#d91a1a}-3.57\%$
test_step_mdp_speed[True-True-True-False-True] 31.9800μs 13.6281μs 73.3779 KOps/s 75.6933 KOps/s $\color{#d91a1a}-3.06\%$
test_step_mdp_speed[True-True-True-False-False] 0.1519ms 9.0732μs 110.2148 KOps/s 124.8194 KOps/s $\textbf{\color{#d91a1a}-11.70\%}$
test_step_mdp_speed[True-True-False-True-True] 67.5960μs 24.5788μs 40.6854 KOps/s 42.3057 KOps/s $\color{#d91a1a}-3.83\%$
test_step_mdp_speed[True-True-False-True-False] 41.8090μs 15.6621μs 63.8482 KOps/s 67.8511 KOps/s $\textbf{\color{#d91a1a}-5.90\%}$
test_step_mdp_speed[True-True-False-False-True] 35.6160μs 14.9362μs 66.9514 KOps/s 69.1679 KOps/s $\color{#d91a1a}-3.20\%$
test_step_mdp_speed[True-True-False-False-False] 39.9640μs 9.8023μs 102.0173 KOps/s 107.4536 KOps/s $\textbf{\color{#d91a1a}-5.06\%}$
test_step_mdp_speed[True-False-True-True-True] 55.6640μs 26.0927μs 38.3250 KOps/s 39.8780 KOps/s $\color{#d91a1a}-3.89\%$
test_step_mdp_speed[True-False-True-True-False] 35.5460μs 17.0924μs 58.5054 KOps/s 61.4416 KOps/s $\color{#d91a1a}-4.78\%$
test_step_mdp_speed[True-False-True-False-True] 34.8850μs 14.9959μs 66.6849 KOps/s 69.1513 KOps/s $\color{#d91a1a}-3.57\%$
test_step_mdp_speed[True-False-True-False-False] 0.1839ms 10.1485μs 98.5367 KOps/s 107.6169 KOps/s $\textbf{\color{#d91a1a}-8.44\%}$
test_step_mdp_speed[True-False-False-True-True] 0.2243ms 28.3116μs 35.3212 KOps/s 38.0538 KOps/s $\textbf{\color{#d91a1a}-7.18\%}$
test_step_mdp_speed[True-False-False-True-False] 0.3038ms 18.3111μs 54.6117 KOps/s 56.9669 KOps/s $\color{#d91a1a}-4.13\%$
test_step_mdp_speed[True-False-False-False-True] 42.4200μs 16.1695μs 61.8447 KOps/s 64.1154 KOps/s $\color{#d91a1a}-3.54\%$
test_step_mdp_speed[True-False-False-False-False] 24.0540μs 11.0282μs 90.6769 KOps/s 94.4128 KOps/s $\color{#d91a1a}-3.96\%$
test_step_mdp_speed[False-True-True-True-True] 63.9890μs 26.2923μs 38.0340 KOps/s 40.1428 KOps/s $\textbf{\color{#d91a1a}-5.25\%}$
test_step_mdp_speed[False-True-True-True-False] 38.6120μs 17.0710μs 58.5789 KOps/s 61.6380 KOps/s $\color{#d91a1a}-4.96\%$
test_step_mdp_speed[False-True-True-False-True] 45.1540μs 17.1991μs 58.1426 KOps/s 59.8219 KOps/s $\color{#d91a1a}-2.81\%$
test_step_mdp_speed[False-True-True-False-False] 34.1940μs 11.0325μs 90.6414 KOps/s 95.4398 KOps/s $\textbf{\color{#d91a1a}-5.03\%}$
test_step_mdp_speed[False-True-False-True-True] 54.3310μs 27.1390μs 36.8473 KOps/s 38.1373 KOps/s $\color{#d91a1a}-3.38\%$
test_step_mdp_speed[False-True-False-True-False] 0.1422ms 18.4668μs 54.1512 KOps/s 57.2828 KOps/s $\textbf{\color{#d91a1a}-5.47\%}$
test_step_mdp_speed[False-True-False-False-True] 72.4550μs 18.4757μs 54.1251 KOps/s 55.7965 KOps/s $\color{#d91a1a}-3.00\%$
test_step_mdp_speed[False-True-False-False-False] 33.3330μs 12.1720μs 82.1556 KOps/s 86.0219 KOps/s $\color{#d91a1a}-4.49\%$
test_step_mdp_speed[False-False-True-True-True] 69.7500μs 28.3141μs 35.3181 KOps/s 36.1964 KOps/s $\color{#d91a1a}-2.43\%$
test_step_mdp_speed[False-False-True-True-False] 47.2590μs 19.6848μs 50.8006 KOps/s 53.4205 KOps/s $\color{#d91a1a}-4.90\%$
test_step_mdp_speed[False-False-True-False-True] 41.3670μs 18.3345μs 54.5419 KOps/s 55.4654 KOps/s $\color{#d91a1a}-1.66\%$
test_step_mdp_speed[False-False-True-False-False] 0.1049ms 12.2280μs 81.7798 KOps/s 85.3009 KOps/s $\color{#d91a1a}-4.13\%$
test_step_mdp_speed[False-False-False-True-True] 88.8760μs 29.9860μs 33.3489 KOps/s 34.6937 KOps/s $\color{#d91a1a}-3.88\%$
test_step_mdp_speed[False-False-False-True-False] 0.1742ms 21.6340μs 46.2235 KOps/s 50.4722 KOps/s $\textbf{\color{#d91a1a}-8.42\%}$
test_step_mdp_speed[False-False-False-False-True] 42.6390μs 19.5529μs 51.1434 KOps/s 52.5531 KOps/s $\color{#d91a1a}-2.68\%$
test_step_mdp_speed[False-False-False-False-False] 38.3010μs 13.3306μs 75.0154 KOps/s 78.0756 KOps/s $\color{#d91a1a}-3.92\%$
test_values[generalized_advantage_estimate-True-True] 9.4522ms 9.1646ms 109.1151 Ops/s 106.6013 Ops/s $\color{#35bf28}+2.36\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.3172ms 35.2750ms 28.3487 Ops/s 30.1646 Ops/s $\textbf{\color{#d91a1a}-6.02\%}$
test_values[td0_return_estimate-False-False] 0.2328ms 0.1638ms 6.1033 KOps/s 6.1093 KOps/s $\color{#d91a1a}-0.10\%$
test_values[td1_return_estimate-False-False] 23.2399ms 22.9963ms 43.4853 Ops/s 43.2871 Ops/s $\color{#35bf28}+0.46\%$
test_values[vec_td1_return_estimate-False-False] 39.8160ms 35.4138ms 28.2376 Ops/s 29.7911 Ops/s $\textbf{\color{#d91a1a}-5.21\%}$
test_values[td_lambda_return_estimate-True-False] 33.8950ms 33.1690ms 30.1486 Ops/s 30.2755 Ops/s $\color{#d91a1a}-0.42\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.6013ms 35.3484ms 28.2898 Ops/s 29.9415 Ops/s $\textbf{\color{#d91a1a}-5.52\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.1086ms 8.1636ms 122.4954 Ops/s 115.9597 Ops/s $\textbf{\color{#35bf28}+5.64\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2667ms 1.9945ms 501.3893 Ops/s 536.2394 Ops/s $\textbf{\color{#d91a1a}-6.50\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4250ms 0.3531ms 2.8318 KOps/s 2.9049 KOps/s $\color{#d91a1a}-2.52\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 55.9024ms 45.9604ms 21.7579 Ops/s 22.4838 Ops/s $\color{#d91a1a}-3.23\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.8248ms 3.0299ms 330.0442 Ops/s 330.5768 Ops/s $\color{#d91a1a}-0.16\%$
test_dqn_speed 1.5292ms 1.3755ms 727.0178 Ops/s 728.2824 Ops/s $\color{#d91a1a}-0.17\%$
test_ddpg_speed 3.3018ms 2.9106ms 343.5765 Ops/s 348.7962 Ops/s $\color{#d91a1a}-1.50\%$
test_sac_speed 9.4338ms 8.6197ms 116.0137 Ops/s 118.0214 Ops/s $\color{#d91a1a}-1.70\%$
test_redq_speed 13.7506ms 13.1662ms 75.9520 Ops/s 75.9531 Ops/s $-0.00\%$
test_redq_deprec_speed 15.2444ms 13.4027ms 74.6119 Ops/s 74.7153 Ops/s $\color{#d91a1a}-0.14\%$
test_td3_speed 16.2681ms 8.4872ms 117.8245 Ops/s 118.0991 Ops/s $\color{#d91a1a}-0.23\%$
test_cql_speed 38.3288ms 36.7312ms 27.2248 Ops/s 27.4077 Ops/s $\color{#d91a1a}-0.67\%$
test_a2c_speed 8.0433ms 7.4730ms 133.8143 Ops/s 134.4877 Ops/s $\color{#d91a1a}-0.50\%$
test_ppo_speed 9.1947ms 7.7657ms 128.7715 Ops/s 121.0652 Ops/s $\textbf{\color{#35bf28}+6.37\%}$
test_reinforce_speed 7.4472ms 6.6509ms 150.3567 Ops/s 149.3528 Ops/s $\color{#35bf28}+0.67\%$
test_iql_speed 34.2361ms 32.7709ms 30.5148 Ops/s 30.5579 Ops/s $\color{#d91a1a}-0.14\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.8855ms 3.6496ms 274.0018 Ops/s 279.9209 Ops/s $\color{#d91a1a}-2.11\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9909ms 0.4996ms 2.0015 KOps/s 1.9031 KOps/s $\textbf{\color{#35bf28}+5.17\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7144ms 0.4735ms 2.1120 KOps/s 2.1174 KOps/s $\color{#d91a1a}-0.25\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.0757ms 3.3959ms 294.4684 Ops/s 297.3981 Ops/s $\color{#d91a1a}-0.99\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0316ms 0.4951ms 2.0198 KOps/s 2.0313 KOps/s $\color{#d91a1a}-0.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6309ms 0.4664ms 2.1442 KOps/s 2.1466 KOps/s $\color{#d91a1a}-0.11\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.8479ms 1.2559ms 796.2102 Ops/s 810.3740 Ops/s $\color{#d91a1a}-1.75\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.9519ms 1.1914ms 839.3612 Ops/s 857.7824 Ops/s $\color{#d91a1a}-2.15\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.7438ms 3.6688ms 272.5720 Ops/s 280.5540 Ops/s $\color{#d91a1a}-2.85\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0995ms 0.6156ms 1.6244 KOps/s 1.6161 KOps/s $\color{#35bf28}+0.51\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7295ms 0.5867ms 1.7044 KOps/s 1.4170 KOps/s $\textbf{\color{#35bf28}+20.28\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.5466ms 3.4107ms 293.1935 Ops/s 279.5061 Ops/s $\color{#35bf28}+4.90\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9944ms 0.5022ms 1.9912 KOps/s 1.9568 KOps/s $\color{#35bf28}+1.76\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6166ms 0.4740ms 2.1096 KOps/s 2.0539 KOps/s $\color{#35bf28}+2.71\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.1975ms 3.4160ms 292.7433 Ops/s 274.1269 Ops/s $\textbf{\color{#35bf28}+6.79\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8085ms 0.4957ms 2.0173 KOps/s 1.5479 KOps/s $\textbf{\color{#35bf28}+30.33\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.5696ms 0.4739ms 2.1102 KOps/s 2.0747 KOps/s $\color{#35bf28}+1.71\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.9348ms 3.6114ms 276.8990 Ops/s 267.2427 Ops/s $\color{#35bf28}+3.61\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1673ms 0.6231ms 1.6049 KOps/s 1.6074 KOps/s $\color{#d91a1a}-0.16\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6711ms 0.5896ms 1.6959 KOps/s 1.6605 KOps/s $\color{#35bf28}+2.13\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1083s 5.7428ms 174.1297 Ops/s 120.4392 Ops/s $\textbf{\color{#35bf28}+44.58\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.0728ms 12.6370ms 79.1324 Ops/s 79.2940 Ops/s $\color{#d91a1a}-0.20\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.2065ms 1.0647ms 939.2701 Ops/s 906.6172 Ops/s $\color{#35bf28}+3.60\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1031s 7.5683ms 132.1296 Ops/s 165.8054 Ops/s $\textbf{\color{#d91a1a}-20.31\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.1150ms 12.5741ms 79.5288 Ops/s 79.3584 Ops/s $\color{#35bf28}+0.21\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.2119ms 1.0576ms 945.5055 Ops/s 848.2244 Ops/s $\textbf{\color{#35bf28}+11.47\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1013s 5.9523ms 168.0027 Ops/s 126.0251 Ops/s $\textbf{\color{#35bf28}+33.31\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1096s 14.8196ms 67.4780 Ops/s 79.2670 Ops/s $\textbf{\color{#d91a1a}-14.87\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.9109ms 1.3973ms 715.6794 Ops/s 714.2471 Ops/s $\color{#35bf28}+0.20\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}11$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1153s 0.1152s 8.6827 Ops/s 8.4236 Ops/s $\color{#35bf28}+3.08\%$
test_sync 0.1045s 0.1030s 9.7050 Ops/s 9.8833 Ops/s $\color{#d91a1a}-1.80\%$
test_async 0.1931s 77.6361ms 12.8806 Ops/s 10.6751 Ops/s $\textbf{\color{#35bf28}+20.66\%}$
test_single_pixels 0.1269s 0.1265s 7.9039 Ops/s 7.7593 Ops/s $\color{#35bf28}+1.86\%$
test_sync_pixels 85.9421ms 83.1514ms 12.0263 Ops/s 11.8562 Ops/s $\color{#35bf28}+1.43\%$
test_async_pixels 0.1534s 65.7570ms 15.2075 Ops/s 14.5888 Ops/s $\color{#35bf28}+4.24\%$
test_simple 0.7936s 0.7920s 1.2626 Ops/s 1.2324 Ops/s $\color{#35bf28}+2.45\%$
test_transformed 1.0394s 1.0389s 0.9625 Ops/s 0.9297 Ops/s $\color{#35bf28}+3.53\%$
test_serial 2.4904s 2.4278s 0.4119 Ops/s 0.3971 Ops/s $\color{#35bf28}+3.72\%$
test_parallel 2.3941s 2.3555s 0.4245 Ops/s 0.4237 Ops/s $\color{#35bf28}+0.19\%$
test_step_mdp_speed[True-True-True-True-True] 0.3221ms 33.3562μs 29.9794 KOps/s 30.3269 KOps/s $\color{#d91a1a}-1.15\%$
test_step_mdp_speed[True-True-True-True-False] 41.0410μs 20.0079μs 49.9801 KOps/s 50.3051 KOps/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[True-True-True-False-True] 0.2089ms 19.0964μs 52.3659 KOps/s 52.8185 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[True-True-True-False-False] 42.0110μs 11.2059μs 89.2388 KOps/s 87.4595 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[True-True-False-True-True] 0.2335ms 35.0660μs 28.5176 KOps/s 28.5163 KOps/s $+0.00\%$
test_step_mdp_speed[True-True-False-True-False] 0.2059ms 21.4471μs 46.6263 KOps/s 45.8095 KOps/s $\color{#35bf28}+1.78\%$
test_step_mdp_speed[True-True-False-False-True] 45.3810μs 20.8924μs 47.8643 KOps/s 48.2487 KOps/s $\color{#d91a1a}-0.80\%$
test_step_mdp_speed[True-True-False-False-False] 33.7510μs 13.0594μs 76.5734 KOps/s 75.4821 KOps/s $\color{#35bf28}+1.45\%$
test_step_mdp_speed[True-False-True-True-True] 0.2279ms 37.0456μs 26.9938 KOps/s 27.1671 KOps/s $\color{#d91a1a}-0.64\%$
test_step_mdp_speed[True-False-True-True-False] 0.2134ms 23.3324μs 42.8588 KOps/s 42.2996 KOps/s $\color{#35bf28}+1.32\%$
test_step_mdp_speed[True-False-True-False-True] 0.2118ms 20.3906μs 49.0423 KOps/s 48.4440 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[True-False-True-False-False] 35.1610μs 12.9477μs 77.2339 KOps/s 74.9709 KOps/s $\color{#35bf28}+3.02\%$
test_step_mdp_speed[True-False-False-True-True] 0.2273ms 38.3472μs 26.0775 KOps/s 25.8826 KOps/s $\color{#35bf28}+0.75\%$
test_step_mdp_speed[True-False-False-True-False] 0.2135ms 24.8895μs 40.1777 KOps/s 39.2136 KOps/s $\color{#35bf28}+2.46\%$
test_step_mdp_speed[True-False-False-False-True] 0.3085ms 22.4440μs 44.5554 KOps/s 44.4576 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-False-False-False-False] 34.9700μs 14.7484μs 67.8042 KOps/s 65.9400 KOps/s $\color{#35bf28}+2.83\%$
test_step_mdp_speed[False-True-True-True-True] 59.5020μs 36.3043μs 27.5449 KOps/s 26.9350 KOps/s $\color{#35bf28}+2.26\%$
test_step_mdp_speed[False-True-True-True-False] 0.2388ms 23.2964μs 42.9252 KOps/s 42.1352 KOps/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[False-True-True-False-True] 0.2285ms 24.6212μs 40.6155 KOps/s 40.5843 KOps/s $\color{#35bf28}+0.08\%$
test_step_mdp_speed[False-True-True-False-False] 44.6100μs 15.0986μs 66.2314 KOps/s 66.2046 KOps/s $\color{#35bf28}+0.04\%$
test_step_mdp_speed[False-True-False-True-True] 0.2313ms 38.1233μs 26.2307 KOps/s 25.5427 KOps/s $\color{#35bf28}+2.69\%$
test_step_mdp_speed[False-True-False-True-False] 0.2436ms 25.0964μs 39.8463 KOps/s 39.1325 KOps/s $\color{#35bf28}+1.82\%$
test_step_mdp_speed[False-True-False-False-True] 0.2090ms 26.0625μs 38.3693 KOps/s 37.7748 KOps/s $\color{#35bf28}+1.57\%$
test_step_mdp_speed[False-True-False-False-False] 33.0010μs 17.0188μs 58.7585 KOps/s 58.7555 KOps/s $+0.01\%$
test_step_mdp_speed[False-False-True-True-True] 0.2355ms 40.3473μs 24.7848 KOps/s 24.6439 KOps/s $\color{#35bf28}+0.57\%$
test_step_mdp_speed[False-False-True-True-False] 0.2314ms 27.2762μs 36.6620 KOps/s 36.0799 KOps/s $\color{#35bf28}+1.61\%$
test_step_mdp_speed[False-False-True-False-True] 0.2268ms 25.9602μs 38.5205 KOps/s 37.7285 KOps/s $\color{#35bf28}+2.10\%$
test_step_mdp_speed[False-False-True-False-False] 37.7910μs 16.7923μs 59.5512 KOps/s 58.9259 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[False-False-False-True-True] 74.8720μs 42.8337μs 23.3461 KOps/s 23.0318 KOps/s $\color{#35bf28}+1.36\%$
test_step_mdp_speed[False-False-False-True-False] 0.2294ms 29.6185μs 33.7627 KOps/s 33.7235 KOps/s $\color{#35bf28}+0.12\%$
test_step_mdp_speed[False-False-False-False-True] 0.2353ms 28.3222μs 35.3080 KOps/s 35.3922 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[False-False-False-False-False] 0.2116ms 18.5384μs 53.9422 KOps/s 53.3047 KOps/s $\color{#35bf28}+1.20\%$
test_values[generalized_advantage_estimate-True-True] 24.6487ms 24.0334ms 41.6088 Ops/s 39.1460 Ops/s $\textbf{\color{#35bf28}+6.29\%}$
test_values[vec_generalized_advantage_estimate-True-True] 83.9043ms 3.2470ms 307.9727 Ops/s 310.6837 Ops/s $\color{#d91a1a}-0.87\%$
test_values[td0_return_estimate-False-False] 92.2830μs 62.9756μs 15.8792 KOps/s 15.3203 KOps/s $\color{#35bf28}+3.65\%$
test_values[td1_return_estimate-False-False] 51.8750ms 51.4819ms 19.4243 Ops/s 18.2712 Ops/s $\textbf{\color{#35bf28}+6.31\%}$
test_values[vec_td1_return_estimate-False-False] 2.0478ms 1.7645ms 566.7395 Ops/s 563.4461 Ops/s $\color{#35bf28}+0.58\%$
test_values[td_lambda_return_estimate-True-False] 82.7081ms 82.0769ms 12.1837 Ops/s 11.6282 Ops/s $\color{#35bf28}+4.78\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.1178ms 1.7610ms 567.8516 Ops/s 563.9086 Ops/s $\color{#35bf28}+0.70\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.2249ms 22.8429ms 43.7773 Ops/s 41.2130 Ops/s $\textbf{\color{#35bf28}+6.22\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9098ms 0.6903ms 1.4486 KOps/s 1.4082 KOps/s $\color{#35bf28}+2.87\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7559ms 0.6564ms 1.5235 KOps/s 1.5113 KOps/s $\color{#35bf28}+0.81\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5103ms 1.4456ms 691.7733 Ops/s 686.5051 Ops/s $\color{#35bf28}+0.77\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9476ms 0.6674ms 1.4983 KOps/s 1.4691 KOps/s $\color{#35bf28}+1.99\%$
test_dqn_speed 77.9883ms 1.5539ms 643.5458 Ops/s 667.8357 Ops/s $\color{#d91a1a}-3.64\%$
test_ddpg_speed 3.1907ms 2.8979ms 345.0809 Ops/s 329.8217 Ops/s $\color{#35bf28}+4.63\%$
test_sac_speed 9.0695ms 8.3109ms 120.3235 Ops/s 115.7594 Ops/s $\color{#35bf28}+3.94\%$
test_redq_speed 12.6067ms 10.7344ms 93.1580 Ops/s 92.1851 Ops/s $\color{#35bf28}+1.06\%$
test_redq_deprec_speed 12.1268ms 11.5261ms 86.7596 Ops/s 82.9953 Ops/s $\color{#35bf28}+4.54\%$
test_td3_speed 16.9861ms 8.3136ms 120.2844 Ops/s 114.9374 Ops/s $\color{#35bf28}+4.65\%$
test_cql_speed 27.1520ms 25.7018ms 38.9078 Ops/s 37.6087 Ops/s $\color{#35bf28}+3.45\%$
test_a2c_speed 5.8399ms 5.5929ms 178.7989 Ops/s 169.6622 Ops/s $\textbf{\color{#35bf28}+5.39\%}$
test_ppo_speed 6.1947ms 5.9049ms 169.3509 Ops/s 160.0584 Ops/s $\textbf{\color{#35bf28}+5.81\%}$
test_reinforce_speed 5.4035ms 4.5806ms 218.3106 Ops/s 207.1321 Ops/s $\textbf{\color{#35bf28}+5.40\%}$
test_iql_speed 20.4105ms 19.6341ms 50.9317 Ops/s 48.3004 Ops/s $\textbf{\color{#35bf28}+5.45\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.8293ms 4.5361ms 220.4523 Ops/s 213.1563 Ops/s $\color{#35bf28}+3.42\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4556ms 0.5942ms 1.6830 KOps/s 1.6326 KOps/s $\color{#35bf28}+3.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8108ms 0.5729ms 1.7454 KOps/s 1.6837 KOps/s $\color{#35bf28}+3.66\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.8308ms 4.5245ms 221.0200 Ops/s 215.8713 Ops/s $\color{#35bf28}+2.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3594ms 0.5904ms 1.6937 KOps/s 1.6335 KOps/s $\color{#35bf28}+3.69\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8475ms 0.5737ms 1.7431 KOps/s 1.6879 KOps/s $\color{#35bf28}+3.27\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.8075ms 1.5622ms 640.1210 Ops/s 617.6967 Ops/s $\color{#35bf28}+3.63\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.7303ms 1.5031ms 665.2909 Ops/s 645.0291 Ops/s $\color{#35bf28}+3.14\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8125ms 4.6149ms 216.6912 Ops/s 209.8089 Ops/s $\color{#35bf28}+3.28\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8312ms 0.7320ms 1.3661 KOps/s 1.3302 KOps/s $\color{#35bf28}+2.71\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.8413ms 0.7069ms 1.4146 KOps/s 1.3753 KOps/s $\color{#35bf28}+2.86\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.7490ms 4.5345ms 220.5297 Ops/s 214.0545 Ops/s $\color{#35bf28}+3.03\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.6801ms 0.6068ms 1.6480 KOps/s 1.6133 KOps/s $\color{#35bf28}+2.15\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7679ms 0.5816ms 1.7193 KOps/s 1.6499 KOps/s $\color{#35bf28}+4.21\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.8306ms 4.5137ms 221.5472 Ops/s 213.9999 Ops/s $\color{#35bf28}+3.53\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8768ms 0.5961ms 1.6777 KOps/s 1.6279 KOps/s $\color{#35bf28}+3.06\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 5.1574ms 0.5844ms 1.7112 KOps/s 1.6826 KOps/s $\color{#35bf28}+1.70\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8278ms 4.6784ms 213.7499 Ops/s 207.8415 Ops/s $\color{#35bf28}+2.84\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.8465ms 0.7374ms 1.3560 KOps/s 1.3201 KOps/s $\color{#35bf28}+2.72\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8400ms 0.7177ms 1.3933 KOps/s 1.3422 KOps/s $\color{#35bf28}+3.81\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1335s 7.4853ms 133.5945 Ops/s 135.7035 Ops/s $\color{#d91a1a}-1.55\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.3448ms 15.6372ms 63.9499 Ops/s 60.5134 Ops/s $\textbf{\color{#35bf28}+5.68\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.6166ms 1.3452ms 743.3955 Ops/s 717.0083 Ops/s $\color{#35bf28}+3.68\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1189s 7.2178ms 138.5468 Ops/s 104.2742 Ops/s $\textbf{\color{#35bf28}+32.87\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.6971ms 15.3923ms 64.9675 Ops/s 61.9478 Ops/s $\color{#35bf28}+4.87\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1149s 3.6347ms 275.1225 Ops/s 711.9163 Ops/s $\textbf{\color{#d91a1a}-61.35\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1192s 7.5829ms 131.8754 Ops/s 128.9858 Ops/s $\color{#35bf28}+2.24\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.2048ms 15.6786ms 63.7811 Ops/s 61.0775 Ops/s $\color{#35bf28}+4.43\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.7026ms 1.6731ms 597.7065 Ops/s 560.9389 Ops/s $\textbf{\color{#35bf28}+6.55\%}$

@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Jun 3, 2024
@vmoens vmoens merged commit 2370d6e into main Jun 3, 2024
17 of 27 checks passed
@vmoens vmoens deleted the fix-dmcontrol-terminated branch June 3, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot