Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Correct minor erratum in knowledge_base entry #2383

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[Doc] Correct minor erratum in knowledge_base entry #2383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions knowledge_base/VIDEO_CUSTOMISATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,5 @@ as advised by the documentation.
We can improve the video quality by appending all our desired settings
(as keyword arguments) to `recorder` like so:
```python
# The arguments' types don't appear to matter too much, as long as they are
# appropriate for Python.
# For example, this would work as well:
# logger = CSVLogger(exp_name="my_exp", crf=17, preset="slow")
logger = CSVLogger(exp_name="my_exp", crf="17", preset="slow")
recorder = VideoRecorder(logger, tag = "my_video", options = {"crf": "17", "preset": "slow"})
```
Loading