Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quality] Better warning when c++ binaries failed to be imported #2541

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 6, 2024

Closes #2468

Copy link

pytorch-bot bot commented Nov 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2541

Note: Links to docs will display an error until the docs builds have been completed.

❌ 21 New Failures, 2 Cancelled Jobs, 5 Unrelated Failures

As of commit 72824cf with merge base 528875a (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2024
@vmoens vmoens added the quality code quality label Nov 6, 2024
@vmoens vmoens merged commit 0a13cbd into main Nov 6, 2024
41 of 61 checks passed
@vmoens vmoens deleted the better-error-cpp branch November 6, 2024 10:19
vmoens added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Running into Failed to import torchrl C++ binaries for local install
2 participants