-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add LossModule.reset_parameters_recursive
#2546
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2546
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 13 Unrelated FailuresAs of commit fadbf90 with merge base 35a7813 (): NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
a71eb4a
to
7095df7
Compare
7095df7
to
fadbf90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
def reset_parameters_recursive( | ||
self, | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def reset_parameters_recursive( | |
self, | |
): | |
def reset_parameters_recursive(self): |
Description
Adds
LossModule.reset_parameters_recursive
, which resets each parameter using thereset_parameters_recursive
method from its corresponding submodule.Motivation and Context
Close #2538
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!