-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature, Test] Adding tests for envs that have no specs #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2621
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 8 Unrelated FailuresAs of commit 8d68727 with merge base 90c8e40 (): NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vmoens
added a commit
that referenced
this pull request
Dec 2, 2024
ghstack-source-id: 2968cc344b75042d3bb845bfda01e12bf00f4af7 Pull Request resolved: #2621
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Dec 2, 2024
vmoens
added a commit
that referenced
this pull request
Dec 2, 2024
ghstack-source-id: 93de5c38ec11af64b32710c1a5f4d36e06f4f8c3 Pull Request resolved: #2621
vmoens
added
enhancement
New feature or request
Tests
Incomplete or broken unit tests
labels
Dec 2, 2024
vmoens
added a commit
that referenced
this pull request
Dec 2, 2024
ghstack-source-id: 4c75691baa1e70f417e518df15c4208cff189950 Pull Request resolved: #2621
vmoens
added a commit
that referenced
this pull request
Dec 2, 2024
ghstack-source-id: 4c75691baa1e70f417e518df15c4208cff189950 Pull Request resolved: #2621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
enhancement
New feature or request
Tests
Incomplete or broken unit tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):