Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature, Test] Adding tests for envs that have no specs #2621

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Dec 2, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Dec 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2621

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 8 Unrelated Failures

As of commit 8d68727 with merge base 90c8e40 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Dec 2, 2024
ghstack-source-id: 2968cc344b75042d3bb845bfda01e12bf00f4af7
Pull Request resolved: #2621
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2024
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Dec 2, 2024
ghstack-source-id: 93de5c38ec11af64b32710c1a5f4d36e06f4f8c3
Pull Request resolved: #2621
@vmoens vmoens added enhancement New feature or request Tests Incomplete or broken unit tests labels Dec 2, 2024
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Dec 2, 2024
ghstack-source-id: 4c75691baa1e70f417e518df15c4208cff189950
Pull Request resolved: #2621
@vmoens vmoens merged commit 8d68727 into gh/vmoens/45/base Dec 2, 2024
60 of 73 checks passed
vmoens added a commit that referenced this pull request Dec 2, 2024
ghstack-source-id: 4c75691baa1e70f417e518df15c4208cff189950
Pull Request resolved: #2621
@vmoens vmoens deleted the gh/vmoens/45/head branch December 2, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request Tests Incomplete or broken unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants