Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Avoid cloning trajs in SliceSampler #2671

Merged
merged 2 commits into from
Dec 20, 2024

Update

5aacaea
Select commit
Loading
Failed to load commit list.
Merged

[Performance] Avoid cloning trajs in SliceSampler #2671

Update
5aacaea
Select commit
Loading
Failed to load commit list.
PyTorch Bot / Dr.CI completed Dec 20, 2024 in 0s

Dr.CI classification results

{"FAILED":[{"workflowId":12428564816,"workflowUniqueId":82165822,"id":34700435382,"runnerName":"i-0c57cbadfdc2dd895","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-cpu (3.10) / linux-job","jobName":"tests-cpu (3.10) / linux-job","conclusion":"failure","completed_at":"2024-12-20T09:42:54.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564816/job/34700435382","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["test/test_env.py::TestNonTensorEnv::test_parallel[True-False]"],"failure_lines":["FAILED test/test_env.py::TestNonTensorEnv::test_parallel[True-False] - EOFError"],"failure_context":[],"time":"2024-12-20T09:04:26.000000000Z"},{"workflowId":12428564816,"workflowUniqueId":82165822,"id":34700449565,"runnerName":"i-0e48b3b195e4b06bd","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job","jobName":"tests-stable-gpu (3.10, 11.8) / linux-job","conclusion":"failure","completed_at":"2024-12-20T10:08:35.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564816/job/34700449565","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["test/test_env.py::TestNonTensorEnv::test_parallel[True-False]"],"failure_lines":["FAILED test/test_env.py::TestNonTensorEnv::test_parallel[True-False] - EOFError"],"failure_context":[],"time":"2024-12-20T09:04:46.000000000Z"},{"workflowId":12428564816,"workflowUniqueId":82165822,"id":34700437198,"runnerName":"i-0c00f10a130963cf1","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-cpu (3.11) / linux-job","jobName":"tests-cpu (3.11) / linux-job","conclusion":"failure","completed_at":"2024-12-20T09:41:54.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564816/job/34700437198","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["test/test_env.py::TestNonTensorEnv::test_parallel[True-False]"],"failure_lines":["FAILED test/test_env.py::TestNonTensorEnv::test_parallel[True-False] - EOFError"],"failure_context":[],"time":"2024-12-20T09:04:28.000000000Z"},{"workflowId":12428564816,"workflowUniqueId":82165822,"id":34700438908,"runnerName":"i-0dbe7feb8f351014d","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-cpu (3.9) / linux-job","jobName":"tests-cpu (3.9) / linux-job","conclusion":"failure","completed_at":"2024-12-20T09:43:46.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564816/job/34700438908","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["test/test_env.py::TestNonTensorEnv::test_parallel[True-False]"],"failure_lines":["FAILED test/test_env.py::TestNonTensorEnv::test_parallel[True-False] - EOFError"],"failure_context":[],"time":"2024-12-20T09:04:31.000000000Z"},{"workflowId":12428564816,"workflowUniqueId":82165822,"id":34700441355,"runnerName":"i-0bf6d9a803b4f0b96","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-cpu (3.12) / linux-job","jobName":"tests-cpu (3.12) / linux-job","conclusion":"failure","completed_at":"2024-12-20T09:48:07.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564816/job/34700441355","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["test/test_env.py::TestNonTensorEnv::test_parallel[True-False]"],"failure_lines":["FAILED test/test_env.py::TestNonTensorEnv::test_parallel[True-False] - EOFError"],"failure_context":[],"time":"2024-12-20T09:04:35.000000000Z"},{"workflowId":12428564816,"workflowUniqueId":82165822,"id":34700443147,"runnerName":"i-08a8f4ed3e51799e2","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-cpu-oldget (3.12) / linux-job","jobName":"tests-cpu-oldget (3.12) / linux-job","conclusion":"failure","completed_at":"2024-12-20T09:44:06.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564816/job/34700443147","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["test/test_env.py::TestNonTensorEnv::test_parallel[True-False]"],"failure_lines":["FAILED test/test_env.py::TestNonTensorEnv::test_parallel[True-False] - EOFError"],"failure_context":[],"time":"2024-12-20T09:04:37.000000000Z"},{"workflowId":12428564816,"workflowUniqueId":82165822,"id":34700446083,"runnerName":"i-0c98571ee5a92dabd","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job","jobName":"tests-olddeps (3.8, 11.6) / linux-job","conclusion":"failure","completed_at":"2024-12-20T09:09:51.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564816/job/34700446083","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["RuntimeError: Command docker exec -t 096b8c1bb56e7236a6f13a18c73fa47004f625799d65d906c41388b31334b5d7 /exec failed with exit code 1"],"failure_lines":["RuntimeError: Command docker exec -t 096b8c1bb56e7236a6f13a18c73fa47004f625799d65d906c41388b31334b5d7 /exec failed with exit code 1"],"failure_context":[],"time":"2024-12-20T09:04:41.000000000Z"},{"workflowId":12428564816,"workflowUniqueId":82165822,"id":34700447736,"runnerName":"i-0574a6dfc0881ccbf","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-optdeps (3.11, 12.1) / linux-job","jobName":"tests-optdeps (3.11, 12.1) / linux-job","conclusion":"failure","completed_at":"2024-12-20T09:45:32.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564816/job/34700447736","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["test/test_env.py::TestNonTensorEnv::test_parallel[True-False]"],"failure_lines":["FAILED test/test_env.py::TestNonTensorEnv::test_parallel[True-False] - EOFError"],"failure_context":[],"time":"2024-12-20T09:04:44.000000000Z"},{"workflowId":12428564817,"workflowUniqueId":60501564,"id":34700433714,"runnerName":"i-040d5811369b7831a","authorEmail":"[email protected]","name":"Habitat Tests on Linux / tests (3.9, 12.1) / linux-job","jobName":"tests (3.9, 12.1) / linux-job","conclusion":"failure","completed_at":"2024-12-20T09:15:25.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564817/job/34700433714","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["AttributeError: _ARRAY_API not found"],"failure_lines":["AttributeError: _ARRAY_API not found"],"failure_context":[],"time":"2024-12-20T09:04:23.000000000Z"}],"FLAKY":[],"BROKEN_TRUNK":[{"workflowId":12428564876,"workflowUniqueId":106193614,"id":34701268735,"runnerName":"GitHub Actions 365","authorEmail":"[email protected]","name":"Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cpu","jobName":"pytorch/rl / upload / wheel-py3_9-cpu","conclusion":"failure","completed_at":"2024-12-20T09:24:57.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564876/job/34701268735","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["Unable to find any artifacts for the associated workflow"],"failure_lines":["##[error]Unable to find any artifacts for the associated workflow"],"failure_context":[],"time":"2024-12-20T09:24:42.000000000Z"},{"workflowId":12428564876,"workflowUniqueId":106193614,"id":34701268979,"runnerName":"GitHub Actions 313","authorEmail":"[email protected]","name":"Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cuda11_8","jobName":"pytorch/rl / upload / wheel-py3_9-cuda11_8","conclusion":"failure","completed_at":"2024-12-20T09:24:57.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564876/job/34701268979","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["Unable to find any artifacts for the associated workflow"],"failure_lines":["##[error]Unable to find any artifacts for the associated workflow"],"failure_context":[],"time":"2024-12-20T09:24:43.000000000Z"},{"workflowId":12428564876,"workflowUniqueId":106193614,"id":34701269245,"runnerName":"GitHub Actions 72","authorEmail":"[email protected]","name":"Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cuda12_4","jobName":"pytorch/rl / upload / wheel-py3_9-cuda12_4","conclusion":"failure","completed_at":"2024-12-20T09:24:55.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564876/job/34701269245","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["Unable to find any artifacts for the associated workflow"],"failure_lines":["##[error]Unable to find any artifacts for the associated workflow"],"failure_context":[],"time":"2024-12-20T09:24:43.000000000Z"},{"workflowId":12428564876,"workflowUniqueId":106193614,"id":34701269499,"runnerName":"GitHub Actions 217","authorEmail":"[email protected]","name":"Build Windows Wheels / pytorch/rl / upload / wheel-py3_9-cuda12_6","jobName":"pytorch/rl / upload / wheel-py3_9-cuda12_6","conclusion":"failure","completed_at":"2024-12-20T09:25:05.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564876/job/34701269499","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["Unable to find any artifacts for the associated workflow"],"failure_lines":["##[error]Unable to find any artifacts for the associated workflow"],"failure_context":[],"time":"2024-12-20T09:24:43.000000000Z"},{"workflowId":12428564816,"workflowUniqueId":82165822,"id":34700444883,"runnerName":"i-07fc0d08adc55b46d","authorEmail":"[email protected]","name":"Unit-tests on Linux / tests-gpu (3.11, 12.1) / linux-job","jobName":"tests-gpu (3.11, 12.1) / linux-job","conclusion":"failure","completed_at":"2024-12-20T10:04:37.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564816/job/34700444883","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["test/test_loggers.py::TestMLFlowLogger::test_log_video[steps1]"],"failure_lines":["FAILED test/test_loggers.py::TestMLFlowLogger::test_log_video[steps1] - TypeError: an integer is required"],"failure_context":[],"time":"2024-12-20T09:04:40.000000000Z"},{"workflowId":12428564834,"workflowUniqueId":79519303,"id":34700430563,"runnerName":"i-0f694fb414e6f3bbc","authorEmail":"[email protected]","name":"Unit-tests on Windows / unittests-cpu / windows-job","jobName":"unittests-cpu / windows-job","conclusion":"failure","completed_at":"2024-12-20T09:18:32.000000000Z","html_url":"https://github.com/pytorch/rl/actions/runs/12428564834/job/34700430563","head_branch":"gh/vmoens/61/head","pr_number":2671,"head_sha":"5aacaea0224066d5b093f3d3ed050ca6611a66a5","head_sha_timestamp":"2024-12-20T09:03:46.000000000Z","failure_captures":["Process completed with exit code 1."],"failure_lines":["##[error]Process completed with exit code 1."],"failure_context":[],"time":"2024-12-20T09:04:19.000000000Z"}],"UNSTABLE":[]}