Skip to content

[BugFix] NonTensor.encode must return a NonTensorData #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented May 7, 2025

[ghstack-poisoned]
vmoens added a commit that referenced this pull request May 7, 2025
ghstack-source-id: 36fc87c
Pull-Request-resolved: #2944
Copy link

pytorch-bot bot commented May 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2944

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Cancelled Job, 1 Pending, 4 Unrelated Failures

As of commit 809431e with merge base ccadb67 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2025
@vmoens vmoens added the bug Something isn't working label May 8, 2025
@vmoens vmoens merged commit 809431e into gh/vmoens/143/base May 8, 2025
91 of 100 checks passed
vmoens added a commit that referenced this pull request May 8, 2025
ghstack-source-id: 36fc87c
Pull-Request-resolved: #2944
@vmoens vmoens deleted the gh/vmoens/143/head branch May 8, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants