Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: vesion -> version, succsesfully -> successfully #3322

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

tadayosi
Copy link
Contributor

@tadayosi tadayosi commented Sep 18, 2024

Description

Hi, thank you for merging my previous PR. This is yet another typo fix PR. What it does is:

  • vesion -> version
  • succsesfully -> successfully

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

n/a

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@tadayosi tadayosi changed the title Fix typo: vesion -> version Fix typo: vesion -> version, succsesfully -> successfully Sep 18, 2024
@tadayosi
Copy link
Contributor Author

Could anybody take a look at this? @mreso? Thank you!

Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreso
Copy link
Collaborator

mreso commented Sep 20, 2024

Thanks @tadayosi for contributing!

@mreso mreso added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@mreso
Copy link
Collaborator

mreso commented Sep 20, 2024

Was hoping we can merge without the docker checks... This is blocked right now, as we need to merge #3327 first

@mreso mreso added this pull request to the merge queue Sep 21, 2024
Merged via the queue into pytorch:master with commit d993070 Sep 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants