-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rockset migration - move upload for queue_times_historical from rockset to s3 #5398
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -48,6 +48,7 @@ SELECT | |||
COUNT(*) AS count, | |||
MAX(queue_s) AS avg_queue_s, | |||
machine_type, | |||
CURRENT_TIMESTAMP() AS _event_time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a comment on why we need to use CURRENT_TIMESTAMP as _event_time here. I guess that this is because Rockset uses the time when it ingests the data as _event_time. So, re-importing records from S3 will set them all to the same _event_time?
s3client.send( | ||
new PutObjectCommand({ | ||
Bucket: "ossci-raw-job-status", | ||
Key: `queue_times_historical/${response.results[0]._event_time}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This work but I would prefer to see UNIX epoch as the key instead as it looks nicer as S3 path, but that's a minor point.
Use the current timestamp as the key