Rockset migration - update queue times- explicitly use the new time field instead of _event_time and fix env variables in update queue times workflow #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
clee2000
changed the title
malfet
approved these changes
Jul 9, 2024
clee2000
added a commit
that referenced
this pull request
Jul 10, 2024
Follow up to #5412 I'm not sure why the env var is not being set https://github.com/pytorch/test-infra/actions/runs/9867482380/job/27247927172#step:5:10 but the other ones are so we can just use those for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5398
Change historical queue times query for HUD metrics page
Looks good
Also change the workflow so we can use workflow dispatch and so that it has the env vars