[ch] backfill queries #5624
Merged
[ch] backfill queries #5624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ZainRizvi
approved these changes
Sep 9, 2024
torchci/scripts/backfillJobs.mjs
Outdated
| @@ -17,6 +18,26 @@ function getDynamoClient() { | |||
| ); | |||
| } | |||
|
|
|||
| function getClickhouseClient() { | |||
| return createClient({ | |||
| host: process.env.CLICKHOUSE_HUD_USER_URL ?? "http://localhost:8123", | |||
There was a problem hiding this comment.
nit: A comment explaining the 8123 or linking to their docs could be helpful here.
There was a problem hiding this comment.
Its the default value when running locally and not using TLS (?) https://clickhouse.com/docs/en/integrations/javascript#url-configuration
Either way I got rid of it since it doesn't make much sense to run this script without these environment variables set to actual values
This was referenced Sep 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert queries to CH, query both rockset and clickhouse in all queries