Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dynamo_graph_break_reason in tlparse #76

Closed
wants to merge 1 commit into from
Closed

Show dynamo_graph_break_reason in tlparse #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/parsers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,9 @@ pub fn default_parsers<'t>(
Box::new(SentinelFileParser::new("dynamo_cpp_guards_str", |e| {
e.dynamo_cpp_guards_str.as_ref()
})),
Box::new(SentinelFileParser::new("dynamo_graph_break_reason", |e| {
e.dynamo_graph_break_reason.as_ref()
})),
Box::new(GraphDumpParser),
Box::new(DynamoOutputGraphParser),
Box::new(DynamoGuardParser { tt }),
Expand Down
1 change: 1 addition & 0 deletions src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ pub struct Envelope {
pub aot_joint_graph: Option<EmptyMetadata>,
pub inductor_post_grad_graph: Option<EmptyMetadata>,
pub dynamo_cpp_guards_str: Option<EmptyMetadata>,
pub dynamo_graph_break_reason: Option<EmptyMetadata>,
pub inductor_output_code: Option<InductorOutputCodeMetadata>,
pub compilation_metrics: Option<CompilationMetricsMetadata>,
pub bwd_compilation_metrics: Option<BwdCompilationMetricsMetadata>,
Expand Down
48 changes: 48 additions & 0 deletions tests/inputs/comp_metrics.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,30 @@ V0403 07:28:48.052000 139877824898048 torch/_logging/structured.py:19] {"str": [
V0403 07:28:48.052000 139877824898048 torch/_logging/structured.py:19] {"str": ["/data/users/jjwu/a/pytorch-env/lib/python3.10/unittest/case.py", 6]}
V0403 07:28:48.052000 139877824898048 torch/_logging/structured.py:19] {"str": ["/data/users/jjwu/a/pytorch/torch/_dynamo/eval_frame.py", 7]}
V0403 07:28:48.052000 139877824898048 torch/_dynamo/convert_frame.py:672] {"dynamo_start": {"stack": [{"line": 10079, "name": "<module>", "filename": 0}, {"line": 41, "name": "run_tests", "filename": 1}, {"line": 1167, "name": "run_tests", "filename": 2}, {"line": 101, "name": "__init__", "filename": 3}, {"line": 271, "name": "runTests", "filename": 3}, {"line": 184, "name": "run", "filename": 4}, {"line": 84, "name": "__call__", "filename": 5}, {"line": 122, "name": "run", "filename": 5}, {"line": 84, "name": "__call__", "filename": 5}, {"line": 122, "name": "run", "filename": 5}, {"line": 650, "name": "__call__", "filename": 6}, {"line": 2868, "name": "run", "filename": 2}, {"line": 2840, "name": "_run_custom", "filename": 2}, {"line": 591, "name": "run", "filename": 6}, {"line": 549, "name": "_callTestMethod", "filename": 6}, {"line": 2741, "name": "wrapper", "filename": 2}, {"line": 9559, "name": "test_graph_break_compilation_metrics", "filename": 0}, {"line": 410, "name": "_fn", "filename": 7}]}, "frame_id": 0, "frame_compile_id": 0, "attempt": 0}
V0403 07:28:48.052000 139877824898048 torch/_dynamo/symbolic_convert.py:391] {"dynamo_graph_break_reason": {}, "frame_id": 0, "frame_compile_id": 0, "attempt": 0, "has_payload": "6e58a1cd0c1397ef247aa9c99ab8c5a7"}
Graph break in user code at /data/users/willfeng/pytorch/test/dynamo/test_misc.py:10440
Reason: Unsupported: 'skip function graph_break in file /data/users/willfeng/pytorch/torch/_dynamo/decorators.py'
User code traceback:
File "/data/users/willfeng/pytorch/test/dynamo/test_misc.py", line 10440, in fn
torch._dynamo.graph_break()

Traceback (most recent call last):
File "/data/users/willfeng/pytorch/torch/_dynamo/symbolic_convert.py", line 632, in wrapper
return inner_fn(self, inst)
^^^^^^^^^^^^^^^^^^^^
File "/data/users/willfeng/pytorch/torch/_dynamo/symbolic_convert.py", line 2411, in CALL
self._call(inst)
File "/data/users/willfeng/pytorch/torch/_dynamo/symbolic_convert.py", line 2405, in _call
self.call_function(fn, args, kwargs)
File "/data/users/willfeng/pytorch/torch/_dynamo/symbolic_convert.py", line 959, in call_function
self.push(fn.call_function(self, args, kwargs)) # type: ignore[arg-type]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/data/users/willfeng/pytorch/torch/_dynamo/variables/functions.py", line 750, in call_function
unimplemented(msg)
File "/data/users/willfeng/pytorch/torch/_dynamo/exc.py", line 309, in unimplemented
raise Unsupported(msg, case_name=case_name)
torch._dynamo.exc.Unsupported: 'skip function graph_break in file /data/users/willfeng/pytorch/torch/_dynamo/decorators.py'

V0403 07:28:48.061000 139877824898048 torch/_dynamo/output_graph.py:1139] {"dynamo_output_graph": {"sizes": {"l_x_": [4, 4], "cos": [4, 4]}}, "frame_id": 0, "frame_compile_id": 0, "attempt": 1, "has_payload": "b02b7e74ec144d0daf4087e58131a444"}
class GraphModule(torch.nn.Module):
def forward(self, L_x_ : torch.Tensor):
Expand All @@ -30,6 +54,30 @@ V0403 07:28:48.064000 139877824898048 torch/_dynamo/guards.py:1894] {"dynamo_gua
]
V0403 07:28:48.065000 139877824898048 torch/_dynamo/utils.py:685] {"compilation_metrics": {"frame_key": "1", "co_name": "fn", "co_filename": "/data/users/jjwu/a/pytorch/test/dynamo/test_misc.py", "co_firstlineno": 9549, "cache_size": 0, "accumulated_cache_size": 0, "guard_count": 9, "shape_env_guard_count": 0, "graph_op_count": 1, "graph_node_count": 3, "graph_input_count": 1, "start_time": 1712154528.0523684, "entire_frame_compile_time_s": 0.012439489364624023, "backend_compile_time_s": 3.910064697265625e-05, "inductor_compile_time_s": null, "code_gen_time_s": null, "fail_type": null, "fail_reason": null, "fail_user_frame_filename": null, "fail_user_frame_lineno": null, "non_compliant_ops": [], "compliant_custom_ops": [], "restart_reasons": ["'skip function graph_break in file /data/users/jjwu/a/pytorch/torch/_dynamo/decorators.py'"], "dynamo_time_before_restart_s": 0.006658077239990234}, "frame_id": 0, "frame_compile_id": 0, "attempt": 1}
V0403 07:28:48.066000 139877824898048 torch/_dynamo/convert_frame.py:672] {"dynamo_start": {"stack": [{"line": 10079, "name": "<module>", "filename": 0}, {"line": 41, "name": "run_tests", "filename": 1}, {"line": 1167, "name": "run_tests", "filename": 2}, {"line": 101, "name": "__init__", "filename": 3}, {"line": 271, "name": "runTests", "filename": 3}, {"line": 184, "name": "run", "filename": 4}, {"line": 84, "name": "__call__", "filename": 5}, {"line": 122, "name": "run", "filename": 5}, {"line": 84, "name": "__call__", "filename": 5}, {"line": 122, "name": "run", "filename": 5}, {"line": 650, "name": "__call__", "filename": 6}, {"line": 2868, "name": "run", "filename": 2}, {"line": 2840, "name": "_run_custom", "filename": 2}, {"line": 591, "name": "run", "filename": 6}, {"line": 549, "name": "_callTestMethod", "filename": 6}, {"line": 2741, "name": "wrapper", "filename": 2}, {"line": 9559, "name": "test_graph_break_compilation_metrics", "filename": 0}, {"line": 410, "name": "_fn", "filename": 7}, {"line": 9551, "name": "fn", "filename": 0}]}, "frame_id": 1, "frame_compile_id": 0, "attempt": 0}
V0403 07:28:48.066000 139877824898048 torch/_dynamo/symbolic_convert.py:391] {"dynamo_graph_break_reason": {}, "frame_id": 1, "frame_compile_id": 0, "attempt": 0, "has_payload": "3056e3dd740aea63b7207dab137a36ba"}
Graph break in user code at /data/users/willfeng/pytorch/test/dynamo/test_misc.py:10442
Reason: Unsupported: 'skip function graph_break in file /data/users/willfeng/pytorch/torch/_dynamo/decorators.py'
User code traceback:
File "/data/users/willfeng/pytorch/test/dynamo/test_misc.py", line 10442, in torch_dynamo_resume_in_fn_at_10440
torch._dynamo.graph_break()

Traceback (most recent call last):
File "/data/users/willfeng/pytorch/torch/_dynamo/symbolic_convert.py", line 632, in wrapper
return inner_fn(self, inst)
^^^^^^^^^^^^^^^^^^^^
File "/data/users/willfeng/pytorch/torch/_dynamo/symbolic_convert.py", line 2411, in CALL
self._call(inst)
File "/data/users/willfeng/pytorch/torch/_dynamo/symbolic_convert.py", line 2405, in _call
self.call_function(fn, args, kwargs)
File "/data/users/willfeng/pytorch/torch/_dynamo/symbolic_convert.py", line 959, in call_function
self.push(fn.call_function(self, args, kwargs)) # type: ignore[arg-type]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/data/users/willfeng/pytorch/torch/_dynamo/variables/functions.py", line 750, in call_function
unimplemented(msg)
File "/data/users/willfeng/pytorch/torch/_dynamo/exc.py", line 309, in unimplemented
raise Unsupported(msg, case_name=case_name)
torch._dynamo.exc.Unsupported: 'skip function graph_break in file /data/users/willfeng/pytorch/torch/_dynamo/decorators.py'

V0403 07:28:48.071000 139877824898048 torch/_dynamo/output_graph.py:1139] {"dynamo_output_graph": {"sizes": {"l_x_": [4, 4], "sin": [4, 4]}}, "frame_id": 1, "frame_compile_id": 0, "attempt": 1, "has_payload": "2a35823c4e6ce78bcc3a8557f11f8a52"}
class GraphModule(torch.nn.Module):
def forward(self, L_x_ : torch.Tensor):
Expand Down
2 changes: 2 additions & 0 deletions tests/integration_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ fn test_parse_simple() {
#[test]
fn test_parse_compilation_metrics() {
let expected_files = [
"0_0_0/dynamo_graph_break_reason",
"0_0_1/dynamo_output_graph",
"0_0_1/dynamo_guards",
"0_0_1/compilation_metrics",
"1_0_0/dynamo_graph_break_reason",
"1_0_1/dynamo_output_graph",
"1_0_1/dynamo_guards",
"1_0_1/compilation_metrics",
Expand Down
Loading