[Distributed] Fix new token's shape #1254
Open
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
TP-only case is broken due to the following error:
It suggests that in the decoding phase, our
input_ids
(i.e.new_tokens
) is flattened rather than being 2D (batch_size, 1).The flattening happens here:
Fix
The fix is simple, we just add a
keepdim=True
flag to torch.argmax.With that, the
unsqueeze
op indecode_in_flight
can be also saved.