chat mode improvements #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
swolchok
reviewed
Apr 17, 2024
cli.py
Outdated
| parser.add_argument( | ||
| "--is-chat-model", | ||
| action="store_true", | ||
| help="Use torchchat to for an interactive chat session.", |
There was a problem hiding this comment.
this doesn't parse as written; delete "to"?
|
(not accepting because I don't know anything about chat mode) |
metascroy
approved these changes
Apr 17, 2024
GregoryComer
approved these changes
Apr 17, 2024
byjlw
approved these changes
Apr 17, 2024
| @@ -35,7 +35,8 @@ class BuilderArgs: | |||
| precision: torch.dtype = torch.float32 | |||
| setup_caches: bool = False | |||
| use_tp: bool = False | |||
|
|
|||
| is_chat_model: bool = False | |||
There was a problem hiding this comment.
want to make that the default?
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* chat mode improvements * disable int4 on macos/x86 because of old nightlies * typo * typo * typo * convert runtime error to arning * wording of option texts
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* chat mode improvements * disable int4 on macos/x86 because of old nightlies * typo * typo * typo * convert runtime error to arning * wording of option texts
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* chat mode improvements * disable int4 on macos/x86 because of old nightlies * typo * typo * typo * convert runtime error to arning * wording of option texts
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* chat mode improvements * disable int4 on macos/x86 because of old nightlies * typo * typo * typo * convert runtime error to arning * wording of option texts
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* chat mode improvements * disable int4 on macos/x86 because of old nightlies * typo * typo * typo * convert runtime error to arning * wording of option texts
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* chat mode improvements * disable int4 on macos/x86 because of old nightlies * typo * typo * typo * convert runtime error to arning * wording of option texts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chat mode improvements