move module attribute inplace update to leaf function in ManagedCollisionModule #2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73448087 |
seanx92
added a commit
to seanx92/torchrec
that referenced
this pull request
Apr 23, 2025
…sionModule (pytorch#2913) Summary: inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Differential Revision: D73448087
seanx92
force-pushed
the
export-D73448087
branch
from
6b94411 to
e37b4bb
Compare
seanx92
added a commit
to seanx92/torchrec
that referenced
this pull request
Apr 23, 2025
…sionModule (pytorch#2913) Summary: inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Differential Revision: D73448087
seanx92
force-pushed
the
export-D73448087
branch
from
e37b4bb to
befec12
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73448087 |
seanx92
added a commit
to seanx92/torchrec
that referenced
this pull request
Apr 23, 2025
…sionModule (pytorch#2913) Summary: Pull Request resolved: pytorch#2913 inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Differential Revision: D73448087
seanx92
force-pushed
the
export-D73448087
branch
from
befec12 to
477f3cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73448087 |
seanx92
added a commit
to seanx92/torchrec
that referenced
this pull request
Apr 23, 2025
…sionModule (pytorch#2913) Summary: Pull Request resolved: pytorch#2913 inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Differential Revision: D73448087
seanx92
force-pushed
the
export-D73448087
branch
2 times, most recently
from
cea87ff to
e141a1b
Compare
seanx92
added a commit
to seanx92/torchrec
that referenced
this pull request
Apr 28, 2025
…sionModule (pytorch#2913) Summary: inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Differential Revision: D73448087
seanx92
added a commit
to seanx92/torchrec
that referenced
this pull request
Apr 28, 2025
…sionModule (pytorch#2913) Summary: inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Differential Revision: D73448087
seanx92
force-pushed
the
export-D73448087
branch
from
e141a1b to
a1d9034
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73448087 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D73448087 |
seanx92
added a commit
to seanx92/torchrec
that referenced
this pull request
Apr 28, 2025
…sionModule (pytorch#2913) Summary: Pull Request resolved: pytorch#2913 inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Differential Revision: D73448087
seanx92
force-pushed
the
export-D73448087
branch
from
a1d9034 to
e3c91aa
Compare
seanx92
added a commit
to seanx92/torchrec
that referenced
this pull request
Apr 28, 2025
…sionModule (pytorch#2913) Summary: inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Reviewed By: zlzhao1104 Differential Revision: D73448087
seanx92
force-pushed
the
export-D73448087
branch
from
e3c91aa to
cd33349
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73448087 |
seanx92
added a commit
to seanx92/torchrec
that referenced
this pull request
Apr 28, 2025
…sionModule (pytorch#2913) Summary: Pull Request resolved: pytorch#2913 inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Reviewed By: zlzhao1104 Differential Revision: D73448087
seanx92
force-pushed
the
export-D73448087
branch
from
cd33349 to
96852a3
Compare
…sionModule (pytorch#2913) Summary: inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449 by moving it to leaf function we guaranteed no side effect during fx tracing. Reviewed By: zlzhao1104 Differential Revision: D73448087
seanx92
force-pushed
the
export-D73448087
branch
from
96852a3 to
aac0608
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73448087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
inplace update will cause unexpected module attribute mutation described in pytorch/pytorch#70449
by moving it to leaf function we guaranteed no side effect during fx tracing.
Differential Revision: D73448087