Skip to content

set DDR size in planner to 0 #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

set DDR size in planner to 0 #3052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion torchrec/distributed/planner/shard_estimators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,7 +1245,8 @@ def calculate_shard_storages(
for _ in hbm_specific_sizes
]
ddr_specific_sizes = [
(key_value_params.l2_cache_size or 0) * 1024 * 1024 * 1024
# TODO: revisit the logic for SSD virtual table
0
for _ in ddr_specific_sizes
]

Expand Down
6 changes: 3 additions & 3 deletions torchrec/distributed/planner/tests/test_planners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ def test_planner_with_virtual_table(self) -> None:
# L1 cache size is 64GB per shard and L2 cache size is 128MB per shard per table
self.assertTrue(
any(
"dram_virtual_table: HBM: 0.501 GB, DDR: 256.0 GB" in line
"dram_virtual_table: HBM: 0.501 GB, DDR: 0.0 GB" in line
for line in stats
)
)
Expand Down Expand Up @@ -748,7 +748,7 @@ def test_planner_with_virtual_table(self) -> None:
# L2 cache size is 128MB per shard per table
self.assertTrue(
any(
"dram_virtual_table: HBM: 0.002 GB, DDR: 256.0 GB" in line
"dram_virtual_table: HBM: 0.002 GB, DDR: 0.0 GB" in line
for line in stats
)
)
Expand Down Expand Up @@ -800,7 +800,7 @@ def test_planner_with_virtual_table(self) -> None:
# L2 cache size is 128MB per shard per table
self.assertTrue(
any(
"dram_virtual_table: HBM: 0.005 GB, DDR: 256.0 GB" in line
"dram_virtual_table: HBM: 0.005 GB, DDR: 0.0 GB" in line
for line in stats
)
)
Expand Down
Loading