-
Notifications
You must be signed in to change notification settings - Fork 44
[Feature] Load partially instantiated state-dict #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 90.40% 84.22% -6.19%
==========================================
Files 25 25
Lines 2346 2384 +38
==========================================
- Hits 2121 2008 -113
- Misses 225 376 +151
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @vmoens, thank you so much for raising the issue and drafting a proposal! Previously, in order to reduce the memory footprint on load, we would find the tensors in the target module's state dict, in-place restore them, and use them to build a state dict for Your proposal made us realize that this is not the right approach. Instead, we should always rebuild the original state dict and reuse the tensor in the target's module's state dict in addition. This way we can achieve the same memory saving while making the behavior much more general. |
Hi @vmoens! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary:
Allows to load
state_dict
s from disk when the saved copy contains more elements that the pre-populated copy.Test plan:
TODO
Fixes #{issue number}
Closes #101