-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workflow to build torchtitan-ubuntu-20.04-clang12 Docker image for CI #338
Conversation
Looking at the CI results from this PR, it looks like it spent 6 minutes in 'calculate docker image' step. If I look inside there it looks like it's building the image. I guess that's automated such that it would build a new image automatically if it detected a change in the build scripts (e.g. if requirements.txt got updated), but then it hits the cache and skips the build time normally? |
Re-running the job now to observe how it behaves on the second run. |
Yup, you're right.
|
…for CI (#338) Adopt from PyTorch, this workflow will prepare the Docker image `torchtitan-ubuntu-20.04-clang12` for the CI. * Base on https://hub.docker.com/layers/nvidia/cuda/12.1.0-cudnn8-runtime-ubuntu20.04/images/sha256-35d5a8eb50ad37fe707a7611a4e20414c5bd2f168adca0cf1700fe2d58411759 to include NVIDIA dependencies. * Install `dev-requirements.txt` and `requirements.txt`. I need to move these files from the top level to `.ci/docker` directory and create softlinks for them because docker build process will only take a look at `.ci/docker`. This is the reason why PyTorch keeps its CI requirements file there. * Install clang or gcc * Install conda (with python 3.11) `torchtitan-ubuntu-20.04-clang12` can then be used as the input for `docker-image`.
…for CI (pytorch#338) Adopt from PyTorch, this workflow will prepare the Docker image `torchtitan-ubuntu-20.04-clang12` for the CI. * Base on https://hub.docker.com/layers/nvidia/cuda/12.1.0-cudnn8-runtime-ubuntu20.04/images/sha256-35d5a8eb50ad37fe707a7611a4e20414c5bd2f168adca0cf1700fe2d58411759 to include NVIDIA dependencies. * Install `dev-requirements.txt` and `requirements.txt`. I need to move these files from the top level to `.ci/docker` directory and create softlinks for them because docker build process will only take a look at `.ci/docker`. This is the reason why PyTorch keeps its CI requirements file there. * Install clang or gcc * Install conda (with python 3.11) `torchtitan-ubuntu-20.04-clang12` can then be used as the input for `docker-image`.
…for CI (#338) Adopt from PyTorch, this workflow will prepare the Docker image `torchtitan-ubuntu-20.04-clang12` for the CI. * Base on https://hub.docker.com/layers/nvidia/cuda/12.1.0-cudnn8-runtime-ubuntu20.04/images/sha256-35d5a8eb50ad37fe707a7611a4e20414c5bd2f168adca0cf1700fe2d58411759 to include NVIDIA dependencies. * Install `dev-requirements.txt` and `requirements.txt`. I need to move these files from the top level to `.ci/docker` directory and create softlinks for them because docker build process will only take a look at `.ci/docker`. This is the reason why PyTorch keeps its CI requirements file there. * Install clang or gcc * Install conda (with python 3.11) `torchtitan-ubuntu-20.04-clang12` can then be used as the input for `docker-image`.
…for CI (pytorch#338) Adopt from PyTorch, this workflow will prepare the Docker image `torchtitan-ubuntu-20.04-clang12` for the CI. * Base on https://hub.docker.com/layers/nvidia/cuda/12.1.0-cudnn8-runtime-ubuntu20.04/images/sha256-35d5a8eb50ad37fe707a7611a4e20414c5bd2f168adca0cf1700fe2d58411759 to include NVIDIA dependencies. * Install `dev-requirements.txt` and `requirements.txt`. I need to move these files from the top level to `.ci/docker` directory and create softlinks for them because docker build process will only take a look at `.ci/docker`. This is the reason why PyTorch keeps its CI requirements file there. * Install clang or gcc * Install conda (with python 3.11) `torchtitan-ubuntu-20.04-clang12` can then be used as the input for `docker-image`.
Adopt from PyTorch, this workflow will prepare the Docker image
torchtitan-ubuntu-20.04-clang12
for the CI.dev-requirements.txt
andrequirements.txt
. I need to move these files from the top level to.ci/docker
directory and create softlinks for them because docker build process will only take a look at.ci/docker
. This is the reason why PyTorch keeps its CI requirements file there.torchtitan-ubuntu-20.04-clang12
can then be used as the input fordocker-image
.