uniformly use skip for both (map-style) Dataset and IterableDataset #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Aug 15, 2024
ghstack-source-id: d82c233f21dddc74794d9c492a781dffc52eb5de Pull Request resolved: #521
facebook-github-bot
added
the
CLA Signed
…leDataset" [ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Aug 15, 2024
ghstack-source-id: c8f611742ffbb4859988b97e706b9e0d1b4ad6f1 Pull Request resolved: #521
tianyu-l
added a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: c8f611742ffbb4859988b97e706b9e0d1b4ad6f1 Pull Request resolved: #521
tianyu-l
added a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: c8f611742ffbb4859988b97e706b9e0d1b4ad6f1 Pull Request resolved: #521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The support of
skipon "anIterableDatasetobtained fromsplit_dataset_by_node" has landed in huggingface/datasets#6965 and released in https://github.com/huggingface/datasets/releases/tag/2.21.0For previous discussions see
https://discuss.huggingface.co/t/skip-not-implemented-for-iterabledataset-after-split-dataset-by-node/91450
I manually did a unit-test on the c4 dataset (as an
IterableDataset) by replacing https://github.com/pytorch/torchtitan/blob/main/test/datasets/test_checkpoint.py#L14