Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessible config as dict #754

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

casper-hansen
Copy link
Contributor

Here is a PR to make it a bit easier to observe the configuration across different experiments. This is generally useful for MLOps to observe the exact configuration of your training run.

For example, this makes it easier for a user to extend the code and log the config in Weights & Biases:

wandb.init(config=job_config.to_dict())

@facebook-github-bot
Copy link

Hi @casper-hansen!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 18, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@awgu
Copy link
Contributor

awgu commented Dec 18, 2024

seems ok to me
will let @tianyu-l review

@awgu awgu requested a review from tianyu-l December 18, 2024 16:03
Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you!

@casper-hansen
Copy link
Contributor Author

@tianyu-l I just merged main branch into my PR to clear the CI. It looks like a green check from the CI is the last step before this can be merged.

@awgu
Copy link
Contributor

awgu commented Dec 19, 2024

@casper-hansen I re-triggered CI

@tianyu-l tianyu-l merged commit d67f7f9 into pytorch:main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants