fix num_microbatches input for PP #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
H-Huang
added a commit
that referenced
this pull request
Jan 7, 2025
ghstack-source-id: 20fc75fbdcd6283459c4dd3b98df183ad32fe094 Pull Request resolved: #781
facebook-github-bot
added
the
CLA Signed
H-Huang
requested review from
tianyu-l and
wconstab
and removed request for
tianyu-l
PP is using the `pipeline_parallel_degree` as the default number of microbatches when it should be `pipeline_parallel_degree * len(stages)` for multi-stage schedules. Also fixed up some logging / added logging. [ghstack-poisoned]
H-Huang
added a commit
that referenced
this pull request
Jan 7, 2025
ghstack-source-id: 459e8bee48fd77b027fecdc9e5f78ec375b87cb6 Pull Request resolved: #781
H-Huang
added a commit
that referenced
this pull request
Jan 7, 2025
ghstack-source-id: 459e8bee48fd77b027fecdc9e5f78ec375b87cb6 Pull Request resolved: #781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
PP is using the
pipeline_parallel_degreeas the default number of microbatches when it should bepipeline_parallel_degree * len(stages)for multi-stage schedules.Also fixed up some logging / added logging.