validate checkpoint is consistent with meta_to_tune flag #2736
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2736
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6647e8c with merge base 0a08c2f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74784778 |
Summary: add a flag that do validation when load_checkpoint passed unexpected meta_to_tune flag. i.e. if this flag is true but checkpoint is not in meta format, or if this flag is flase but checkpoint is in meta format Do validation early to avoid unexpected error later. Differential Revision: D74784778
|
This pull request was exported from Phabricator. Differential Revision: D74784778 |
Summary: Pull Request resolved: pytorch#2736 add a flag that do validation when load_checkpoint passed unexpected meta_to_tune flag. i.e. if this flag is true but checkpoint is not in meta format, or if this flag is flase but checkpoint is in meta format Do validation early to avoid unexpected error later. Differential Revision: D74784778
Summary: add a flag that do validation when load_checkpoint passed unexpected meta_to_tune flag. i.e. if this flag is true but checkpoint is not in meta format, or if this flag is flase but checkpoint is in meta format Do validation early to avoid unexpected error later. Differential Revision: D74784778
|
This pull request was exported from Phabricator. Differential Revision: D74784778 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2736 +/- ##
==========================================
- Coverage 60.64% 59.93% -0.71%
==========================================
Files 428 430 +2
Lines 26091 26435 +344
==========================================
+ Hits 15823 15844 +21
- Misses 10268 10591 +323 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I don't think we should land this in OSS torchtune. If I understand correctly this is only needed for internal checkpointer implementations? In torchtune we have a specific class for Meta format checkpoints, so adding this functionality can cause confusion. Also it will just be zombie code. Personally I would recommend to implement this inside of the internal integration layer instead
Summary:
add a flag that do validation when load_checkpoint passed unexpected meta_to_tune flag.
i.e. if this flag is true but checkpoint is not in meta format, or
if this flag is flase but checkpoint is in meta format
Do validation early to avoid unexpected error later.
Differential Revision: D74784778