torchx/schedulers

Differential Revision: D52948910 Pull Request resolved: #807
pytorch · Jan 24, 2024 · 19497eb · 19497eb
1 parent 89cf8e1
commit 19497eb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/torchx/schedulers/gcp_batch_scheduler.py b/torchx/schedulers/gcp_batch_scheduler.py
@@ -205,12 +205,14 @@ def _app_to_job(self, app: AppDef) -> "batch_v1.Job":
             if cpu <= 0:
                 cpu = 1
             MILLI = 1000
+            # pyre-fixme[8]: Attribute has type `Field`; used as `int`.
             res.cpu_milli = cpu * MILLI
             memMB = resource.memMB
             if memMB < 0:
                 raise ValueError(
                     f"memMB should to be set to a positive value, got {memMB}"
                 )
+            # pyre-fixme[8]: Attribute has type `Field`; used as `int`.
             res.memory_mib = memMB
 
             # TODO support named resources
@@ -358,11 +360,13 @@ def describe(self, app_id: str) -> Optional[DescribeAppResponse]:
             return None
 
         gpu = 0
+        # pyre-fixme[16]: `Field` has no attribute `instances`.
         if len(job.allocation_policy.instances) != 0:
             gpu_type = job.allocation_policy.instances[0].policy.machine_type
             gpu = GPU_TYPE_TO_COUNT[gpu_type]
 
         roles = {}
+        # pyre-fixme[16]: `RepeatedField` has no attribute `__iter__`.
         for tg in job.task_groups:
             env = tg.task_spec.environment.variables
             role = env["TORCHX_ROLE_NAME"]
@@ -386,6 +390,7 @@ def describe(self, app_id: str) -> Optional[DescribeAppResponse]:
         # TODO map role/replica status
         desc = DescribeAppResponse(
             app_id=app_id,
+            # pyre-fixme[16]: `Field` has no attribute `state`.
             state=JOB_STATE[job.status.state.name],
             roles=list(roles.values()),
         )

diff --git a/torchx/schedulers/test/gcp_batch_scheduler_test.py b/torchx/schedulers/test/gcp_batch_scheduler_test.py
@@ -83,7 +83,9 @@ def test_submit_dryrun(self) -> None:
         env["TORCHX_ROLE_NAME"] = "trainer"
         env["FOO"] = "bar"
         res = batch_v1.ComputeResource()
+        # pyre-fixme[8]: Attribute has type `Field`; used as `int`.
         res.cpu_milli = 2000
+        # pyre-fixme[8]: Attribute has type `Field`; used as `int`.
         res.memory_mib = 3000
         allocationPolicy = batch_v1.AllocationPolicy(
             instances=[