Added error with repeated component arguments

Differential Revision: D56225842 Pull Request resolved: #887
pytorch · Apr 17, 2024 · b3d3d39 · b3d3d39
1 parent 2066171
commit b3d3d39
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/torchx/cli/cmd_run.py b/torchx/cli/cmd_run.py
@@ -11,6 +11,7 @@
 import os
 import sys
 import threading
+from collections import Counter
 from dataclasses import asdict
 from pathlib import Path
 from pprint import pformat
@@ -84,6 +85,13 @@ def _parse_component_name_and_args(
             component = args[0]
             component_args = args[1:]
 
+    # Error if there are repeated command line arguments
+    all_options = [x for x in component_args if x.startswith("-")]
+    arg_count = Counter(all_options)
+    duplicates = [arg for arg, count in arg_count.items() if count > 1]
+    if len(duplicates) > 0:
+        subparser.error(f"Repeated Command Line Arguments: {duplicates}")
+
     if not component:
         subparser.error(MISSING_COMPONENT_ERROR_MSG)
 

diff --git a/torchx/cli/test/cmd_run_test.py b/torchx/cli/test/cmd_run_test.py
@@ -239,6 +239,12 @@ def test_parse_component_name_and_args_no_default(self) -> None:
         with self.assertRaises(SystemExit):
             _parse_component_name_and_args(["-m", "hello"], sp)
 
+        with self.assertRaises(SystemExit):
+            _parse_component_name_and_args(["-m", "hello", "-m", "repeate"], sp)
+
+        with self.assertRaises(SystemExit):
+            _parse_component_name_and_args(["--msg", "hello", "--msg", "repeate"], sp)
+
     def test_parse_component_name_and_args_with_default(self) -> None:
         sp = argparse.ArgumentParser(prog="test")
         dirs = [str(self.tmpdir)]