Allow empty session name for APIs that take it #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
Summary: Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Differential Revision: D73799333
facebook-github-bot
force-pushed
the
export-D73799333
branch
from
4944e5f to
43eea72
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
kiukchung
added a commit
that referenced
this pull request
Apr 29, 2025
Summary: Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Differential Revision: D73799333
kiukchung
force-pushed
the
export-D73799333
branch
from
43eea72 to
9846f4f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
kiukchung
added a commit
that referenced
this pull request
Apr 29, 2025
Summary: Pull Request resolved: #1057 Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Differential Revision: D73799333
kiukchung
force-pushed
the
export-D73799333
branch
from
9846f4f to
b784694
Compare
highker
approved these changes
Apr 29, 2025
kiukchung
added a commit
that referenced
this pull request
Apr 29, 2025
Summary: Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Reviewed By: highker, daniel-ohayon Differential Revision: D73799333
kiukchung
force-pushed
the
export-D73799333
branch
from
b784694 to
58597d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
kiukchung
added a commit
that referenced
this pull request
Apr 29, 2025
Summary: Pull Request resolved: #1057 Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Reviewed By: highker, daniel-ohayon Differential Revision: D73799333
kiukchung
force-pushed
the
export-D73799333
branch
from
58597d3 to
9863b87
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
Summary: Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Reviewed By: highker, daniel-ohayon Differential Revision: D73799333
facebook-github-bot
force-pushed
the
export-D73799333
branch
from
9863b87 to
6e5f6a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
kiukchung
added a commit
that referenced
this pull request
Apr 30, 2025
Summary: Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Reviewed By: highker, daniel-ohayon Differential Revision: D73799333
kiukchung
force-pushed
the
export-D73799333
branch
from
6e5f6a7 to
428e2cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
kiukchung
added a commit
that referenced
this pull request
Apr 30, 2025
Summary: Pull Request resolved: #1057 Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Reviewed By: highker, daniel-ohayon Differential Revision: D73799333
kiukchung
force-pushed
the
export-D73799333
branch
from
428e2cd to
1532ba4
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
Summary: Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Reviewed By: highker, daniel-ohayon Differential Revision: D73799333
facebook-github-bot
force-pushed
the
export-D73799333
branch
from
1532ba4 to
c318fc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
daniel-ohayon
approved these changes
Apr 30, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
Summary: Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Reviewed By: highker, daniel-ohayon Differential Revision: D73799333
facebook-github-bot
force-pushed
the
export-D73799333
branch
from
c318fc3 to
80a9bc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
kiukchung
added a commit
that referenced
this pull request
May 1, 2025
Summary: Pull Request resolved: #1057 Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Reviewed By: highker, daniel-ohayon Differential Revision: D73799333
kiukchung
force-pushed
the
export-D73799333
branch
from
80a9bc3 to
01a2e9a
Compare
Summary: Pull Request resolved: #1057 Makes the session name returning and accepting APIs symmetric by allowing empty session names. Today `torchx.runner.Runner()` takes an empty string as `session_name` and returns an `app_handle` with an empty session name (e.g. `local:///app-id`) when the `run()` or `schedule()` methods are called (see the newly added unittest in `torchx/runner/test/api_test.py#test_empty_session_id()`) However runner APIs that accept `app_handle` (e.g. `runner.cancel()`) will error when the session name is empty. This makes the APIs non-symmetric since the `app_handle` returned by `run/schedule` APIs cannot be used. This PR fixes this. Reviewed By: highker, daniel-ohayon Differential Revision: D73799333
|
This pull request was exported from Phabricator. Differential Revision: D73799333 |
kiukchung
force-pushed
the
export-D73799333
branch
from
01a2e9a to
6ae5ba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Makes the session name returning and accepting APIs symmetric by allowing empty session names.
Today
torchx.runner.Runner()takes an empty string assession_nameand returns anapp_handlewith an empty session name (e.g.local:///app-id) when therun()orschedule()methods are called (see the newly added unittest intorchx/runner/test/api_test.py#test_empty_session_id())However runner APIs that accept
app_handle(e.g.runner.cancel()) will error when the session name is empty. This makes the APIs non-symmetric since theapp_handlereturned byrun/scheduleAPIs cannot be used.This PR fixes this.
Differential Revision: D73799333