Skip to content

feat: add rdzv_conf to dist.ddp (#1071) #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add rdzv_conf to dist.ddp (#1071) #1072

wants to merge 1 commit into from

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented May 23, 2025

  • add rdzv_conf to dist.ddp
  • remove redundant docstring for spmd

Test plan:
[x] unit test, the default behavior is intact

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2025
@clumsy
Copy link
Contributor Author

clumsy commented May 23, 2025

For your consideration @kiukchung , @d4l3k , @tonykao8080 , @andywag

@clumsy
Copy link
Contributor Author

clumsy commented Jun 5, 2025

Could you please have a look? @kiukchung @d4l3k @tonykao8080 @andywag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clumsy @facebook-github-bot @azzhipa