-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding module lookup for building trackers #803
Conversation
For your consideration, @kurman and @kiukchung. |
9c90c3e
to
f51a32b
Compare
@kiukchung removed hydra usage, following entrypoint syntax. Please let me know if you have further comments. |
f51a32b
to
bc135cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR (and removing the hydra dep). Could you update the docs as well?
Its all done via docstrings in torchx/tracker/__init__.py
You'll want to update the Tracker Setup
and split out the rest of the docs into entry_point
and module
registrations.
You can preview the docs locally by:
$ cd docs
$ pip install -r requirements.txt
$ make clean html
$ python -m http.server -d build/0.7.0.dev0/html
Then opening up the docs page on https://localhost:8080
see docs-build CI action for details.
bc135cf
to
bd97b1f
Compare
Ok @kiukchung I addressed the comments, updated the documentation. Additionally I extracted the |
bd97b1f
to
063626f
Compare
I addressed an unrelated check failure due a broken link in Kubernetes docs. KPF seem to fail for an unrelated reason, @kiukchung. |
@kiukchung do I need to make furhter changes to this PR? I don't have conflicts when fetch/rebasing on top of |
Discussed this in #802
TL;DR this adds the ability to reference a module path instead of entry_point for tracker backend as a fallback when entry_point is not found, e.g.:
Test plan: