Adding Override Option for TorchX Role #956
Merged
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62591176 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62591176 |
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: pytorch#956 Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging Differential Revision: D62591176
andywag
force-pushed
the
export-D62591176
branch
from
c31bbdc
to
4d81c76
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62591176 |
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: pytorch#956 Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging Reviewed By: Sanjay-Ganeshan Differential Revision: D62591176
andywag
force-pushed
the
export-D62591176
branch
from
4d81c76
to
ad30d78
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62591176 |
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: pytorch#956 Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging Reviewed By: Sanjay-Ganeshan Differential Revision: D62591176
andywag
force-pushed
the
export-D62591176
branch
from
ad30d78
to
b02b2f3
Compare
Sanjay-Ganeshan
approved these changes
Sep 17, 2024
Summary: Pull Request resolved: pytorch#956 Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging Reviewed By: Sanjay-Ganeshan Differential Revision: D62591176
|
This pull request was exported from Phabricator. Differential Revision: D62591176 |
andywag
force-pushed
the
export-D62591176
branch
from
b02b2f3
to
0c8d577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds a generic way to override the internal values of the Role. Allows async overriding of role values and enable Async Packaging
Differential Revision: D62591176