Add new Python and C++/CUDA Custom Op tutorials #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2888
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit af4fbe5 with merge base 63f987d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@svekars is there a way to bypass the pyspelling check? |
svekars
reviewed
May 29, 2024
svekars
reviewed
May 29, 2024
albanD
reviewed
May 30, 2024
| This does not test that the gradients are mathematically correct; please write | ||
| separate tests for that (either manual ones or torch.autograd.gradcheck). | ||
|
|
||
| .. code-block:: python |
There was a problem hiding this comment.
Interesting that this is not the same as the one from the python tutorial
There was a problem hiding this comment.
I wrote them at different times. I can make them the same if we want.
svekars
reviewed
May 30, 2024
svekars
reviewed
May 30, 2024
@zou3519 Please fix what's fixable. Words like PIL's you can add to en-wordlist.txt. Things like FakeTensor should be put in backticks ( |
svekars
reviewed
Jun 13, 2024
svekars
reviewed
Jun 13, 2024
I want to land this before PyTorch 2.4 (so we can link to these in PyTorch's nightly documentation) and then have a follow-up PR for 2.4 that actually runs the scripts (so that they can generate outputs). pytorch/pytorch#127443 to remind myself of the above. NB: These two tutorials replace all of the existing custom ops (and cpp extensions) tutorials: - advanced/cpp_extension - advanced/torch_script_custom_ops - advanced/torch_script_custom_classes - advanced/dispatcher In a follow-up PR we will add warnings to all of those tutorials stating that they are deprecated but we will preserve the text just in case people still need them (e.g. if they are not using PyTorch 2.4). Test Plan: - I tested these locally.
ignaciobartol
pushed a commit
to ignaciobartol/tutorials
that referenced
this pull request
Jun 24, 2024
* Add new Python and C++/CUDA Custom Op tutorials I want to land this before PyTorch 2.4 (so we can link to these in PyTorch's nightly documentation) and then have a follow-up PR for 2.4 that actually runs the scripts (so that they can generate outputs). pytorch/pytorch#127443 to remind myself of the above. NB: These two tutorials replace all of the existing custom ops (and cpp extensions) tutorials: - advanced/cpp_extension - advanced/torch_script_custom_ops - advanced/torch_script_custom_classes - advanced/dispatcher In a follow-up PR we will add warnings to all of those tutorials stating that they are deprecated but we will preserve the text just in case people still need them (e.g. if they are not using PyTorch 2.4). Test Plan: - I tested these locally. * Fix cpp custom ops tutorial per review * update * update index.rst * Update * update * update
ignaciobartol
pushed a commit
to ignaciobartol/tutorials
that referenced
this pull request
Jun 24, 2024
* Add new Python and C++/CUDA Custom Op tutorials I want to land this before PyTorch 2.4 (so we can link to these in PyTorch's nightly documentation) and then have a follow-up PR for 2.4 that actually runs the scripts (so that they can generate outputs). pytorch/pytorch#127443 to remind myself of the above. NB: These two tutorials replace all of the existing custom ops (and cpp extensions) tutorials: - advanced/cpp_extension - advanced/torch_script_custom_ops - advanced/torch_script_custom_classes - advanced/dispatcher In a follow-up PR we will add warnings to all of those tutorials stating that they are deprecated but we will preserve the text just in case people still need them (e.g. if they are not using PyTorch 2.4). Test Plan: - I tested these locally. * Fix cpp custom ops tutorial per review * update * update index.rst * Update * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to land this before PyTorch 2.4 (so we can link to these in PyTorch's nightly documentation) and then have a follow-up PR for 2.4 that actually runs the scripts (so that they can generate outputs).
pytorch/pytorch#127443 to remind myself of the above.
NB: These two tutorials replace all of the existing custom ops (and cpp extensions) tutorials:
In a follow-up PR we will add warnings to all of those tutorials stating that they are deprecated but we will preserve the text just in case people still need them (e.g. if they are not using PyTorch 2.4).
Test Plan:
Fixes #ISSUE_NUMBER
Description
Checklist