-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tutorial for PyTorch Flight recorder #3024
Conversation
Summary: Add a tutorial file for flight recorder. Test Plan: N/A Reviewers: Subscribers: Tasks: Tags:
Add dump example and command line.
Summary: Update tutorial Test Plan: Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3024
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 44493fb with merge base a811de6 (): NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah! Finally we have the tutorial for our users.
Summary: Add missing sections from the template and clarify some notes further in the tutorial.
Summary: add missing "what you will learn" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary: Add flight recorder to index file.
Thanks for updating the weblink, by looking at preview, link: https://docs-preview.pytorch.org/pytorch/tutorials/3024/prototype/flight_recorder_tutorial.html there are things I noticed:
Since you are the UI expert here, you know how to fix better than me. I just want to bring the awareness to you. Once we are happy with the actual preview, I think we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An editorial pass and some formatting fixes. Let me know if you have any questions.
Address code formatting changes Co-authored-by: Svetlana Karslioglu <[email protected]>
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Test Plan: Ran rst2html5 and viewed HTML on browser.
* Add [dtensor][debug] CommDebugMode recipe --------- Co-authored-by: Svetlana Karslioglu <[email protected]>
* Add programmable Google Search to pytorch tutorials site
* Tutorial for AOTI Python runtime --------- Co-authored-by: Svetlana Karslioglu <[email protected]> Co-authored-by: Angela Yi <[email protected]>
- Add a policy for new tutorials submissions --------- Co-authored-by: albanD <[email protected]> Co-authored-by: Nikita Shulga <[email protected]>
…ere'/identified zip file (#3015)
* Add weights_only=True to torch.load
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
* Fix hovering over the GCS search button
…ExecuTorch (#3016) * Added warnings to select ExecuTorch tutorials/recipes/prototypes * Added warnings to select ExecuTorch tutorials/recipes/prototypes * Added redirect for renamed prototype * Update deeplabv3_on_android.rst Fixed misplaced info tag. * Apply suggestions from code review --------- Co-authored-by: Svetlana Karslioglu <[email protected]>
* Patched docs for torch_compile_tutorial --------- Co-authored-by: Svetlana Karslioglu <[email protected]>
This allows one to install pygame binaries for Python-3.11/3.12 runtime, while PyGame-2.1.2 was only available up to python-3.10, see https://pypi.org/project/pygame/2.1.2/#files Fixes #3023
Add onnxruntime dependency
* Fixed Rst formatting, minor text changes * Removed duplicate sentence about CUDA hardware that is already mentioned in the intro text. Minor text change. --------- Co-authored-by: Svetlana Karslioglu <[email protected]>
* Add meta tag to torch_export_aoti_python * Feature on the landing page
* Fix reference to DCP * Keep import style as saving --------- Co-authored-by: Iris Z <[email protected]>
1f33f46
to
4223ce7
Compare
Oops. I did a bad rebase ... fixing it. |
4223ce7
to
44493fb
Compare
Abandoning this branch as I did a bad merge to main. I'll make a new PR ... sorry about that! |
Summary: Recreating pull request #3024 because of bad merges. Re-add flight recorder tutorial with prior comments addressed Test Plan: Ran: rst2html5 flight_recorder_tutorial.rst flight_recorder_tutorial.html Reviewers: fduwjj, svekars
Summary: Recreating pull request #3024 because of bad merges. Re-add flight recorder tutorial with prior comments addressed Test Plan: Ran: rst2html5 flight_recorder_tutorial.rst flight_recorder_tutorial.html Reviewers: fduwjj, svekars
Summary: Recreating pull request #3024 because of bad merges. Re-add flight recorder tutorial with prior comments addressed Test Plan: Ran: rst2html5 flight_recorder_tutorial.rst flight_recorder_tutorial.html Reviewers: fduwjj, svekars
Summary: Recreating pull request #3024 because of bad merges. Re-add flight recorder tutorial with prior comments addressed Test Plan: Ran: rst2html5 flight_recorder_tutorial.rst flight_recorder_tutorial.html Reviewers: fduwjj, svekars
* [c10d][Doc] Add a flight recorder tutorial Summary: Recreated pull request #3024 because of bad merges. Re-add flight recorder tutorial with prior comments addressed. Test Plan: Ran: rst2html5 flight_recorder_tutorial.rst flight_recorder_tutorial.html Co-authored-by: Svetlana Karslioglu <[email protected]>
Add a tutorial for PyTorch Flight Recorder
Description
We are announcing PyTorch flight recorder as a prototype feature in PyTorch 2.5. Add a small tutorial on how to configure and use flight recorder.
Checklist