[DO NOT MERGE] 2.6 RC Test

.ci/docker/requirements.txt

@@ -28,8 +28,8 @@ tensorboard
 jinja2==3.1.3
 pytorch-lightning
 torchx
-torchrl==0.5.0
-tensordict==0.5.0
+torchrl==0.6.0
+tensordict==0.6.0
 ax-platform>=0.4.0
 nbformat>=5.9.2
 datasets

.jenkins/build.sh

@@ -22,8 +22,10 @@ sudo apt-get install -y pandoc
 #Install PyTorch Nightly for test.
 # Nightly - pip install --pre torch torchvision torchaudio -f https://download.pytorch.org/whl/nightly/cu102/torch_nightly.html
 # Install 2.5 to merge all 2.4 PRs - uncomment to install nightly binaries (update the version as needed).
-# pip uninstall -y torch torchvision torchaudio torchtext torchdata
-# pip3 install torch==2.5.0 torchvision torchaudio --no-cache-dir --index-url https://download.pytorch.org/whl/test/cu124
+sudo pip uninstall -y torch torchvision torchaudio torchtext torchdata
+sudo pip3 install torch==2.6.0 torchvision --no-cache-dir --index-url https://download.pytorch.org/whl/test/cu124
+sudo pip uninstall -y fbgemm-gpu torchrec
+sudo pip3 install fbgemm-gpu==1.1.0 torchrec==1.0.0 --no-cache-dir --index-url https://download.pytorch.org/whl/test/cu124
 
 # Install two language tokenizers for Translation with TorchText tutorial
 python -m spacy download en_core_web_sm

.jenkins/validate_tutorials_built.py

@@ -51,7 +51,8 @@
     "intermediate_source/flask_rest_api_tutorial",
     "intermediate_source/text_to_speech_with_torchaudio",
     "intermediate_source/tensorboard_profiler_tutorial", # reenable after 2.0 release.
-    "intermediate_source/torch_export_tutorial" # reenable after 2940 is fixed.
+    "intermediate_source/torch_export_tutorial", # reenable after 2940 is fixed.
+    "prototype_source/gpu_quantization_torchao_tutorial", # enable when 3194
 ]
 
 def tutorial_source_dirs() -> List[Path]:

advanced_source/coding_ddpg.py

@@ -893,7 +893,7 @@ def make_recorder(actor_model_explore, transform_state_dict, record_interval):
         record_frames=1000,
         policy_exploration=actor_model_explore,
         environment=environment,
-        exploration_type=ExplorationType.MEAN,
+        exploration_type=ExplorationType.DETERMINISTIC,
         record_interval=record_interval,
     )
     return recorder_obj

advanced_source/pendulum.py

@@ -604,7 +604,7 @@ def __init__(self, td_params=None, seed=None, device="cpu"):
     env,
     # ``Unsqueeze`` the observations that we will concatenate
     UnsqueezeTransform(
-        unsqueeze_dim=-1,
+        dim=-1,
         in_keys=["th", "thdot"],
         in_keys_inv=["th", "thdot"],
     ),

beginner_source/onnx/export_simple_model_to_onnx_tutorial.py

@@ -7,7 +7,7 @@
 Export a PyTorch model to ONNX
 ==============================
 
-**Author**: `Thiago Crepaldi <https://github.com/thiagocrepaldi>`_
+**Author**: `Ti-Tai Wang <https://github.com/titaiwangms>`_ and `Xavier Dupré <https://github.com/xadupre>`_
 
 .. note::
     As of PyTorch 2.1, there are two versions of ONNX Exporter.
@@ -127,7 +127,7 @@ def forward(self, x):
 # Once Netron is open, we can drag and drop our ``my_image_classifier.onnx`` file into the browser or select it after
 # clicking the **Open model** button.
 #
-# .. image:: ../../_static/img/onnx/image_clossifier_onnx_modelon_netron_web_ui.png
+# .. image:: ../../_static/img/onnx/image_classifier_onnx_model_on_netron_web_ui.png
 #   :width: 50%
 #
 #
@@ -155,7 +155,7 @@ def forward(self, x):
 
 import onnxruntime
 
-onnx_input = onnx_program.adapt_torch_inputs_to_onnx(torch_input)
+onnx_input = [torch_input]
 print(f"Input length: {len(onnx_input)}")
 print(f"Sample input: {onnx_input}")
 
@@ -166,7 +166,8 @@ def to_numpy(tensor):
 
 onnxruntime_input = {k.name: to_numpy(v) for k, v in zip(ort_session.get_inputs(), onnx_input)}
 
-onnxruntime_outputs = ort_session.run(None, onnxruntime_input)
+# onnxruntime returns a list of outputs
+onnxruntime_outputs = ort_session.run(None, onnxruntime_input)[0]
 
 ####################################################################
 # 7. Compare the PyTorch results with the ones from the ONNX Runtime
@@ -179,7 +180,6 @@ def to_numpy(tensor):
 # Before comparing the results, we need to convert the PyTorch's output to match ONNX's format.
 
 torch_outputs = torch_model(torch_input)
-torch_outputs = onnx_program.adapt_torch_outputs_to_onnx(torch_outputs)
 
 assert len(torch_outputs) == len(onnxruntime_outputs)
 for torch_output, onnxruntime_output in zip(torch_outputs, onnxruntime_outputs):

beginner_source/onnx/intro_onnx.py

@@ -7,7 +7,7 @@
 ====================
 
 Authors:
-`Thiago Crepaldi <https://github.com/thiagocrepaldi>`_,
+`Ti-Tai Wang <https://github.com/titaiwangms>`_ and `Xavier Dupré <https://github.com/xadupre>`_
 
 `Open Neural Network eXchange (ONNX) <https://onnx.ai/>`_ is an open standard
 format for representing machine learning models. The ``torch.onnx`` module provides APIs to

beginner_source/onnx/onnx_registry_tutorial.py

@@ -31,148 +31,15 @@
 #
 # In this tutorial, we will cover three scenarios that require extending the ONNX registry with custom operators:
 #
-# * Unsupported ATen operators
 # * Custom operators with existing ONNX Runtime support
 # * Custom operators without ONNX Runtime support
 #
-# Unsupported ATen operators
-# --------------------------
-#
-# Although the ONNX exporter team does their best efforts to support all ATen operators, some of them
-# might not be supported yet. In this section, we will demonstrate how you can add
-# unsupported ATen operators to the ONNX Registry.
-#
-# .. note::
-#       The steps to implement unsupported ATen operators are the same to replace the implementation of an existing
-#       ATen operator with a custom implementation.
-#       Because we don't actually have an unsupported ATen operator to use in this tutorial, we are going to leverage
-#       this and replace the implementation of ``aten::add.Tensor`` with a custom implementation the same way we would
-#       if the operator was not present in the ONNX Registry.
-#
-# When a model cannot be exported to ONNX due to an unsupported operator, the ONNX exporter will show an error message
-# similar to:
-#
-# .. code-block:: python
-#
-#   RuntimeErrorWithDiagnostic: Unsupported FX nodes: {'call_function': ['aten.add.Tensor']}.
-#
-# The error message indicates that the fully qualified name of unsupported ATen operator is ``aten::add.Tensor``.
-# The fully qualified name of an operator is composed of the namespace, operator name, and overload following
-# the format ``namespace::operator_name.overload``.
-#
-# To add support for an unsupported ATen operator or to replace the implementation for an existing one, we need:
-#
-# * The fully qualified name of the ATen operator (e.g. ``aten::add.Tensor``).
-#   This information is always present in the error message as show above.
-# * The implementation of the operator using `ONNX Script <https://github.com/microsoft/onnxscript>`__.
-#   ONNX Script is a prerequisite for this tutorial. Please make sure you have read the
-#   `ONNX Script tutorial <https://github.com/microsoft/onnxscript/blob/main/docs/tutorial/index.md>`_
-#   before proceeding.
-#
-# Because ``aten::add.Tensor`` is already supported by the ONNX Registry, we will demonstrate how to replace it with a
-# custom implementation, but keep in mind that the same steps apply to support new unsupported ATen operators.
-#
-# This is possible because the :class:`OnnxRegistry` allows users to override an operator registration.
-# We will override the registration of ``aten::add.Tensor`` with our custom implementation and verify it exists.
-#
 
 import torch
 import onnxruntime
 import onnxscript
 from onnxscript import opset18  # opset 18 is the latest (and only) supported version for now
 
-class Model(torch.nn.Module):
-    def forward(self, input_x, input_y):
-        return torch.ops.aten.add(input_x, input_y)  # generates a aten::add.Tensor node
-
-input_add_x = torch.randn(3, 4)
-input_add_y = torch.randn(3, 4)
-aten_add_model = Model()
-
-
-# Now we create a ONNX Script function that implements ``aten::add.Tensor``.
-# The function name (e.g. ``custom_aten_add``) is displayed in the ONNX graph, so we recommend to use intuitive names.
-custom_aten = onnxscript.values.Opset(domain="custom.aten", version=1)
-
-# NOTE: The function signature must match the signature of the unsupported ATen operator.
-# https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/native_functions.yaml
-# NOTE: All attributes must be annotated with type hints.
-@onnxscript.script(custom_aten)
-def custom_aten_add(input_x, input_y, alpha: float = 1.0):
-    input_y = opset18.Mul(input_y, alpha)
-    return opset18.Add(input_x, input_y)
-
-
-# Now we have everything we need to support unsupported ATen operators.
-# Let's register the ``custom_aten_add`` function to ONNX registry, and export the model to ONNX again.
-onnx_registry = torch.onnx.OnnxRegistry()
-onnx_registry.register_op(
-    namespace="aten", op_name="add", overload="Tensor", function=custom_aten_add
-    )
-print(f"aten::add.Tensor is supported by ONNX registry: \
-      {onnx_registry.is_registered_op(namespace='aten', op_name='add', overload='Tensor')}"
-      )
-export_options = torch.onnx.ExportOptions(onnx_registry=onnx_registry)
-onnx_program = torch.onnx.dynamo_export(
-    aten_add_model, input_add_x, input_add_y, export_options=export_options
-    )
-
-######################################################################
-# Now let's inspect the model and verify the model has a ``custom_aten_add`` instead of ``aten::add.Tensor``.
-# The graph has one graph node for ``custom_aten_add``, and inside of it there are four function nodes, one for each
-# operator, and one for constant attribute.
-#
-
-# graph node domain is the custom domain we registered
-assert onnx_program.model_proto.graph.node[0].domain == "custom.aten"
-assert len(onnx_program.model_proto.graph.node) == 1
-# graph node name is the function name
-assert onnx_program.model_proto.graph.node[0].op_type == "custom_aten_add"
-# function node domain is empty because we use standard ONNX operators
-assert {node.domain for node in onnx_program.model_proto.functions[0].node} == {""}
-# function node name is the standard ONNX operator name
-assert {node.op_type for node in onnx_program.model_proto.functions[0].node} == {"Add", "Mul", "Constant"}
-
-
-######################################################################
-# This is how ``custom_aten_add_model`` looks in the ONNX graph using Netron:
-#
-# .. image:: /_static/img/onnx/custom_aten_add_model.png
-#    :width: 70%
-#    :align: center
-#
-# Inside the ``custom_aten_add`` function, we can see the three ONNX nodes we
-# used in the function (``CastLike``, ``Add``, and ``Mul``), and one ``Constant`` attribute:
-#
-# .. image:: /_static/img/onnx/custom_aten_add_function.png
-#    :width: 70%
-#    :align: center
-#
-# This was all that we needed to register the new ATen operator into the ONNX Registry.
-# As an additional step, we can use ONNX Runtime to run the model, and compare the results with PyTorch.
-#
-
-
-# Use ONNX Runtime to run the model, and compare the results with PyTorch
-onnx_program.save("./custom_add_model.onnx")
-ort_session = onnxruntime.InferenceSession(
-    "./custom_add_model.onnx", providers=['CPUExecutionProvider']
-    )
-
-def to_numpy(tensor):
-    return tensor.detach().cpu().numpy() if tensor.requires_grad else tensor.cpu().numpy()
-
-onnx_input = onnx_program.adapt_torch_inputs_to_onnx(input_add_x, input_add_y)
-onnxruntime_input = {k.name: to_numpy(v) for k, v in zip(ort_session.get_inputs(), onnx_input)}
-onnxruntime_outputs = ort_session.run(None, onnxruntime_input)
-
-torch_outputs = aten_add_model(input_add_x, input_add_y)
-torch_outputs = onnx_program.adapt_torch_outputs_to_onnx(torch_outputs)
-
-assert len(torch_outputs) == len(onnxruntime_outputs)
-for torch_output, onnxruntime_output in zip(torch_outputs, onnxruntime_outputs):
-    torch.testing.assert_close(torch_output, torch.tensor(onnxruntime_output))
-
 
 ######################################################################
 # Custom operators with existing ONNX Runtime support
@@ -262,12 +129,11 @@ def custom_aten_gelu(input_x, approximate: str = "none"):
 def to_numpy(tensor):
     return tensor.detach().cpu().numpy() if tensor.requires_grad else tensor.cpu().numpy()
 
-onnx_input = onnx_program.adapt_torch_inputs_to_onnx(input_gelu_x)
+onnx_input = [input_gelu_x]
 onnxruntime_input = {k.name: to_numpy(v) for k, v in zip(ort_session.get_inputs(), onnx_input)}
-onnxruntime_outputs = ort_session.run(None, onnxruntime_input)
+onnxruntime_outputs = ort_session.run(None, onnxruntime_input)[0]
 
 torch_outputs = aten_gelu_model(input_gelu_x)
-torch_outputs = onnx_program.adapt_torch_outputs_to_onnx(torch_outputs)
 
 assert len(torch_outputs) == len(onnxruntime_outputs)
 for torch_output, onnxruntime_output in zip(torch_outputs, onnxruntime_outputs):
@@ -369,25 +235,17 @@ def custom_addandround(input_x):
 #
 
 assert onnx_program.model_proto.graph.node[0].domain == "test.customop"
-assert onnx_program.model_proto.graph.node[0].op_type == "custom_addandround"
-assert onnx_program.model_proto.functions[0].node[0].domain == "test.customop"
-assert onnx_program.model_proto.functions[0].node[0].op_type == "CustomOpOne"
-assert onnx_program.model_proto.functions[0].node[1].domain == "test.customop"
-assert onnx_program.model_proto.functions[0].node[1].op_type == "CustomOpTwo"
+assert onnx_program.model_proto.graph.node[0].op_type == "CustomOpOne"
+assert onnx_program.model_proto.graph.node[1].domain == "test.customop"
+assert onnx_program.model_proto.graph.node[1].op_type == "CustomOpTwo"
 
 
 ######################################################################
-# This is how ``custom_addandround_model`` ONNX graph looks using Netron:
-#
-# .. image:: /_static/img/onnx/custom_addandround_model.png
-#    :width: 70%
-#    :align: center
-#
-# Inside the ``custom_addandround`` function, we can see the two custom operators we
-# used in the function (``CustomOpOne``, and ``CustomOpTwo``), and they are from module
-# ``test.customop``:
+# This is how ``custom_addandround_model`` ONNX graph looks using Netron. 
+# We can see the two custom operators we used in the function (``CustomOpOne``, and ``CustomOpTwo``), 
+# and they are from module ``test.customop``:
 #
-# .. image:: /_static/img/onnx/custom_addandround_function.png
+# .. image:: /_static/img/onnx/custom_addandround.png
 #
 # Custom Ops Registration in ONNX Runtime
 # ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

intermediate_source/dqn_with_rnn_tutorial.py

@@ -433,7 +433,7 @@
     exploration_module.step(data.numel())
     updater.step()
 
-    with set_exploration_type(ExplorationType.MODE), torch.no_grad():
+    with set_exploration_type(ExplorationType.DETERMINISTIC), torch.no_grad():
         rollout = env.rollout(10000, stoch_policy)
         traj_lens.append(rollout.get(("next", "step_count")).max().item())
 

intermediate_source/reinforcement_ppo.py

@@ -419,8 +419,8 @@
     in_keys=["loc", "scale"],
     distribution_class=TanhNormal,
     distribution_kwargs={
-        "min": env.action_spec.space.low,
-        "max": env.action_spec.space.high,
+        "low": env.action_spec.space.low,
+        "high": env.action_spec.space.high,
     },
     return_log_prob=True,
     # we'll need the log-prob for the numerator of the importance weights