Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning raised by torch.meshgrid on missing indexing #8689

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Oct 17, 2024

Description:

Calling torch.meshgrid(x, y) without indexing argument raises this warning:

[/opt/conda/lib/python3.11/site-packages/torch/functional.py:513](http://localhost:2211/lab/tree/jax-ai-stack/docs/opt/conda/lib/python3.11/site-packages/torch/functional.py#line=512): UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at /opt/conda/conda-bld/pytorch_1720538435607/work/aten/src/ATen/native/TensorShape.cpp:3609.)
  return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]

This PR added indexing with its default value in the places where it is missing.

Copy link

pytorch-bot bot commented Oct 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8689

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 5 Unrelated Failures

As of commit ec06fa8 with merge base acbfd8d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review @vfdev-5 , thanks for the PR!

@NicolasHug NicolasHug merged commit 9756650 into main Nov 27, 2024
33 of 48 checks passed
@NicolasHug NicolasHug deleted the fix-warning-meshgrid-indexing branch November 27, 2024 18:21
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants