Skip to content

Commit

Permalink
Fixed masked_scatter and masked_select (#8037)
Browse files Browse the repository at this point in the history
  • Loading branch information
anishfish2 committed Sep 18, 2024
1 parent b79a46b commit 5267354
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 2 deletions.
2 changes: 0 additions & 2 deletions experimental/torch_xla2/test/test_ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@
"lu_solve",
"lu_unpack",
"masked.median",
"masked_scatter",
"masked_select",
"max_pool2d_with_indices_backward",
"min",
"mode",
Expand Down
35 changes: 35 additions & 0 deletions experimental/torch_xla2/torch_xla2/ops/jaten.py
Original file line number Diff line number Diff line change
Expand Up @@ -1366,6 +1366,41 @@ def _aten_scatter_add(input, dim, index, src):
input_indexes, source_indexes = _scatter_index(dim, index)
return input.at[input_indexes].add(src[source_indexes])

# aten.masked_scatter
@op(torch.ops.aten.masked_scatter)
def _aten_masked_scatter(self, mask, source):

broadcast_shape = jnp.broadcast_shapes(self.shape, mask.shape)

if self.shape != broadcast_shape:
self = jnp.broadcast_to(self, broadcast_shape)
elif mask.shape != broadcast_shape:
mask = jnp.broadcast_to(mask, broadcast_shape)

self_flat = self.flatten()
mask_flat = mask.flatten()
source_flat = source.flatten()

true_indices = jnp.where(mask_flat)[0]
self_flat = self_flat.at[true_indices].set(source_flat[:len(true_indices)])
final_arr = self_flat.reshape(self.shape)

return final_arr

@op(torch.ops.aten.masked_select)
def _aten_masked_select(self, mask, *args, **kwargs):
broadcast_shape = jnp.broadcast_shapes(self.shape, mask.shape)

if self.shape != broadcast_shape:
self = jnp.broadcast_to(self, broadcast_shape)
if mask.shape != broadcast_shape:
mask = jnp.broadcast_to(mask, broadcast_shape)

self_flat = self.flatten()
mask_flat = mask.flatten()
true_indices = jnp.where(mask_flat)[0]

return self_flat[true_indices]

# aten.logical_not

Expand Down

0 comments on commit 5267354

Please sign in to comment.