[WIP] Skip AOTAutograd view-reconstruction for inference runs. #7834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Applying handlers only to the actual outputs - Unwrapping the value before using it to create a fresh functional tensor
|
This PR is still being tested on Torchbench. It should be compiled with this branch of PyTorch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-implements part of the AOTAutograd view-reconstruction logic, so that we are able to skip it on inference runs. Most of the discussion can be found in #5430. This should avoid falling back to non-dynamo tracing outside the compiled graph.
cc @miladm @JackCaoG