Skip to content

Update ci.md and fix typo #9150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

Update ci.md and fix typo #9150

merged 2 commits into from
May 20, 2025

Conversation

tengyifei
Copy link
Collaborator

We always run TPU tests on all PRs now after capacity expansion

@tengyifei tengyifei marked this pull request as ready for review May 13, 2025 00:16
@tengyifei tengyifei requested review from ghpvnist and sdasgup3 May 13, 2025 00:20
@tengyifei
Copy link
Collaborator Author

@ghpvnist fwiw I found a bug in the build skipping feature: https://github.com/pytorch/xla/actions/runs/14985259094/job/42097972657?pr=9150

I think the "build-docs" workflow somehow depends on the torch_xla_wheels. I suspect now that we're not building PyTorch/XLA wheels in every PR, that step now fails.

Copy link
Collaborator

@sdasgup3 sdasgup3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor comments. LGTM otherwise.

@ghpvnist
Copy link
Collaborator

@ghpvnist fwiw I found a bug in the build skipping feature: https://github.com/pytorch/xla/actions/runs/14985259094/job/42097972657?pr=9150

I think the "build-docs" workflow somehow depends on the torch_xla_wheels. I suspect now that we're not building PyTorch/XLA wheels in every PR, that step now fails.

The fix for this has been merged. Once you rebase to head, this should be a quick submit :)

tengyifei added 2 commits May 20, 2025 07:29
We always run TPU tests on all PRs now after capacity expansion
@tengyifei tengyifei force-pushed the yifeit/torchprime-ci branch from a2f0e5a to 63cf96d Compare May 20, 2025 07:33
@tengyifei tengyifei enabled auto-merge (squash) May 20, 2025 07:34
@tengyifei tengyifei merged commit 0b6349b into master May 20, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants