Add cache to value_and_grad_partitioned
#9163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracing that is time consuming.
|
@tengyifei please review |
|
@tengyifei a kindly ping |
|
Hi @iwknow I was on vacation. I'll review this soon. |
|
@tengyifei a kindly ping |
tengyifei
requested changes
Jun 3, 2025
…`setUp()` to clear cache. 3. update `test_scan_computation_cache` test to count how many times the fn is called
|
@tengyifei updated. please review again. thanks! |
tengyifei
requested changes
Jun 4, 2025
|
Thanks! |
tengyifei
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cache to
value_and_grad_partitioned, which perform AOTAutograd tracing that is time consuming.The cache is controlled by
is_fn_pure. the cache key is composed of all the inputs ofscan(i.e. fn, init, xs, partition_fn).this addresses #8632